From 3ed38df17596b6225aae9fda1c515e4b316f90d5 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Sat, 17 Oct 2020 02:43:02 -0700 Subject: [PATCH] TurboModule Android: Remove RNTester module lookup override Summary: The manual lookup logic was needed before we properly parse the module names from the spec js files. This is no longer necessary after the commit stack starting with https://github.com/facebook/react-native/commit/3a75b376cc3c44f9693d99b33046cf76d6fafa89 Changelog: [Internal] Reviewed By: RSNara Differential Revision: D24370567 fbshipit-source-id: fc307d93cdda240a977e37dfe602502bd3f7c2a4 --- .../main/jni/RNTesterAppModuleProvider.cpp | 47 ------------------- 1 file changed, 47 deletions(-) diff --git a/packages/rn-tester/android/app/src/main/jni/RNTesterAppModuleProvider.cpp b/packages/rn-tester/android/app/src/main/jni/RNTesterAppModuleProvider.cpp index 06c20c981c..854775a6b1 100644 --- a/packages/rn-tester/android/app/src/main/jni/RNTesterAppModuleProvider.cpp +++ b/packages/rn-tester/android/app/src/main/jni/RNTesterAppModuleProvider.cpp @@ -25,53 +25,6 @@ std::shared_ptr RNTesterAppModuleProvider(const std::string moduleN return module; } - // TODO: fix up the ReactAndroidSpec_ModuleProvider() to avoid the Android prefix. - if (moduleName == "DatePicker") { - return std::make_shared(params); - } - if (moduleName == "DialogManager") { - return std::make_shared(params); - } - if (moduleName == "ImageLoader") { - return std::make_shared(params); - } - if (moduleName == "Networking") { - return std::make_shared(params); - } - if (moduleName == "Permissions") { - return std::make_shared(params); - } - if (moduleName == "PlatformConstants") { - return std::make_shared(params); - } - if (moduleName == "StatusBarManager") { - return std::make_shared(params); - } - if (moduleName == "Toast") { - return std::make_shared(params); - } - - // TODO: handle some special case naming. - if (moduleName == "IntentAndroid") { - return std::make_shared(params); - } - - // TODO: Animated module has special cases. - if ("NativeAnimatedModule" == moduleName) { - return std::make_shared(params); - } - if ("NativeAnimatedTurboModule" == moduleName) { - return std::make_shared(params); - } - - // TODO: handle multiple names for one spec. - if ("AsyncLocalStorage" == moduleName) { - return std::make_shared(params); - } - if ("AsyncSQLiteDBStorage" == moduleName) { - return std::make_shared(params); - } - return ReactAndroidSpec_ModuleProvider(moduleName, params); }