Attempt to fix T40449334 by adding DoNotStrip to interface
Summary: Java symbols are likely being stripped at compile-time, preventing Reflection from working properly in C++. Should fix T40449334. Reviewed By: mdvacca Differential Revision: D14070629 fbshipit-source-id: f180fa3294b66f660ab1568250c47432cbf0c774
This commit is contained in:
Родитель
6082431c5d
Коммит
51b868728a
|
@ -6,13 +6,17 @@
|
|||
*/
|
||||
package com.facebook.react.fabric;
|
||||
|
||||
import com.facebook.proguard.annotations.DoNotStrip;
|
||||
|
||||
// This is a wrapper for the ReactNativeConfig object in C++
|
||||
@DoNotStrip
|
||||
public interface ReactNativeConfig {
|
||||
/**
|
||||
* Get a boolean param by string name. Default should be false.
|
||||
*
|
||||
* @param param The string name of the parameter being requested.
|
||||
*/
|
||||
@DoNotStrip
|
||||
boolean getBool(String param);
|
||||
|
||||
/**
|
||||
|
@ -20,6 +24,7 @@ public interface ReactNativeConfig {
|
|||
*
|
||||
* @param param The string name of the parameter being requested.
|
||||
*/
|
||||
@DoNotStrip
|
||||
int getInt64(String param);
|
||||
|
||||
/**
|
||||
|
@ -27,6 +32,7 @@ public interface ReactNativeConfig {
|
|||
*
|
||||
* @param param The string name of the parameter being requested.
|
||||
*/
|
||||
@DoNotStrip
|
||||
String getString(String param);
|
||||
|
||||
/**
|
||||
|
@ -34,5 +40,6 @@ public interface ReactNativeConfig {
|
|||
*
|
||||
* @param param The string name of the parameter being requested.
|
||||
*/
|
||||
@DoNotStrip
|
||||
double getDouble(String param);
|
||||
}
|
||||
|
|
|
@ -127,9 +127,7 @@ void Binding::installFabricUIManager(
|
|||
eventBeatManager, runtime, localJavaUIManager);
|
||||
};
|
||||
|
||||
// TODO: Provide non-empty impl for ReactNativeConfig.
|
||||
std::shared_ptr<const ReactNativeConfig> config =
|
||||
std::make_shared<const ReactNativeConfigHolder>(reactNativeConfig);
|
||||
std::shared_ptr<const ReactNativeConfig> config = std::make_shared<const ReactNativeConfigHolder>(reactNativeConfig);
|
||||
contextContainer->registerInstance(config, "ReactNativeConfig");
|
||||
contextContainer->registerInstance<EventBeatFactory>(
|
||||
synchronousBeatFactory, "synchronous");
|
||||
|
|
Загрузка…
Ссылка в новой задаче