From 597a35117d72ccd19d01d470eb6063754d863a6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eloy=20Dur=C3=A1n?= Date: Thu, 8 Oct 2020 20:35:56 +0200 Subject: [PATCH] [TextInput] Leave as-of-yet unsupported features disabled --- Libraries/Text/TextInput/Multiline/RCTUITextView.m | 4 ++-- Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/Text/TextInput/Multiline/RCTUITextView.m b/Libraries/Text/TextInput/Multiline/RCTUITextView.m index 522fc5c794..32b64531d2 100644 --- a/Libraries/Text/TextInput/Multiline/RCTUITextView.m +++ b/Libraries/Text/TextInput/Multiline/RCTUITextView.m @@ -340,13 +340,13 @@ static RCTUIColor *defaultPlaceholderColor() // TODO(OSS Candidate ISS#2710739) { [super selectAll:sender]; -#if !TARGET_OS_OSX // [TODO(macOS v0.63) +#if !TARGET_OS_OSX // TODO(macOS ISS#2323203) For `selectTextOnFocus` prop, which isn't supported on macOS atm. // `selectAll:` does not work for UITextView when it's being called inside UITextView's delegate methods. dispatch_async(dispatch_get_main_queue(), ^{ UITextRange *selectionRange = [self textRangeFromPosition:self.beginningOfDocument toPosition:self.endOfDocument]; [self setSelectedTextRange:selectionRange notifyDelegate:NO]; }); -#endif // ]TODO(macOS v0.63) +#endif } #pragma mark - Layout diff --git a/Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h b/Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h index a9388f1c77..c2d4117561 100644 --- a/Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h +++ b/Libraries/Text/TextInput/RCTBackedTextInputViewProtocol.h @@ -50,9 +50,9 @@ NS_ASSUME_NONNULL_BEGIN @property (nonatomic, assign, getter=isEditable) BOOL editable; @property (nonatomic, assign) BOOL caretHidden; @property (nonatomic, assign) BOOL enablesReturnKeyAutomatically; -#if !TARGET_OS_OSX // [TODO(macOS v0.63) +#if !TARGET_OS_OSX // TODO(macOS ISS#2323203) @property (nonatomic, assign) UITextFieldViewMode clearButtonMode; -#endif // ]TODO(macOS v0.63) +#endif // TODO(macOS ISS#2323203) @property (nonatomic, getter=isScrollEnabled) BOOL scrollEnabled; // This protocol disallows direct access to `selectedTextRange` property because