Rename onCatalystInstanceDestroy -> invalidate (#39611)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 877c5af6ad0fc378ec9cbd952f33db0ea08f761c
This commit is contained in:
Родитель
36057dac59
Коммит
5f215cdde2
|
@ -370,7 +370,7 @@ public class CatalystInstanceImpl implements CatalystInstance {
|
|||
public void run() {
|
||||
// We need to destroy the TurboModuleManager on the JS Thread
|
||||
if (mTurboModuleManagerJSIModule != null) {
|
||||
mTurboModuleManagerJSIModule.onCatalystInstanceDestroy();
|
||||
mTurboModuleManagerJSIModule.invalidate();
|
||||
}
|
||||
|
||||
getReactQueueConfiguration()
|
||||
|
|
|
@ -18,5 +18,5 @@ public interface JSIModule {
|
|||
void initialize();
|
||||
|
||||
/** Called before {CatalystInstance#onHostDestroy} */
|
||||
void onCatalystInstanceDestroy();
|
||||
void invalidate();
|
||||
}
|
||||
|
|
|
@ -31,7 +31,7 @@ public class JSIModuleHolder {
|
|||
|
||||
public void notifyJSInstanceDestroy() {
|
||||
if (mModule != null) {
|
||||
mModule.onCatalystInstanceDestroy();
|
||||
mModule.invalidate();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -411,7 +411,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
|
|||
@Override
|
||||
@AnyThread
|
||||
@ThreadConfined(ANY)
|
||||
public void onCatalystInstanceDestroy() {
|
||||
public void invalidate() {
|
||||
FLog.i(TAG, "FabricUIManager.onCatalystInstanceDestroy");
|
||||
|
||||
if (mDevToolsReactPerfLogger != null) {
|
||||
|
|
|
@ -414,8 +414,8 @@ final class ReactInstance {
|
|||
/* package */ void destroy() {
|
||||
FLog.d(TAG, "ReactInstance.destroy() is called.");
|
||||
mQueueConfiguration.destroy();
|
||||
mTurboModuleManager.onCatalystInstanceDestroy();
|
||||
mFabricUIManager.onCatalystInstanceDestroy();
|
||||
mTurboModuleManager.invalidate();
|
||||
mFabricUIManager.invalidate();
|
||||
mHybridData.resetNative();
|
||||
mComponentNameResolverManager = null;
|
||||
mUIConstantsProviderManager = null;
|
||||
|
|
|
@ -423,7 +423,7 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry {
|
|||
public void initialize() {}
|
||||
|
||||
@Override
|
||||
public void onCatalystInstanceDestroy() {
|
||||
public void invalidate() {
|
||||
/*
|
||||
* Halt the production of new TurboModules.
|
||||
*
|
||||
|
|
|
@ -34,4 +34,10 @@ interface TurboModuleRegistry {
|
|||
* NativeModules.
|
||||
*/
|
||||
val eagerInitModuleNames: List<String>
|
||||
|
||||
/**
|
||||
* Called during the turn down process of ReactHost. This method is called before React Native is
|
||||
* stopped.
|
||||
*/
|
||||
fun invalidate()
|
||||
}
|
||||
|
|
|
@ -195,7 +195,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule
|
|||
}
|
||||
|
||||
@Override
|
||||
public void onCatalystInstanceDestroy() {
|
||||
public void invalidate() {
|
||||
super.onCatalystInstanceDestroy();
|
||||
mEventDispatcher.onCatalystInstanceDestroyed();
|
||||
mUIImplementation.onCatalystInstanceDestroyed();
|
||||
|
|
Загрузка…
Ссылка в новой задаче