From 630ac87591eb9d535bc32c6c42c624bfc3f1953f Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Wed, 3 Mar 2021 13:02:53 -0800 Subject: [PATCH] Report initial offset of horizontal scroll view to Fabric Summary: Changelog: [internal] Calling `scrollTo` does not report offset change to Fabric core and measure infra can't compute correct values. This results in unresponsive buttons if horizontal scroll view on Android has initial offset set to anything besides default value 0. Reviewed By: JoshuaGross Differential Revision: D26778991 fbshipit-source-id: 5cad5cb9926c7923f6efcd56cb4e15c3b958c245 --- .../views/scroll/ReactHorizontalScrollContainerView.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollContainerView.java b/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollContainerView.java index 6db6df6688..15aa7bfb7a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollContainerView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollContainerView.java @@ -8,7 +8,6 @@ package com.facebook.react.views.scroll; import android.content.Context; -import android.widget.HorizontalScrollView; import androidx.core.view.ViewCompat; import com.facebook.react.modules.i18nmanager.I18nUtil; import com.facebook.react.views.view.ReactViewGroup; @@ -40,10 +39,10 @@ public class ReactHorizontalScrollContainerView extends ReactViewGroup { setRight(newRight); // Call with the present values in order to re-layout if necessary - HorizontalScrollView parent = (HorizontalScrollView) getParent(); + ReactHorizontalScrollView parent = (ReactHorizontalScrollView) getParent(); // Fix the ScrollX position when using RTL language int offsetX = parent.getScrollX() + getWidth() - mCurrentWidth; - parent.scrollTo(offsetX, parent.getScrollY()); + parent.reactScrollTo(offsetX, parent.getScrollY()); } mCurrentWidth = getWidth(); }