Rename JavaScriptTimerManager to JavaScriptTimerExecutor
Summary: This JavaScriptTimerManager interface calls into JavaScript to execute timers. For that reason, I think JavaScriptTimerExecutor is a better name for the interface. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D30851912 fbshipit-source-id: de282068d18693fd67331586e66847105ea16531
This commit is contained in:
Родитель
ffcaef64e4
Коммит
657c48c21d
|
@ -10,7 +10,7 @@ package com.facebook.react.modules.core;
|
|||
import com.facebook.react.bridge.WritableArray;
|
||||
|
||||
/** An interface used by {@link JavaTimerManager} to access and call JS timers from Java. */
|
||||
public interface JavaScriptTimerManager {
|
||||
public interface JavaScriptTimerExecutor {
|
||||
|
||||
/**
|
||||
* Calls the JS callback(s) associated with the timer ID(s). Also unregisters the callback if the
|
|
@ -81,7 +81,7 @@ public class JavaTimerManager {
|
|||
}
|
||||
|
||||
if (mTimersToCall != null) {
|
||||
mJavaScriptTimerManager.callTimers(mTimersToCall);
|
||||
mJavaScriptTimerExecutor.callTimers(mTimersToCall);
|
||||
mTimersToCall = null;
|
||||
}
|
||||
|
||||
|
@ -139,7 +139,7 @@ public class JavaTimerManager {
|
|||
}
|
||||
|
||||
if (sendIdleEvents) {
|
||||
mJavaScriptTimerManager.callIdleCallbacks(absoluteFrameStartTime);
|
||||
mJavaScriptTimerExecutor.callIdleCallbacks(absoluteFrameStartTime);
|
||||
}
|
||||
|
||||
mCurrentIdleCallbackRunnable = null;
|
||||
|
@ -151,7 +151,7 @@ public class JavaTimerManager {
|
|||
}
|
||||
|
||||
private final ReactApplicationContext mReactApplicationContext;
|
||||
private final JavaScriptTimerManager mJavaScriptTimerManager;
|
||||
private final JavaScriptTimerExecutor mJavaScriptTimerExecutor;
|
||||
private final ReactChoreographer mReactChoreographer;
|
||||
private final DevSupportManager mDevSupportManager;
|
||||
private final Object mTimerGuard = new Object();
|
||||
|
@ -169,11 +169,11 @@ public class JavaTimerManager {
|
|||
|
||||
public JavaTimerManager(
|
||||
ReactApplicationContext reactContext,
|
||||
JavaScriptTimerManager javaScriptTimerManager,
|
||||
JavaScriptTimerExecutor javaScriptTimerManager,
|
||||
ReactChoreographer reactChoreographer,
|
||||
DevSupportManager devSupportManager) {
|
||||
mReactApplicationContext = reactContext;
|
||||
mJavaScriptTimerManager = javaScriptTimerManager;
|
||||
mJavaScriptTimerExecutor = javaScriptTimerManager;
|
||||
mReactChoreographer = reactChoreographer;
|
||||
mDevSupportManager = devSupportManager;
|
||||
|
||||
|
@ -327,7 +327,7 @@ public class JavaTimerManager {
|
|||
if (mDevSupportManager.getDevSupportEnabled()) {
|
||||
long driftTime = Math.abs(remoteTime - deviceTime);
|
||||
if (driftTime > 60000) {
|
||||
mJavaScriptTimerManager.emitTimeDriftWarning(
|
||||
mJavaScriptTimerExecutor.emitTimeDriftWarning(
|
||||
"Debugger and device times have drifted by more than 60s. Please correct this by "
|
||||
+ "running adb shell \"date `date +%m%d%H%M%Y.%S`\" on your debugger machine.");
|
||||
}
|
||||
|
@ -338,7 +338,7 @@ public class JavaTimerManager {
|
|||
if (duration == 0 && !repeat) {
|
||||
WritableArray timerToCall = Arguments.createArray();
|
||||
timerToCall.pushInt(callbackID);
|
||||
mJavaScriptTimerManager.callTimers(timerToCall);
|
||||
mJavaScriptTimerExecutor.callTimers(timerToCall);
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
|
@ -22,7 +22,7 @@ import com.facebook.react.module.annotations.ReactModule;
|
|||
public final class TimingModule extends NativeTimingSpec
|
||||
implements LifecycleEventListener, HeadlessJsTaskEventListener {
|
||||
|
||||
public class BridgeTimerManager implements JavaScriptTimerManager {
|
||||
public class BridgeTimerExecutor implements JavaScriptTimerExecutor {
|
||||
@Override
|
||||
public void callTimers(WritableArray timerIDs) {
|
||||
ReactApplicationContext reactApplicationContext = getReactApplicationContextIfActiveOrWarn();
|
||||
|
@ -61,7 +61,7 @@ public final class TimingModule extends NativeTimingSpec
|
|||
mJavaTimerManager =
|
||||
new JavaTimerManager(
|
||||
reactContext,
|
||||
new BridgeTimerManager(),
|
||||
new BridgeTimerExecutor(),
|
||||
ReactChoreographer.getInstance(),
|
||||
devSupportManager);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче