From 6651b7c59b5c9c182198e8d83f86d01556328475 Mon Sep 17 00:00:00 2001 From: Panagiotis Vekris Date: Wed, 6 Jan 2021 17:22:30 -0800 Subject: [PATCH] restore core lib Flow definitions for Request, Response, etc. Summary: The main change of this diff is in file react-native-github/interface.js. This file used to override the definitions for `fetch`, `Headers`, `Request`, `Response`, `requestAnimationFrame` of flow/lib/bom.js and type them as `any` instead. This is inconsistent with the rest of the flow library definitions that expect `Request`, for example, to be adequately typed. Overriding this defnition with `any` raises `[value-as-type]` errors in the library definitions themselves. Due to a Flow bug, these errors were silently suppressed, leading to loss of coverage. I'm trying to clean-up these errors and fix the Flow bug so that library errors are always surfaced. This diff also: * Removes 53 unused suppression comments * Adds 110 new error suppressions Changelog: [Internal] Reviewed By: pieterv Differential Revision: D25806504 fbshipit-source-id: e312bc5d64818b63c3b8b4f86dea51e13aacfac0 --- interface.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/interface.js b/interface.js index a5e7987fe7..22337a9873 100644 --- a/interface.js +++ b/interface.js @@ -15,11 +15,3 @@ declare var __DEV__: boolean; declare var __REACT_DEVTOOLS_GLOBAL_HOOK__: any; /*?{ inject: ?((stuff: Object) => void) };*/ - -declare var fetch: any; -declare var Headers: any; -declare var Request: any; -declare var Response: any; -declare module requestAnimationFrame { - declare module.exports: (callback: any) => any; -}