Minor Style: Make viewName nullable in native animated modules for Fabric
Summary: Make viewName in native animations nullable, because viewName is not used when the RCTAnimationNode is managed by Fabric. Changelog: [Internal] Minor: Make viewName nullable in native animated modules for Fabric Reviewed By: philIip Differential Revision: D32196270 fbshipit-source-id: 76d05dc7fd2850efb097f953ccd22fd3f6d80599
This commit is contained in:
Родитель
e9ed115bab
Коммит
698a936e4d
|
@ -40,7 +40,7 @@
|
|||
|
||||
- (void)connectAnimatedNodeToView:(nonnull NSNumber *)nodeTag
|
||||
viewTag:(nonnull NSNumber *)viewTag
|
||||
viewName:(nonnull NSString *)viewName;
|
||||
viewName:(NSString *)viewName;
|
||||
|
||||
- (void)restoreDefaultValues:(nonnull NSNumber *)nodeTag;
|
||||
|
||||
|
|
|
@ -146,10 +146,11 @@ static NSString *RCTNormalizeAnimatedEventName(NSString *eventName)
|
|||
|
||||
- (void)connectAnimatedNodeToView:(nonnull NSNumber *)nodeTag
|
||||
viewTag:(nonnull NSNumber *)viewTag
|
||||
viewName:(nonnull NSString *)viewName
|
||||
viewName:(NSString *)viewName
|
||||
{
|
||||
RCTAnimatedNode *node = _animationNodes[nodeTag];
|
||||
if ([node isKindOfClass:[RCTPropsAnimatedNode class]]) {
|
||||
// viewName is not used when node is managed by Fabric
|
||||
[(RCTPropsAnimatedNode *)node connectToView:viewTag
|
||||
viewName:viewName
|
||||
bridge:_bridge
|
||||
|
|
|
@ -188,8 +188,8 @@ RCT_EXPORT_METHOD(connectAnimatedNodeToView:(double)nodeTag
|
|||
[_nodeIDsManagedByFabric addObject:@(nodeTag)];
|
||||
}
|
||||
[self addOperationBlock:^(RCTNativeAnimatedNodesManager *nodesManager) {
|
||||
NSString *viewName; // Not used when node is managed by Fabric. Nodes are always managed by Fabric in Bridgeless.
|
||||
[nodesManager connectAnimatedNodeToView:[NSNumber numberWithDouble:nodeTag] viewTag:[NSNumber numberWithDouble:viewTag] viewName:viewName];
|
||||
// viewName is not used when node is managed by Fabric, and nodes are always managed by Fabric in Bridgeless.
|
||||
[nodesManager connectAnimatedNodeToView:[NSNumber numberWithDouble:nodeTag] viewTag:[NSNumber numberWithDouble:viewTag] viewName:nil];
|
||||
}];
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче