From 6b3d25a07589baa88a1b2084ee67fafc87e430be Mon Sep 17 00:00:00 2001 From: Ingrid Wang Date: Tue, 26 Sep 2023 10:26:06 -0700 Subject: [PATCH] Update deprecated stringByAddingPercentEscapesUsingEncoding to NSCharacterSet (#39638) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39638 # Changelog: [Internal] - Removing usage of stringByAddingPercentEscapesUsingEncoding Per deprecation message: > 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0 - Use -stringByAddingPercentEncodingWithAllowedCharacters: instead, which always uses the recommended UTF-8 encoding, and which encodes for a specific URL component or subcomponent since each URL component or subcomponent has different rules for what characters are valid. Reviewed By: cipolleschi Differential Revision: D49610243 fbshipit-source-id: 7c40ce9f6b643851c8aae8149acde2c435c06a76 --- .../renderer/imagemanager/RCTImagePrimitivesConversions.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h index b5f61f8a4e..0aa6a75b92 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h @@ -64,7 +64,8 @@ inline static NSURL *NSURLFromImageSource(const facebook::react::ImageSource &im if ([urlString rangeOfString:@":"].location != NSNotFound) { // The URL has a scheme. - urlString = [urlString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; + urlString = + [urlString stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]]; url = [NSURL URLWithString:urlString]; return url; }