From 6b42bcc1f433671e90b1ec0b67bbbab46cd9d48a Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Fri, 14 Jan 2022 16:29:10 -0800 Subject: [PATCH] Fix NVC for RCTModalHostView Summary: ## iOS Failure ``` LOG SVC RCTModalHostView Invalid LOG { "missing": {}, "unexpected": { "validAttributes": { "statusBarTranslucent": true, "hardwareAccelerated": true, "animated": true } }, "unequal": {} } ``` Reviewed By: sshic Differential Revision: D33409398 fbshipit-source-id: 4651878207d0dca1a559fef2191f7538217c093a --- React/Views/RCTModalHostView.h | 5 +++++ React/Views/RCTModalHostViewManager.m | 3 +++ 2 files changed, 8 insertions(+) diff --git a/React/Views/RCTModalHostView.h b/React/Views/RCTModalHostView.h index 4f6ad90bf7..0246328f99 100644 --- a/React/Views/RCTModalHostView.h +++ b/React/Views/RCTModalHostView.h @@ -25,6 +25,11 @@ @property (nonatomic, copy) RCTDirectEventBlock onShow; @property (nonatomic, assign) BOOL visible; +// Android only +@property (nonatomic, assign) BOOL statusBarTranslucent; +@property (nonatomic, assign) BOOL hardwareAccelerated; +@property (nonatomic, assign) BOOL animated; + @property (nonatomic, copy) NSNumber *identifier; @property (nonatomic, weak) id delegate; diff --git a/React/Views/RCTModalHostViewManager.m b/React/Views/RCTModalHostViewManager.m index 534833be52..7fab70ef63 100644 --- a/React/Views/RCTModalHostViewManager.m +++ b/React/Views/RCTModalHostViewManager.m @@ -116,6 +116,9 @@ RCT_EXPORT_MODULE() RCT_EXPORT_VIEW_PROPERTY(animationType, NSString) RCT_EXPORT_VIEW_PROPERTY(presentationStyle, UIModalPresentationStyle) RCT_EXPORT_VIEW_PROPERTY(transparent, BOOL) +RCT_EXPORT_VIEW_PROPERTY(statusBarTranslucent, BOOL) +RCT_EXPORT_VIEW_PROPERTY(hardwareAccelerated, BOOL) +RCT_EXPORT_VIEW_PROPERTY(animated, BOOL) RCT_EXPORT_VIEW_PROPERTY(onShow, RCTDirectEventBlock) RCT_EXPORT_VIEW_PROPERTY(identifier, NSNumber) RCT_EXPORT_VIEW_PROPERTY(supportedOrientations, NSArray)