Fix unmangled visibility in rn_defs

Summary: The wrappers exposed by `rn_defs.bzl` should mangle visibility to include the cell.

Reviewed By: scottrice

Differential Revision: D13219109

fbshipit-source-id: ded17e79a1d388d6b76fbdf2ab0d75e586092fcd
This commit is contained in:
Adam Ernst 2018-11-27 13:43:56 -08:00 коммит произвёл Facebook Github Bot
Родитель 706888df35
Коммит 7030d95988
10 изменённых файлов: 26 добавлений и 16 удалений

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_android_prebuilt_aar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "appcompat", name = "appcompat",
aar = ":appcompat-binary-aar", aar = ":appcompat-binary-aar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
@ -12,7 +13,7 @@ fb_native.remote_file(
url = "mvn:com.android.support:appcompat-v7:aar:27.1.1", url = "mvn:com.android.support:appcompat-v7:aar:27.1.1",
) )
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "android-jsc", name = "android-jsc",
aar = ":android-jsc-aar", aar = ":android-jsc-aar",
) )

Просмотреть файл

@ -13,7 +13,7 @@ fb_native.remote_file(
url = "mvn:com.facebook.fresco:fresco:aar:1.10.0", url = "mvn:com.facebook.fresco:fresco:aar:1.10.0",
) )
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "fresco-drawee", name = "fresco-drawee",
aar = ":drawee-binary-aar", aar = ":drawee-binary-aar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
@ -71,7 +71,7 @@ fb_native.remote_file(
url = "mvn:com.parse.bolts:bolts-tasks:jar:1.4.0", url = "mvn:com.parse.bolts:bolts-tasks:jar:1.4.0",
) )
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "fbcore", name = "fbcore",
aar = ":fbcore-aar", aar = ":fbcore-aar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
@ -83,7 +83,7 @@ fb_native.remote_file(
url = "mvn:com.facebook.fresco:fbcore:aar:1.10.0", url = "mvn:com.facebook.fresco:fbcore:aar:1.10.0",
) )
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "imagepipeline-okhttp3", name = "imagepipeline-okhttp3",
aar = ":imagepipeline-okhttp3-binary-aar", aar = ":imagepipeline-okhttp3-binary-aar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "android-support-annotations", name = "android-support-annotations",
binary_jar = ":support-annotations-binary.jar", binary_jar = ":support-annotations-binary.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,4 +1,4 @@
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library", "rn_android_resource", "rn_prebuilt_jar") load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_android_library", "rn_android_resource", "rn_genrule", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
# This is a bit messy and hopefully a temporary thing # This is a bit messy and hopefully a temporary thing
@ -38,13 +38,13 @@ rn_prebuilt_jar(
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
) )
fb_native.genrule( rn_genrule(
name = "classes-unpacker-cmd", name = "classes-unpacker-cmd",
out = "classes.jar", out = "classes.jar",
cmd = "$(exe :aar-unpacker) $(location :appcompat-binary-aar) classes.jar $OUT", cmd = "$(exe :aar-unpacker) $(location :appcompat-binary-aar) classes.jar $OUT",
) )
fb_native.genrule( rn_genrule(
name = "res-unpacker-cmd", name = "res-unpacker-cmd",
out = "res", out = "res",
cmd = "$(exe :aar-unpacker) $(location :appcompat-binary-aar) res/ $OUT", cmd = "$(exe :aar-unpacker) $(location :appcompat-binary-aar) res/ $OUT",

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "infer-annotations", name = "infer-annotations",
binary_jar = ":infer-annotations.jar", binary_jar = ":infer-annotations.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "javapoet", name = "javapoet",
binary_jar = ":jsr305-binary.jar", binary_jar = ":jsr305-binary.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "okhttp3", name = "okhttp3",
binary_jar = ":okhttp3-binary.jar", binary_jar = ":okhttp3-binary.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
@ -12,7 +13,7 @@ fb_native.remote_file(
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.11.0", url = "mvn:com.squareup.okhttp3:okhttp:jar:3.11.0",
) )
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "okhttp3-urlconnection", name = "okhttp3-urlconnection",
binary_jar = ":okhttp3-urlconnection-binary.jar", binary_jar = ":okhttp3-urlconnection-binary.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_prebuilt_jar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.prebuilt_jar( rn_prebuilt_jar(
name = "okio", name = "okio",
binary_jar = ":okio-binary.jar", binary_jar = ":okio-binary.jar",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -1,6 +1,7 @@
load("//tools/build_defs/oss:rn_defs.bzl", "rn_android_prebuilt_aar")
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "runner", name = "runner",
aar = ":testing-support-lib-runner-download", aar = ":testing-support-lib-runner-download",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],
@ -12,7 +13,7 @@ fb_native.remote_file(
url = "mvn:com.android.support.test:runner:aar:0.3", url = "mvn:com.android.support.test:runner:aar:0.3",
) )
fb_native.android_prebuilt_aar( rn_android_prebuilt_aar(
name = "exposed-instrumentation-api", name = "exposed-instrumentation-api",
aar = ":testing-support-instrumentation", aar = ":testing-support-instrumentation",
visibility = ["//ReactAndroid/..."], visibility = ["//ReactAndroid/..."],

Просмотреть файл

@ -145,6 +145,9 @@ def rn_prebuilt_native_library(*args, **kwargs):
def rn_prebuilt_jar(*args, **kwargs): def rn_prebuilt_jar(*args, **kwargs):
native.prebuilt_jar(*args, **kwargs) native.prebuilt_jar(*args, **kwargs)
def rn_genrule(*args, **kwargs):
native.genrule(*args, **kwargs)
def rn_robolectric_test(name, srcs, vm_args = None, *args, **kwargs): def rn_robolectric_test(name, srcs, vm_args = None, *args, **kwargs):
vm_args = vm_args or [] vm_args = vm_args or []