Fabric Tests: Change default constructor in TestComponents' TestProps (#29898)
Summary: This pull request changes the default constructor in the `TestProps` class in `react/renderer/core/tests/TestComponent.h` `using ViewProps::ViewProps;` was causing problems in Visual Studio 2017 - changing it to ` TestProps() = default;` allowed dependent CPP files to compile on MSVC and caused no regressions in the Fabric test suite. ## Changelog Changelog: [Internal] [Changed] - Fabric Tests: Change default constructor in TestComponents' TestProps Pull Request resolved: https://github.com/facebook/react-native/pull/29898 Test Plan: The Fabric test suite passes on Windows after this change is made. I also tested it under macOS and Linux built with Clang and they both pass with this change made. Reviewed By: sammy-SC Differential Revision: D23591986 Pulled By: shergin fbshipit-source-id: 132e1c2e38fa74aa4f2c8746054d6152f30035e9
This commit is contained in:
Родитель
d6fef50bd9
Коммит
777bf6529a
|
@ -33,7 +33,7 @@ static const char TestComponentName[] = "Test";
|
|||
|
||||
class TestProps : public ViewProps {
|
||||
public:
|
||||
using ViewProps::ViewProps;
|
||||
TestProps() = default;
|
||||
|
||||
TestProps(const TestProps &sourceProps, const RawProps &rawProps)
|
||||
: ViewProps(sourceProps, rawProps) {}
|
||||
|
|
Загрузка…
Ссылка в новой задаче