From 7b86e3aaef11378b8209f61b4bc32d0058e540c7 Mon Sep 17 00:00:00 2001
From: Dmitry Rykun <dmitryrykun@meta.com>
Date: Tue, 21 Mar 2023 11:06:24 -0700
Subject: [PATCH] Remove unused js_coverage job from CircleCI (#36513)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36513

We don't use JS test coverage badge on GitHub. Collecting this information is performed by `coveralls` package that is unmaintained for at least 2 years. Also it depends on `request` package that has security vulnerabilities, and became deprecated in 2020.

Changelog: [Internal]

Reviewed By: cortinico, cipolleschi

Differential Revision: D44168060

fbshipit-source-id: f76ae28f42b65e320a71dc227b2d07274a96f24e
---
 .circleci/config.yml | 28 ----------------------------
 package.json         |  1 -
 yarn.lock            | 23 +----------------------
 3 files changed, 1 insertion(+), 51 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 34bb15d9ac..6955dc527a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1142,31 +1142,6 @@ jobs:
                 name: Android Build
                 command: ./gradlew.bat packages:rn-tester:android:app:assembleRelease
 
-  # -------------------------
-  #      JOBS: Coverage
-  # -------------------------
-  # Collect JavaScript test coverage
-  js_coverage:
-    executor: nodelts
-    environment:
-      - CI_BRANCH: $CIRCLE_BRANCH
-      - CI_PULL_REQUEST: $CIRCLE_PULL_REQUEST
-      - CI_BUILD_NUMBER: $CIRCLE_BUILD_NUM
-      - CI_BUILD_URL: $CIRCLE_BUILD_URL
-    steps:
-      - checkout
-      - setup_artifacts
-      - run_yarn
-      - run:
-          name: Collect test coverage information
-          command: |
-            scripts/circleci/exec_swallow_error.sh yarn test --coverage --maxWorkers=2
-            if [[ -e ./coverage/lcov.info ]]; then
-              cat ./coverage/lcov.info | scripts/circleci/exec_swallow_error.sh ./node_modules/.bin/coveralls
-            fi
-      - store_artifacts:
-          path: ~/react-native/coverage/
-
   # -------------------------
   #      JOBS: Build Hermes
   # -------------------------
@@ -1977,9 +1952,6 @@ workflows:
       # Run code checks on PRs
       - analyze_pr
 
-      # Gather coverage
-      - js_coverage
-
   nightly:
     when: << pipeline.parameters.run_nightly_workflow >>
     jobs:
diff --git a/package.json b/package.json
index e52ee17aea..05a0c3f4b7 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,6 @@
     "babel-plugin-transform-flow-enums":"^0.0.2",
     "clang-format": "^1.8.0",
     "connect": "^3.6.5",
-    "coveralls": "^3.1.1",
     "eslint": "^8.19.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-babel": "^5.3.1",
diff --git a/yarn.lock b/yarn.lock
index 3257aa9d84..cbbf883562 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3698,17 +3698,6 @@ cosmiconfig@^5.0.5, cosmiconfig@^5.1.0:
     js-yaml "^3.13.0"
     parse-json "^4.0.0"
 
-coveralls@^3.1.1:
-  version "3.1.1"
-  resolved "https://registry.yarnpkg.com/coveralls/-/coveralls-3.1.1.tgz#f5d4431d8b5ae69c5079c8f8ca00d64ac77cf081"
-  integrity sha512-+dxnG2NHncSD1NrqbSM3dn/lE57O6Qf/koe9+I7c+wzkqRmEvcp0kgJdxKInzYzkICKkFMZsX3Vct3++tsF9ww==
-  dependencies:
-    js-yaml "^3.13.1"
-    lcov-parse "^1.0.0"
-    log-driver "^1.2.7"
-    minimist "^1.2.5"
-    request "^2.88.2"
-
 cross-spawn@^6.0.0:
   version "6.0.5"
   resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-6.0.5.tgz#4a5ec7c64dfae22c3a14124dbacdee846d80cbc4"
@@ -6136,11 +6125,6 @@ language-tags@^1.0.5:
   dependencies:
     language-subtag-registry "~0.3.2"
 
-lcov-parse@^1.0.0:
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/lcov-parse/-/lcov-parse-1.0.0.tgz#eb0d46b54111ebc561acb4c408ef9363bdc8f7e0"
-  integrity sha1-6w1GtUER68VhrLTECO+TY73I9+A=
-
 leven@^3.1.0:
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/leven/-/leven-3.1.0.tgz#77891de834064cccba82ae7842bb6b14a13ed7f2"
@@ -6248,11 +6232,6 @@ lodash@^4.17.19, lodash@^4.17.21:
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
   integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
 
-log-driver@^1.2.7:
-  version "1.2.7"
-  resolved "https://registry.yarnpkg.com/log-driver/-/log-driver-1.2.7.tgz#63b95021f0702fedfa2c9bb0a24e7797d71871d8"
-  integrity sha512-U7KCmLdqsGHBLeWqYlFA0V0Sl6P08EE1ZrmA9cxjUE0WVqT9qnyVDPz1kzpFEP0jdJuFnasWIfSd7fsaNXkpbg==
-
 log-symbols@^4.1.0:
   version "4.1.0"
   resolved "https://registry.yarnpkg.com/log-symbols/-/log-symbols-4.1.0.tgz#3fbdbb95b4683ac9fc785111e792e558d4abd503"
@@ -6696,7 +6675,7 @@ minimatch@^3.0.2, minimatch@^3.0.4, minimatch@^3.1.1, minimatch@^3.1.2:
   dependencies:
     brace-expansion "^1.1.7"
 
-minimist@^1.2.0, minimist@^1.2.5, minimist@^1.2.6:
+minimist@^1.2.0, minimist@^1.2.6:
   version "1.2.6"
   resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
   integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==