From 7d1981ef8245cd6267823a970054cbebb2d2fd14 Mon Sep 17 00:00:00 2001 From: ArturKlajnerok Date: Wed, 21 Jun 2017 07:33:24 -0700 Subject: [PATCH] Removing test-driver symlink in ios third party install script Summary: After execution of `scripts/ios-install-third-party.sh` a symlink is created : `/node_modules/react-native/third-party/glog-0.3.4/test-driver` that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver` This can be executed indirectly by `react-native run-ios`. This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice. Once the `test-driver` symlink is created android app release is failing, for : `./gradlew assembleRelease` the `:app:bundleReleaseJsAndAssets` returns : ``` FAILURE: Build failed with an exception. * What went wrong: Could not list contents of '/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link. ``` Related issues: https://github.com/facebook/react-native/issues/14417 https://github.com/facebook/react-native/issues/14464 https://github.com/facebook/react-native/issues/14548 1. Create new project with `react-native init ` 2. cd `/` 3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed. 4. cd `android/` 5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists) IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released. The proper cleanup of files generated by autotools was already applied : https://github.com/google/glog/pull/188 Please let me know if I should provide more details : javache, mhorowitz, hramos Closes https://github.com/facebook/react-native/pull/14638 Differential Revision: D5292362 Pulled By: javache fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e --- scripts/ios-configure-glog.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/ios-configure-glog.sh b/scripts/ios-configure-glog.sh index 5c71d57812..e6a15febb9 100755 --- a/scripts/ios-configure-glog.sh +++ b/scripts/ios-configure-glog.sh @@ -7,6 +7,11 @@ CURRENT_ARCH="${CURRENT_ARCH:-armv7}" export CC="$(xcrun -find -sdk $PLATFORM_NAME cc) -arch $CURRENT_ARCH -isysroot $(xcrun -sdk $PLATFORM_NAME --show-sdk-path)" export CXX="$CC" +# Remove automake symlink if it exists +if [ -h "test-driver" ]; then + rm test-driver +fi + ./configure --host arm-apple-darwin # Fix build for tvOS