Remove useOverflowInset flag as we rolled out 100% to public for over three months

Summary:
This was shipped in D36990986 (df80ed40c7) but backed out last year in D37074879 (59476d06f3), as we want to wait for some performance comparison results to come out.

Remove overflow inset optimization flags as they've been rolled out 100% to public.

Changelog:
[Android][Internal] - Clean up feature flags for overflowInset

Reviewed By: javache

Differential Revision: D43070494

fbshipit-source-id: dbf5aed9b2b5d3db1ad351bc208cb2016dc62e40
This commit is contained in:
Xin Chen 2023-02-07 09:22:58 -08:00 коммит произвёл Facebook GitHub Bot
Родитель bbed15d4ae
Коммит 7e02b41630
4 изменённых файлов: 3 добавлений и 12 удалений

Просмотреть файл

@ -67,9 +67,6 @@ public class ReactFeatureFlags {
/** Enables or disables calculation of Transformed Frames */ /** Enables or disables calculation of Transformed Frames */
public static boolean calculateTransformedFramesEnabled = false; public static boolean calculateTransformedFramesEnabled = false;
/** Feature Flag to use overflowInset values provided by Yoga */
public static boolean useOverflowInset = false;
public static boolean dispatchPointerEvents = false; public static boolean dispatchPointerEvents = false;
/** Feature Flag to enable the pending event queue in fabric before mounting views */ /** Feature Flag to enable the pending event queue in fabric before mounting views */

Просмотреть файл

@ -19,7 +19,6 @@ import android.view.ViewGroup;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.UiThreadUtil; import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.touch.ReactHitSlopView; import com.facebook.react.touch.ReactHitSlopView;
import com.facebook.react.uimanager.common.ViewUtil; import com.facebook.react.uimanager.common.ViewUtil;
import java.util.ArrayList; import java.util.ArrayList;
@ -192,7 +191,6 @@ public class TouchTargetHelper {
// If the touch point is outside of the overflowinset for the view, we can safely ignore // If the touch point is outside of the overflowinset for the view, we can safely ignore
// it. // it.
if (ViewUtil.getUIManagerType(view.getId()) == FABRIC if (ViewUtil.getUIManagerType(view.getId()) == FABRIC
&& ReactFeatureFlags.useOverflowInset
&& !isTouchPointInViewWithOverflowInset(eventCoords[0], eventCoords[1], view)) { && !isTouchPointInViewWithOverflowInset(eventCoords[0], eventCoords[1], view)) {
return null; return null;
} }

Просмотреть файл

@ -40,7 +40,6 @@ FabricMountingManager::FabricMountingManager(
std::shared_ptr<const ReactNativeConfig> &config, std::shared_ptr<const ReactNativeConfig> &config,
global_ref<jobject> &javaUIManager) global_ref<jobject> &javaUIManager)
: javaUIManager_(javaUIManager), : javaUIManager_(javaUIManager),
useOverflowInset_(getFeatureFlagValue("useOverflowInset")),
reduceDeleteCreateMutation_( reduceDeleteCreateMutation_(
getFeatureFlagValue("reduceDeleteCreateMutation")) { getFeatureFlagValue("reduceDeleteCreateMutation")) {
CoreFeatures::enableMapBuffer = getFeatureFlagValue("useMapBufferProps"); CoreFeatures::enableMapBuffer = getFeatureFlagValue("useMapBufferProps");
@ -404,8 +403,7 @@ void FabricMountingManager::executeMount(
// children of the current view. The layout of current view may not // children of the current view. The layout of current view may not
// change, and we separate this part from layout mount items to not // change, and we separate this part from layout mount items to not
// pack too much data there. // pack too much data there.
if (useOverflowInset_ && if ((oldChildShadowView.layoutMetrics.overflowInset !=
(oldChildShadowView.layoutMetrics.overflowInset !=
newChildShadowView.layoutMetrics.overflowInset)) { newChildShadowView.layoutMetrics.overflowInset)) {
cppUpdateOverflowInsetMountItems.push_back( cppUpdateOverflowInsetMountItems.push_back(
CppMountItem::UpdateOverflowInsetMountItem( CppMountItem::UpdateOverflowInsetMountItem(
@ -461,9 +459,8 @@ void FabricMountingManager::executeMount(
// children of the current view. The layout of current view may not // children of the current view. The layout of current view may not
// change, and we separate this part from layout mount items to not // change, and we separate this part from layout mount items to not
// pack too much data there. // pack too much data there.
if (useOverflowInset_ && if (newChildShadowView.layoutMetrics.overflowInset !=
newChildShadowView.layoutMetrics.overflowInset != EdgeInsets::ZERO) {
EdgeInsets::ZERO) {
cppUpdateOverflowInsetMountItems.push_back( cppUpdateOverflowInsetMountItems.push_back(
CppMountItem::UpdateOverflowInsetMountItem( CppMountItem::UpdateOverflowInsetMountItem(
newChildShadowView)); newChildShadowView));

Просмотреть файл

@ -69,7 +69,6 @@ class FabricMountingManager final {
butter::map<SurfaceId, butter::set<Tag>> allocatedViewRegistry_{}; butter::map<SurfaceId, butter::set<Tag>> allocatedViewRegistry_{};
std::recursive_mutex allocatedViewsMutex_; std::recursive_mutex allocatedViewsMutex_;
bool const useOverflowInset_{false};
bool const reduceDeleteCreateMutation_{false}; bool const reduceDeleteCreateMutation_{false};
jni::local_ref<jobject> getProps( jni::local_ref<jobject> getProps(