Delete @synthesize turboModuleRegistry API in RCTTurboModule

Summary:
All NativeModules/TurboModules can use the following Venice-compatible API instead:
```
synthesize moduleRegistry = _moduleRegistry
```

In bridge mode, it'll look up the module via the TurboModule system/bridge.
In bridgeless mode, it'll look up the module via the TurboModule system.

Therefore, there's no need to support this API.

Changelog: [iOS][Removed] - Delete synthesize turboModuleRegistry API in RCTTurboModule

Reviewed By: fkgozali

Differential Revision: D28070740

fbshipit-source-id: d2c8285fd4c05b67fb03ce82217bf6ddfd1dd685

React/CoreModules/RCTDevSplitBundleLoader.mm

@@ -28,7 +28,7 @@ using namespace facebook::react;
 
 @synthesize bridge = _bridge;
 @synthesize loadScript = _loadScript;
-@synthesize turboModuleRegistry = _turboModuleRegistry;
+@synthesize moduleRegistry = _moduleRegistry;
 
 RCT_EXPORT_MODULE()
 
@@ -69,7 +69,7 @@ RCT_EXPORT_METHOD(loadBundle
           }
           __typeof(self) strongSelf = weakSelf;
           strongSelf->_loadScript(source);
-          RCTDevSettings *devSettings = [strongSelf->_turboModuleRegistry moduleForName:"RCTDevSettings"];
+          RCTDevSettings *devSettings = [strongSelf->_moduleRegistry moduleForName:"RCTDevSettings"];
           [devSettings setupHMRClientWithAdditionalBundleURL:source.url];
           resolve(@YES);
         }];

React/CoreModules/RCTDeviceInfo.mm

@@ -28,7 +28,6 @@ using namespace facebook::react;
 }
 
 @synthesize moduleRegistry = _moduleRegistry;
-@synthesize turboModuleRegistry = _turboModuleRegistry;
 
 RCT_EXPORT_MODULE()
 

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.h

@@ -101,20 +101,8 @@ class JSI_EXPORT ObjCTurboModule : public TurboModule {
 } // namespace facebook
 
 @protocol RCTTurboModule <NSObject>
-@optional
-/**
- * Used by TurboModules to get access to other TurboModules.
- *
- * Usage:
- * Place `@synthesize turboModuleRegistry = _turboModuleRegistry`
- * in the @implementation section of your TurboModule.
- */
-@property (nonatomic, weak) id<RCTTurboModuleRegistry> turboModuleRegistry;
-
-@required
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
     (const facebook::react::ObjCTurboModule::InitParams &)params;
-
 @end
 
 /**

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModuleManager.mm

@@ -508,10 +508,6 @@ static Class getFallbackClassFromName(const char *name)
 
   TurboModulePerfLogger::moduleCreateSetUpStart(moduleName, moduleId);
 
-  if ([module respondsToSelector:@selector(setTurboModuleRegistry:)]) {
-    [module setTurboModuleRegistry:self];
-  }
-
   /**
    * It is reasonable for NativeModules to not want/need the bridge.
    * In such cases, they won't have `@synthesize bridge = _bridge` in their

ReactCommon/react/nativemodule/samples/platform/ios/RCTSampleTurboModule.mm

@@ -17,8 +17,6 @@ using namespace facebook::react;
 // Backward-compatible export
 RCT_EXPORT_MODULE()
 
-@synthesize turboModuleRegistry = _turboModuleRegistry;
-
 // Backward-compatible queue configuration
 + (BOOL)requiresMainQueueSetup
 {