fix(scripts): remove leftover code for tmpPublishingFolder (#35528)
Summary:
When this was done ad43deca23
(most likely because the scripts folder is not type-checked) some references to this script were left lying around.
This PR takes care of it.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal] [Fixed] - remove leftover code for tmpPublishingFolder
Pull Request resolved: https://github.com/facebook/react-native/pull/35528
Test Plan: Running `yarn test-e2e-local` doesn't insta-fail.
Reviewed By: cortinico
Differential Revision: D41656151
Pulled By: GijsWeterings
fbshipit-source-id: 5fcf7fabce30076f90d92087a4f1e429903dfc0b
This commit is contained in:
Родитель
59ee573527
Коммит
7e17d26060
|
@ -43,15 +43,11 @@ const {
|
|||
publishAndroidArtifactsToMaven,
|
||||
} = require('./release-utils');
|
||||
const fs = require('fs');
|
||||
const os = require('os');
|
||||
const path = require('path');
|
||||
const yargs = require('yargs');
|
||||
|
||||
const buildTag = process.env.CIRCLE_TAG;
|
||||
const otp = process.env.NPM_CONFIG_OTP;
|
||||
const tmpPublishingFolder = fs.mkdtempSync(
|
||||
path.join(os.tmpdir(), 'rn-publish-'),
|
||||
);
|
||||
|
||||
const argv = yargs
|
||||
.option('n', {
|
||||
|
@ -81,10 +77,6 @@ const buildType = releaseBuild
|
|||
? 'nightly'
|
||||
: 'dry-run';
|
||||
|
||||
if (!argv.help) {
|
||||
echo(`The temp publishing folder is ${tmpPublishingFolder}`);
|
||||
}
|
||||
|
||||
// 34c034298dc9cad5a4553964a5a324450fda0385
|
||||
const currentCommit = getCurrentCommit();
|
||||
const shortCommit = currentCommit.slice(0, 9);
|
||||
|
@ -138,7 +130,7 @@ if (isCommitly) {
|
|||
}
|
||||
}
|
||||
|
||||
generateAndroidArtifacts(releaseVersion, tmpPublishingFolder);
|
||||
generateAndroidArtifacts(releaseVersion);
|
||||
|
||||
// Write version number to the build folder
|
||||
const releaseVersionFile = path.join('build', '.version');
|
||||
|
|
|
@ -12,7 +12,7 @@
|
|||
const {exec, echo, exit, test, env, pushd, popd} = require('shelljs');
|
||||
const {createHermesPrebuiltArtifactsTarball} = require('./hermes/hermes-utils');
|
||||
|
||||
function generateAndroidArtifacts(releaseVersion, tmpPublishingFolder) {
|
||||
function generateAndroidArtifacts(releaseVersion) {
|
||||
// -------- Generating Android Artifacts
|
||||
echo('Generating Android artifacts inside /tmp/maven-local');
|
||||
if (exec('./gradlew publishAllToMavenTempLocal').code) {
|
||||
|
|
|
@ -19,8 +19,6 @@
|
|||
const {exec, exit, pushd, popd, pwd, cd, cp} = require('shelljs');
|
||||
const yargs = require('yargs');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
const os = require('os');
|
||||
const {getBranchName} = require('./scm-utils');
|
||||
|
||||
const {
|
||||
|
@ -31,7 +29,6 @@ const {
|
|||
|
||||
const {
|
||||
generateAndroidArtifacts,
|
||||
saveFilesToRestore,
|
||||
generateiOSArtifacts,
|
||||
} = require('./release-utils');
|
||||
|
||||
|
@ -146,12 +143,6 @@ if (argv.target === 'RNTester') {
|
|||
// create the local npm package to feed the CLI
|
||||
|
||||
// base setup required (specular to publish-npm.js)
|
||||
const tmpPublishingFolder = fs.mkdtempSync(
|
||||
path.join(os.tmpdir(), 'rn-publish-'),
|
||||
);
|
||||
console.info(`The temp publishing folder is ${tmpPublishingFolder}`);
|
||||
|
||||
saveFilesToRestore(tmpPublishingFolder);
|
||||
|
||||
// we need to add the unique timestamp to avoid npm/yarn to use some local caches
|
||||
const baseVersion = require('../package.json').version;
|
||||
|
@ -176,7 +167,7 @@ if (argv.target === 'RNTester') {
|
|||
).code;
|
||||
|
||||
// Generate native files for Android
|
||||
generateAndroidArtifacts(releaseVersion, tmpPublishingFolder);
|
||||
generateAndroidArtifacts(releaseVersion);
|
||||
|
||||
// Setting up generating native iOS (will be done later)
|
||||
const repoRoot = pwd();
|
||||
|
@ -249,9 +240,6 @@ if (argv.target === 'RNTester') {
|
|||
exec('yarn android');
|
||||
}
|
||||
popd();
|
||||
|
||||
// just cleaning up the temp folder, the rest is done by the test clean script
|
||||
exec(`rm -rf ${tmpPublishingFolder}`);
|
||||
}
|
||||
|
||||
exit(0);
|
||||
|
|
Загрузка…
Ссылка в новой задаче