Circle CI: Replace string parameters with enums where applicable (#34962)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/34962 For jobs that take a string parameter, where that string parameter is expected to be one of a set of accepted values, use an enum instead. If an unexpected value is passed to a enum parameter, then `circleci config validate` will flag the issue. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D40310118 fbshipit-source-id: b8416c415705ff6eba80cc5f0d9bfe670569f732
This commit is contained in:
Родитель
3d64d0916d
Коммит
7f1729a94f
|
@ -744,14 +744,18 @@ jobs:
|
||||||
executor: reactnativeandroid
|
executor: reactnativeandroid
|
||||||
parameters:
|
parameters:
|
||||||
flavor:
|
flavor:
|
||||||
type: string
|
|
||||||
default: "Debug"
|
default: "Debug"
|
||||||
|
description: The Android build type. Must be one of "Debug", "Release".
|
||||||
|
type: enum
|
||||||
|
enum: ["Debug", "Release"]
|
||||||
newarchitecture:
|
newarchitecture:
|
||||||
type: boolean
|
type: boolean
|
||||||
default: false
|
default: false
|
||||||
jsengine:
|
jsengine:
|
||||||
type: string
|
|
||||||
default: "Hermes"
|
default: "Hermes"
|
||||||
|
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
|
||||||
|
type: enum
|
||||||
|
enum: ["Hermes", "JSC"]
|
||||||
environment:
|
environment:
|
||||||
- PROJECT_NAME: "AndroidTemplateProject"
|
- PROJECT_NAME: "AndroidTemplateProject"
|
||||||
steps:
|
steps:
|
||||||
|
@ -790,17 +794,25 @@ jobs:
|
||||||
executor: reactnativeios
|
executor: reactnativeios
|
||||||
parameters:
|
parameters:
|
||||||
flavor:
|
flavor:
|
||||||
type: string
|
|
||||||
default: "Debug"
|
default: "Debug"
|
||||||
|
description: The Xcode build type. Must be one of "Debug", "Release".
|
||||||
|
type: enum
|
||||||
|
enum: ["Debug", "Release"]
|
||||||
architecture:
|
architecture:
|
||||||
type: string
|
|
||||||
default: "OldArch"
|
default: "OldArch"
|
||||||
|
description: Which React Native architecture to use. Must be one of "NewArch", "OldArch".
|
||||||
|
type: enum
|
||||||
|
enum: ["NewArch", "OldArch"]
|
||||||
jsengine:
|
jsengine:
|
||||||
type: string
|
|
||||||
default: "Hermes"
|
default: "Hermes"
|
||||||
|
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
|
||||||
|
type: enum
|
||||||
|
enum: ["Hermes", "JSC"]
|
||||||
flipper:
|
flipper:
|
||||||
type: string
|
|
||||||
default: "WithFlipper"
|
default: "WithFlipper"
|
||||||
|
description: Whether Flipper is enabled. Must be one of "WithFlipper", "WithoutFlipper".
|
||||||
|
type: enum
|
||||||
|
enum: ["WithFlipper", "WithoutFlipper"]
|
||||||
environment:
|
environment:
|
||||||
- PROJECT_NAME: "iOSTemplateProject"
|
- PROJECT_NAME: "iOSTemplateProject"
|
||||||
- HERMES_WS_DIR: *hermes_workspace_root
|
- HERMES_WS_DIR: *hermes_workspace_root
|
||||||
|
@ -878,14 +890,16 @@ jobs:
|
||||||
test_ios_rntester:
|
test_ios_rntester:
|
||||||
executor: reactnativeios
|
executor: reactnativeios
|
||||||
parameters:
|
parameters:
|
||||||
architecture:
|
|
||||||
type: string
|
|
||||||
default: "OldArch"
|
|
||||||
jsengine:
|
jsengine:
|
||||||
default: "Hermes"
|
default: "Hermes"
|
||||||
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
|
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
|
||||||
type: enum
|
type: enum
|
||||||
enum: ["Hermes", "JSC"]
|
enum: ["Hermes", "JSC"]
|
||||||
|
architecture:
|
||||||
|
default: "OldArch"
|
||||||
|
description: Which React Native architecture to use. Must be one of "OldArch", "NewArch".
|
||||||
|
type: enum
|
||||||
|
enum: ["NewArch", "OldArch"]
|
||||||
steps:
|
steps:
|
||||||
- checkout_code_with_cache
|
- checkout_code_with_cache
|
||||||
- run_yarn
|
- run_yarn
|
||||||
|
|
Загрузка…
Ссылка в новой задаче