Rename ios project name with new template (#24292)

Summary:
With new `init` implementation we replace all occurrences of the project name (`HelloWorld`) inside `ios` and `android` directories. For some reason, a product name field in `ios` was named wrongly. This shouldn't impact initialization using `global-cli`

[iOS] [Fixed] - Change productName in iOS in new init.
Pull Request resolved: https://github.com/facebook/react-native/pull/24292

Differential Revision: D14749249

Pulled By: cpojer

fbshipit-source-id: aaf4294ab23180770aac3075789d3ffb4d5a4f3f

package.json

@@ -52,7 +52,10 @@
     "third-party-podspecs",
     "template",
     "local-cli",
-    "template.config.js"
+    "template.config.js",
+    "!template/node_modules",
+    "!template/yarn.lock",
+    "!template/package-lock.json"
   ],
   "scripts": {
     "start": "react-native start --reactNativePath .",

template/ios/HelloWorld.xcodeproj/project.pbxproj

@@ -193,7 +193,7 @@
 			dependencies = (
 			);
 			name = HelloWorld;
-			productName = "Hello World";
+			productName = "HelloWorld";
 			productReference = 13B07F961A680F5B00A75B9A /* HelloWorld.app */;
 			productType = "com.apple.product-type.application";
 		};