From 8b931ae09f96e16f04e866c8a03d4dba5b7a2f67 Mon Sep 17 00:00:00 2001 From: yicheng Date: Sun, 27 Nov 2016 02:56:57 -0800 Subject: [PATCH] Update meta.js (new Buffer when init) Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Warning about new Buffer when init Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#s Closes https://github.com/facebook/react-native/pull/11153 Differential Revision: D4234591 fbshipit-source-id: a9373f3151de8a50c18342f45fb9684a5c7416a6 --- local-cli/bundle/output/meta.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-cli/bundle/output/meta.js b/local-cli/bundle/output/meta.js index 571e4bf140..2bfc3a6709 100644 --- a/local-cli/bundle/output/meta.js +++ b/local-cli/bundle/output/meta.js @@ -23,7 +23,7 @@ module.exports = function(code, encoding) { const hash = crypto.createHash('sha1'); hash.update(code, encoding); const digest = hash.digest('binary'); - const signature = Buffer(digest.length + 1); + const signature = Buffer.alloc ? Buffer.alloc(digest.length + 1) : new Buffer(digest.length + 1); // remove the new Buffer call when RN drops support for Node 4 signature.write(digest, 'binary'); signature.writeUInt8( constantFor(tryAsciiPromotion(code, encoding)),