Add todo notes for nativeID hack

Summary: Changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D23003735

fbshipit-source-id: 7814de9e1d280604842e47a969ab3e8d453c50a8
This commit is contained in:
Samuel Susla 2020-08-10 15:35:09 -07:00 коммит произвёл Facebook GitHub Bot
Родитель 8724a24bf5
Коммит 8fc8cd9aea
3 изменённых файлов: 5 добавлений и 3 удалений

Просмотреть файл

@ -223,7 +223,9 @@ function createAnimatedComponent<Props: {+[string]: mixed, ...}, Instance>(
{...passthruProps} {...passthruProps}
style={mergedStyle} style={mergedStyle}
ref={this._setComponentRef} ref={this._setComponentRef}
nativeID={this._isFabric() ? 'animatedComponent' : undefined} nativeID={
this._isFabric() ? 'animatedComponent' : undefined
} /* TODO: T68258846. */
// The native driver updates views directly through the UI thread so we // The native driver updates views directly through the UI thread so we
// have to make sure the view doesn't get optimized away because it cannot // have to make sure the view doesn't get optimized away because it cannot
// go through the NativeViewHierarchyManager since it operates on the shadow // go through the NativeViewHierarchyManager since it operates on the shadow

Просмотреть файл

@ -1078,7 +1078,7 @@ class ScrollView extends React.Component<Props, State> {
return ( return (
<StickyHeaderComponent <StickyHeaderComponent
key={key} key={key}
nativeID={'StickyHeader-' + key} nativeID={'StickyHeader-' + key} /* TODO: T68258846. */
ref={ref => this._setStickyHeaderRef(key, ref)} ref={ref => this._setStickyHeaderRef(key, ref)}
nextHeaderLayoutY={this._headerLayoutYs.get( nextHeaderLayoutY={this._headerLayoutYs.get(
this._getKeyForIndex(nextIndex, childArray), this._getKeyForIndex(nextIndex, childArray),

Просмотреть файл

@ -56,7 +56,7 @@ class InspectorOverlay extends React.Component<Props> {
<View <View
onStartShouldSetResponder={this.shouldSetResponser} onStartShouldSetResponder={this.shouldSetResponser}
onResponderMove={this.findViewForTouchEvent} onResponderMove={this.findViewForTouchEvent}
nativeID="inspectorOverlay" nativeID="inspectorOverlay" /* TODO: T68258846. */
style={[styles.inspector, {height: Dimensions.get('window').height}]}> style={[styles.inspector, {height: Dimensions.get('window').height}]}>
{content} {content}
</View> </View>