Summary:
Media picking wasn't working for Venice because we didn't implement onActivityResult in BridgelessReactFragment so the listener in FBProfileGemstoneReactModule didn't called.

Changelog:
[Android][Changed] - Added Nullable annotation

Reviewed By: mdvacca

Differential Revision: D27045861

fbshipit-source-id: 0ab2961ef0570d92259856b4132507ebb264eb9d
This commit is contained in:
Lulu Wu 2021-03-15 14:29:21 -07:00 коммит произвёл Facebook GitHub Bot
Родитель 7ac5d48341
Коммит 903351f22e
3 изменённых файлов: 7 добавлений и 3 удалений

Просмотреть файл

@ -9,6 +9,7 @@ package com.facebook.react.bridge;
import android.app.Activity;
import android.content.Intent;
import javax.annotation.Nullable;
/**
* Listener for receiving activity events. Consider using {@link BaseActivityEventListener} if
@ -17,7 +18,7 @@ import android.content.Intent;
public interface ActivityEventListener {
/** Called when host (activity/service) receives an {@link Activity#onActivityResult} call. */
void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data);
void onActivityResult(Activity activity, int requestCode, int resultCode, @Nullable Intent data);
/** Called when a new intent is passed to the activity */
void onNewIntent(Intent intent);

Просмотреть файл

@ -9,6 +9,7 @@ package com.facebook.react.bridge;
import android.app.Activity;
import android.content.Intent;
import javax.annotation.Nullable;
/** An empty implementation of {@link ActivityEventListener} */
public class BaseActivityEventListener implements ActivityEventListener {
@ -18,7 +19,8 @@ public class BaseActivityEventListener implements ActivityEventListener {
public void onActivityResult(int requestCode, int resultCode, Intent data) {}
@Override
public void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data) {}
public void onActivityResult(
Activity activity, int requestCode, int resultCode, @Nullable Intent data) {}
@Override
public void onNewIntent(Intent intent) {}

Просмотреть файл

@ -305,7 +305,8 @@ public class ReactContext extends ContextWrapper {
}
/** Should be called by the hosting Fragment in {@link Fragment#onActivityResult} */
public void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data) {
public void onActivityResult(
Activity activity, int requestCode, int resultCode, @Nullable Intent data) {
for (ActivityEventListener listener : mActivityEventListeners) {
try {
listener.onActivityResult(activity, requestCode, resultCode, data);