From 97cfacb5bab85fb32db2b9fd904cc9290ff562c1 Mon Sep 17 00:00:00 2001 From: Zakaria Ridouh Date: Mon, 13 Jun 2016 07:35:57 -0700 Subject: [PATCH] move templates to .github folder MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: This moves the Template files to the .github folder. This helps clear up the extra files in the root of the directory. This is my first PR 😄 and I plan to contribute more to this awesome project. Closes https://github.com/facebook/react-native/pull/7854 Differential Revision: D3424679 fbshipit-source-id: 2baca0bb4182eb6d803836e10a5434d980e7d0c3 --- ISSUE_TEMPLATE.md => .github/ISSUE_TEMPLATE.md | 0 PULL_REQUEST_TEMPLATE.md => .github/PULL_REQUEST_TEMPLATE.md | 0 bots/IssueCommands.txt | 2 +- docs/PullRequestGuidelines.md | 4 ++-- 4 files changed, 3 insertions(+), 3 deletions(-) rename ISSUE_TEMPLATE.md => .github/ISSUE_TEMPLATE.md (100%) rename PULL_REQUEST_TEMPLATE.md => .github/PULL_REQUEST_TEMPLATE.md (100%) diff --git a/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md similarity index 100% rename from ISSUE_TEMPLATE.md rename to .github/ISSUE_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE.md diff --git a/bots/IssueCommands.txt b/bots/IssueCommands.txt index 5d614fcb0e..779bdb599e 100644 --- a/bots/IssueCommands.txt +++ b/bots/IssueCommands.txt @@ -36,7 +36,7 @@ comment Okay, reopening this issue. reopen @facebook-github-bot feature -comment Hey {issue_author}! Thanks for opening the issue, however it looks like a feature request. As noted in the [Issue template](https://github.com/facebook/react-native/blob/master/ISSUE_TEMPLATE.md) we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on [Product Pains](https://productpains.com/product/react-native). It has a voting system and if the feature gets upvoted enough it might get implemented. Closing this now, thanks for understanding! +comment Hey {issue_author}! Thanks for opening the issue, however it looks like a feature request. As noted in the [Issue template](https://github.com/facebook/react-native/blob/master/.github/ISSUE_TEMPLATE.md) we'd like to use the GitHub issues to track bugs only. Can you implement the feature as a standalone npm module? If not consider sending a pull request or a create an entry on [Product Pains](https://productpains.com/product/react-native). It has a voting system and if the feature gets upvoted enough it might get implemented. Closing this now, thanks for understanding! close @facebook-github-bot cla diff --git a/docs/PullRequestGuidelines.md b/docs/PullRequestGuidelines.md index ee9a169523..89286c48a7 100644 --- a/docs/PullRequestGuidelines.md +++ b/docs/PullRequestGuidelines.md @@ -1,9 +1,9 @@ ## Tips on reviewing pull requests -Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Example: [#6395](https://github.com/facebook/react-native/pull/6395). Add labels 'Needs revision' and 'Needs response from author'. Add a response like: +Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/.github/PULL_REQUEST_TEMPLATE.md)? Example: [#6395](https://github.com/facebook/react-native/pull/6395). Add labels 'Needs revision' and 'Needs response from author'. Add a response like: > Hey @author, thanks for sending the pull request. -> Can you please add all the info specified in the [template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? This is necessary for people to be able to understand and review your pull request. +> Can you please add all the info specified in the [template](https://github.com/facebook/react-native/blob/master/.github/PULL_REQUEST_TEMPLATE.md)? This is necessary for people to be able to understand and review your pull request. Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency (formatting, naming) with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.