Always enable debugger by default

Summary:
We currently enable the debugger by default on all platforms except
Android. On Android, we then manually enable the debugger in debug
builds. Instead, change it so the debugger is manually disabled in
release builds, to simplify the setup.

Changelog: [Internal]

Reviewed By: jpporto

Differential Revision: D35347444

fbshipit-source-id: a97bba0c65c61c211cf9e361e7091343a2c6416f
This commit is contained in:
Neil Dhar 2022-04-04 15:47:29 -07:00 коммит произвёл Facebook GitHub Bot
Родитель 68fd7de115
Коммит aefb17421b
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -140,7 +140,6 @@ android {
debug {
externalNativeBuild {
cmake {
arguments "-DHERMES_ENABLE_DEBUGGER=True"
// JS developers aren't VM developers.
// Therefore we're passing as build type Release, to provide a faster build.
// This has the (unlucky) side effect of letting AGP call the build
@ -152,6 +151,7 @@ android {
release {
externalNativeBuild {
cmake {
arguments "-DHERMES_ENABLE_DEBUGGER=False"
arguments "-DCMAKE_BUILD_TYPE=MinSizeRel"
}
}