NIT: rename FabricUIManager.scheduleMountItems -> FabricUIManager.scheduleMountItem
Summary: The method FabricUIManager.scheduleMountItems receives only one MountItem, is makes more sense to be called FabricUIManager.scheduleMountItem Reviewed By: JoshuaGross, makovkastar Differential Revision: D16062749 fbshipit-source-id: a27063be33b644af83ede6a9198edbfb1c3296e1
This commit is contained in:
Родитель
a679f592cd
Коммит
b1b6501ac9
|
@ -328,7 +328,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
|
||||||
public void synchronouslyUpdateViewOnUIThread(int reactTag, ReadableMap props) {
|
public void synchronouslyUpdateViewOnUIThread(int reactTag, ReadableMap props) {
|
||||||
long time = SystemClock.uptimeMillis();
|
long time = SystemClock.uptimeMillis();
|
||||||
try {
|
try {
|
||||||
scheduleMountItems(updatePropsMountItem(reactTag, props), time, 0, time, time);
|
scheduleMountItem(updatePropsMountItem(reactTag, props), time, 0, time, time);
|
||||||
} catch (Exception ex) {
|
} catch (Exception ex) {
|
||||||
// ignore exceptions for now
|
// ignore exceptions for now
|
||||||
// TODO T42943890: Fix animations in Fabric and remove this try/catch
|
// TODO T42943890: Fix animations in Fabric and remove this try/catch
|
||||||
|
@ -341,8 +341,8 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
|
||||||
*/
|
*/
|
||||||
@DoNotStrip
|
@DoNotStrip
|
||||||
@SuppressWarnings("unused")
|
@SuppressWarnings("unused")
|
||||||
private void scheduleMountItems(
|
private void scheduleMountItem(
|
||||||
final MountItem mountItems,
|
final MountItem mountItem,
|
||||||
long commitStartTime,
|
long commitStartTime,
|
||||||
long layoutTime,
|
long layoutTime,
|
||||||
long finishTransactionStartTime,
|
long finishTransactionStartTime,
|
||||||
|
@ -355,7 +355,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
|
||||||
mFinishTransactionTime = SystemClock.uptimeMillis() - finishTransactionStartTime;
|
mFinishTransactionTime = SystemClock.uptimeMillis() - finishTransactionStartTime;
|
||||||
mDispatchViewUpdatesTime = SystemClock.uptimeMillis();
|
mDispatchViewUpdatesTime = SystemClock.uptimeMillis();
|
||||||
synchronized (mMountItemsLock) {
|
synchronized (mMountItemsLock) {
|
||||||
mMountItems.add(mountItems);
|
mMountItems.add(mountItem);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (UiThreadUtil.isOnUiThread()) {
|
if (UiThreadUtil.isOnUiThread()) {
|
||||||
|
|
|
@ -608,7 +608,7 @@ void Binding::schedulerDidFinishTransaction(
|
||||||
static auto scheduleMountItems =
|
static auto scheduleMountItems =
|
||||||
jni::findClassStatic(UIManagerJavaDescriptor)
|
jni::findClassStatic(UIManagerJavaDescriptor)
|
||||||
->getMethod<void(JMountItem::javaobject, jlong, jlong, jlong, jlong)>(
|
->getMethod<void(JMountItem::javaobject, jlong, jlong, jlong, jlong)>(
|
||||||
"scheduleMountItems");
|
"scheduleMountItem");
|
||||||
|
|
||||||
long finishTransactionEndTime = getTime();
|
long finishTransactionEndTime = getTime();
|
||||||
|
|
||||||
|
|
|
@ -5,7 +5,6 @@ rn_android_library(
|
||||||
srcs = glob(["*.java"]),
|
srcs = glob(["*.java"]),
|
||||||
is_androidx = True,
|
is_androidx = True,
|
||||||
provided_deps = [
|
provided_deps = [
|
||||||
react_native_dep("third-party/android/androidx:annotation"),
|
|
||||||
react_native_dep("third-party/android/androidx:core"),
|
react_native_dep("third-party/android/androidx:core"),
|
||||||
react_native_dep("third-party/android/androidx:fragment"),
|
react_native_dep("third-party/android/androidx:fragment"),
|
||||||
react_native_dep("third-party/android/androidx:legacy-support-core-ui"),
|
react_native_dep("third-party/android/androidx:legacy-support-core-ui"),
|
||||||
|
@ -16,6 +15,7 @@ rn_android_library(
|
||||||
],
|
],
|
||||||
deps = [
|
deps = [
|
||||||
YOGA_TARGET,
|
YOGA_TARGET,
|
||||||
|
react_native_dep("third-party/android/androidx:annotation"),
|
||||||
react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
|
react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
|
||||||
react_native_dep("third-party/java/infer-annotations:infer-annotations"),
|
react_native_dep("third-party/java/infer-annotations:infer-annotations"),
|
||||||
react_native_dep("third-party/java/jsr-305:jsr-305"),
|
react_native_dep("third-party/java/jsr-305:jsr-305"),
|
||||||
|
|
Загрузка…
Ссылка в новой задаче