Add removeExtra()
Reviewed By: bestander Differential Revision: D14386282 fbshipit-source-id: 045dd0f12cc462da694d20da52f3a591b538dc57
This commit is contained in:
Родитель
1a635c6ade
Коммит
c3475419a9
|
@ -70,6 +70,16 @@ describe('PerformanceLogger', () => {
|
|||
});
|
||||
});
|
||||
|
||||
it('removes an extra', () => {
|
||||
let perfLogger = createPerformanceLogger();
|
||||
perfLogger.setExtra(EXTRA_KEY, EXTRA_VALUE);
|
||||
expect(perfLogger.getExtras()).toEqual({
|
||||
[EXTRA_KEY]: EXTRA_VALUE,
|
||||
});
|
||||
expect(perfLogger.removeExtra(EXTRA_KEY)).toEqual(EXTRA_VALUE);
|
||||
expect(perfLogger.getExtras()).toEqual({});
|
||||
});
|
||||
|
||||
it('logs a point', () => {
|
||||
let perfLogger = createPerformanceLogger();
|
||||
perfLogger.markPoint(POINT, POINT_TIMESTAMP);
|
||||
|
|
|
@ -38,6 +38,7 @@ export type IPerformanceLogger = {
|
|||
addTimespans(Array<number>, Array<string>): void,
|
||||
setExtra(string, any): void,
|
||||
getExtras(): {[key: string]: any},
|
||||
removeExtra(string): ?any,
|
||||
logExtras(): void,
|
||||
markPoint(string, number | void): void,
|
||||
getPoints(): {[key: string]: number},
|
||||
|
@ -217,6 +218,12 @@ function createPerformanceLogger(): IPerformanceLogger {
|
|||
return this._extras;
|
||||
},
|
||||
|
||||
removeExtra(key: string): ?any {
|
||||
const value = this._extras[key];
|
||||
delete this._extras[key];
|
||||
return value;
|
||||
},
|
||||
|
||||
logExtras() {
|
||||
infoLog(this._extras);
|
||||
},
|
||||
|
|
Загрузка…
Ссылка в новой задаче