Mark more member functions as const

Reviewed By: priteshrnandgaonkar

Differential Revision: D7291364

fbshipit-source-id: 2e7d96cfe0345692ffa411bb21a80eb7a859880b
This commit is contained in:
Jonathan Dann 2018-03-21 16:05:12 -07:00 коммит произвёл Facebook Github Bot
Родитель ed0ba1bfc7
Коммит cb3103ce09
2 изменённых файлов: 26 добавлений и 26 удалений

Просмотреть файл

@ -87,7 +87,7 @@ std::array<YGValue, 2> YGNode::getResolvedDimensions() const {
float YGNode::getLeadingPosition( float YGNode::getLeadingPosition(
const YGFlexDirection axis, const YGFlexDirection axis,
const float axisSize) { const float axisSize) const {
if (YGFlexDirectionIsRow(axis)) { if (YGFlexDirectionIsRow(axis)) {
const YGValue* leadingPosition = const YGValue* leadingPosition =
YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined); YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined);
@ -106,7 +106,7 @@ float YGNode::getLeadingPosition(
float YGNode::getTrailingPosition( float YGNode::getTrailingPosition(
const YGFlexDirection axis, const YGFlexDirection axis,
const float axisSize) { const float axisSize) const {
if (YGFlexDirectionIsRow(axis)) { if (YGFlexDirectionIsRow(axis)) {
const YGValue* trailingPosition = const YGValue* trailingPosition =
YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined); YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined);
@ -123,7 +123,7 @@ float YGNode::getTrailingPosition(
: YGUnwrapFloatOptional(YGResolveValue(*trailingPosition, axisSize)); : YGUnwrapFloatOptional(YGResolveValue(*trailingPosition, axisSize));
} }
bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) { bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) const {
return (YGFlexDirectionIsRow(axis) && return (YGFlexDirectionIsRow(axis) &&
YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined) YGComputedEdgeValue(style_.position, YGEdgeStart, &YGValueUndefined)
->unit != YGUnitUndefined) || ->unit != YGUnitUndefined) ||
@ -131,7 +131,7 @@ bool YGNode::isLeadingPositionDefined(const YGFlexDirection axis) {
->unit != YGUnitUndefined; ->unit != YGUnitUndefined;
} }
bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) { bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) const {
return (YGFlexDirectionIsRow(axis) && return (YGFlexDirectionIsRow(axis) &&
YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined) YGComputedEdgeValue(style_.position, YGEdgeEnd, &YGValueUndefined)
->unit != YGUnitUndefined) || ->unit != YGUnitUndefined) ||
@ -141,7 +141,7 @@ bool YGNode::isTrailingPosDefined(const YGFlexDirection axis) {
float YGNode::getLeadingMargin( float YGNode::getLeadingMargin(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
if (YGFlexDirectionIsRow(axis) && if (YGFlexDirectionIsRow(axis) &&
style_.margin[YGEdgeStart].unit != YGUnitUndefined) { style_.margin[YGEdgeStart].unit != YGUnitUndefined) {
return YGResolveValueMargin(style_.margin[YGEdgeStart], widthSize); return YGResolveValueMargin(style_.margin[YGEdgeStart], widthSize);
@ -154,7 +154,7 @@ float YGNode::getLeadingMargin(
float YGNode::getTrailingMargin( float YGNode::getTrailingMargin(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
if (YGFlexDirectionIsRow(axis) && if (YGFlexDirectionIsRow(axis) &&
style_.margin[YGEdgeEnd].unit != YGUnitUndefined) { style_.margin[YGEdgeEnd].unit != YGUnitUndefined) {
return YGResolveValueMargin(style_.margin[YGEdgeEnd], widthSize); return YGResolveValueMargin(style_.margin[YGEdgeEnd], widthSize);
@ -167,7 +167,7 @@ float YGNode::getTrailingMargin(
float YGNode::getMarginForAxis( float YGNode::getMarginForAxis(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
return getLeadingMargin(axis, widthSize) + getTrailingMargin(axis, widthSize); return getLeadingMargin(axis, widthSize) + getTrailingMargin(axis, widthSize);
} }
@ -621,7 +621,7 @@ bool YGNode::isNodeFlexible() {
(resolveFlexGrow() != 0 || resolveFlexShrink() != 0)); (resolveFlexGrow() != 0 || resolveFlexShrink() != 0));
} }
float YGNode::getLeadingBorder(const YGFlexDirection axis) { float YGNode::getLeadingBorder(const YGFlexDirection axis) const {
if (YGFlexDirectionIsRow(axis) && if (YGFlexDirectionIsRow(axis) &&
style_.border[YGEdgeStart].unit != YGUnitUndefined && style_.border[YGEdgeStart].unit != YGUnitUndefined &&
!YGFloatIsUndefined(style_.border[YGEdgeStart].value) && !YGFloatIsUndefined(style_.border[YGEdgeStart].value) &&
@ -634,7 +634,7 @@ float YGNode::getLeadingBorder(const YGFlexDirection axis) {
return YGFloatMax(computedEdgeValue, 0.0f); return YGFloatMax(computedEdgeValue, 0.0f);
} }
float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) { float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) const {
if (YGFlexDirectionIsRow(flexDirection) && if (YGFlexDirectionIsRow(flexDirection) &&
style_.border[YGEdgeEnd].unit != YGUnitUndefined && style_.border[YGEdgeEnd].unit != YGUnitUndefined &&
!YGFloatIsUndefined(style_.border[YGEdgeEnd].value) && !YGFloatIsUndefined(style_.border[YGEdgeEnd].value) &&
@ -650,7 +650,7 @@ float YGNode::getTrailingBorder(const YGFlexDirection flexDirection) {
float YGNode::getLeadingPadding( float YGNode::getLeadingPadding(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
if (YGFlexDirectionIsRow(axis) && if (YGFlexDirectionIsRow(axis) &&
style_.padding[YGEdgeStart].unit != YGUnitUndefined && style_.padding[YGEdgeStart].unit != YGUnitUndefined &&
!YGResolveValue(style_.padding[YGEdgeStart], widthSize).isUndefined() && !YGResolveValue(style_.padding[YGEdgeStart], widthSize).isUndefined() &&
@ -667,7 +667,7 @@ float YGNode::getLeadingPadding(
float YGNode::getTrailingPadding( float YGNode::getTrailingPadding(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
if (YGFlexDirectionIsRow(axis) && if (YGFlexDirectionIsRow(axis) &&
style_.padding[YGEdgeEnd].unit != YGUnitUndefined && style_.padding[YGEdgeEnd].unit != YGUnitUndefined &&
!YGResolveValue(style_.padding[YGEdgeEnd], widthSize).isUndefined() && !YGResolveValue(style_.padding[YGEdgeEnd], widthSize).isUndefined() &&
@ -685,13 +685,13 @@ float YGNode::getTrailingPadding(
float YGNode::getLeadingPaddingAndBorder( float YGNode::getLeadingPaddingAndBorder(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
return getLeadingPadding(axis, widthSize) + getLeadingBorder(axis); return getLeadingPadding(axis, widthSize) + getLeadingBorder(axis);
} }
float YGNode::getTrailingPaddingAndBorder( float YGNode::getTrailingPaddingAndBorder(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize) { const float widthSize) const {
return getTrailingPadding(axis, widthSize) + getTrailingBorder(axis); return getTrailingPadding(axis, widthSize) + getTrailingBorder(axis);
} }

Просмотреть файл

@ -80,23 +80,23 @@ struct YGNode {
YGValue getResolvedDimension(int index); YGValue getResolvedDimension(int index);
// Methods related to positions, margin, padding and border // Methods related to positions, margin, padding and border
float getLeadingPosition(const YGFlexDirection axis, const float axisSize); float getLeadingPosition(const YGFlexDirection axis, const float axisSize) const;
bool isLeadingPositionDefined(const YGFlexDirection axis); bool isLeadingPositionDefined(const YGFlexDirection axis) const;
bool isTrailingPosDefined(const YGFlexDirection axis); bool isTrailingPosDefined(const YGFlexDirection axis) const;
float getTrailingPosition(const YGFlexDirection axis, const float axisSize); float getTrailingPosition(const YGFlexDirection axis, const float axisSize) const;
float getLeadingMargin(const YGFlexDirection axis, const float widthSize); float getLeadingMargin(const YGFlexDirection axis, const float widthSize) const;
float getTrailingMargin(const YGFlexDirection axis, const float widthSize); float getTrailingMargin(const YGFlexDirection axis, const float widthSize) const;
float getLeadingBorder(const YGFlexDirection flexDirection); float getLeadingBorder(const YGFlexDirection flexDirection) const;
float getTrailingBorder(const YGFlexDirection flexDirection); float getTrailingBorder(const YGFlexDirection flexDirection) const;
float getLeadingPadding(const YGFlexDirection axis, const float widthSize); float getLeadingPadding(const YGFlexDirection axis, const float widthSize) const;
float getTrailingPadding(const YGFlexDirection axis, const float widthSize); float getTrailingPadding(const YGFlexDirection axis, const float widthSize) const;
float getLeadingPaddingAndBorder( float getLeadingPaddingAndBorder(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize); const float widthSize) const;
float getTrailingPaddingAndBorder( float getTrailingPaddingAndBorder(
const YGFlexDirection axis, const YGFlexDirection axis,
const float widthSize); const float widthSize) const;
float getMarginForAxis(const YGFlexDirection axis, const float widthSize); float getMarginForAxis(const YGFlexDirection axis, const float widthSize) const;
// Setters // Setters
void setContext(void* context); void setContext(void* context);