Downgrade warning of view illegally being added to parent to Soft Exception
Summary: - This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features. Reviewed By: JoshuaGross Differential Revision: D29857626 fbshipit-source-id: c52cfb6131747ae420b27de0591620fe79f47359
This commit is contained in:
Родитель
63e0f7d767
Коммит
cc13060d70
|
@ -35,6 +35,7 @@ import com.facebook.react.bridge.CatalystInstance;
|
||||||
import com.facebook.react.bridge.ReactContext;
|
import com.facebook.react.bridge.ReactContext;
|
||||||
import com.facebook.react.bridge.ReactMarker;
|
import com.facebook.react.bridge.ReactMarker;
|
||||||
import com.facebook.react.bridge.ReactMarkerConstants;
|
import com.facebook.react.bridge.ReactMarkerConstants;
|
||||||
|
import com.facebook.react.bridge.ReactNoCrashSoftException;
|
||||||
import com.facebook.react.bridge.ReactSoftException;
|
import com.facebook.react.bridge.ReactSoftException;
|
||||||
import com.facebook.react.bridge.UIManager;
|
import com.facebook.react.bridge.UIManager;
|
||||||
import com.facebook.react.bridge.UiThreadUtil;
|
import com.facebook.react.bridge.UiThreadUtil;
|
||||||
|
@ -342,7 +343,7 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot {
|
||||||
if (!child.isShown()) {
|
if (!child.isShown()) {
|
||||||
ReactSoftException.logSoftException(
|
ReactSoftException.logSoftException(
|
||||||
TAG,
|
TAG,
|
||||||
new IllegalViewOperationException(
|
new ReactNoCrashSoftException(
|
||||||
"A view was illegally added as a child of a ReactRootView. "
|
"A view was illegally added as a child of a ReactRootView. "
|
||||||
+ "This View should not be a direct child of a ReactRootView, because it is not visible and will never be reachable. Child: "
|
+ "This View should not be a direct child of a ReactRootView, because it is not visible and will never be reachable. Child: "
|
||||||
+ child.getClass().getCanonicalName().toString()
|
+ child.getClass().getCanonicalName().toString()
|
||||||
|
|
Загрузка…
Ссылка в новой задаче