From cf6ff3f81507e359f29d0fa46acce06dc824b9c6 Mon Sep 17 00:00:00 2001 From: Matt Revell Date: Mon, 29 Jun 2015 05:47:21 -0700 Subject: [PATCH] #1562 Rename 'tick' to 'onTick' to pass iTunes Connect validation. Summary: Should close this issue and successfully pass iTunes Connect validation. Closes https://github.com/facebook/react-native/pull/1722 Github Author: Matt Revell Test Plan: Imported from GitHub, without a `Test Plan:` line. --- React/Base/RCTBatchedBridge.m | 4 ++-- React/Base/RCTFPSGraph.h | 2 +- React/Base/RCTFPSGraph.m | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/React/Base/RCTBatchedBridge.m b/React/Base/RCTBatchedBridge.m index 838e8bc802..0d89d651da 100644 --- a/React/Base/RCTBatchedBridge.m +++ b/React/Base/RCTBatchedBridge.m @@ -721,7 +721,7 @@ RCT_NOT_IMPLEMENTED(-initWithBundleURL:(__unused NSURL *)bundleURL RCTProfileEndEvent(@"DispatchFrameUpdate", @"objc_call", nil); dispatch_async(dispatch_get_main_queue(), ^{ - [self.perfStats.jsGraph tick:displayLink.timestamp]; + [self.perfStats.jsGraph onTick:displayLink.timestamp]; }); } @@ -731,7 +731,7 @@ RCT_NOT_IMPLEMENTED(-initWithBundleURL:(__unused NSURL *)bundleURL RCTProfileImmediateEvent(@"VSYNC", displayLink.timestamp, @"g"); - [self.perfStats.uiGraph tick:displayLink.timestamp]; + [self.perfStats.uiGraph onTick:displayLink.timestamp]; } - (void)startProfiling diff --git a/React/Base/RCTFPSGraph.h b/React/Base/RCTFPSGraph.h index 905829aba2..0c0e2664a8 100644 --- a/React/Base/RCTFPSGraph.h +++ b/React/Base/RCTFPSGraph.h @@ -18,6 +18,6 @@ typedef NS_ENUM(NSUInteger, RCTFPSGraphPosition) { - (instancetype)initWithFrame:(CGRect)frame graphPosition:(RCTFPSGraphPosition)position name:(NSString *)name color:(UIColor *)color NS_DESIGNATED_INITIALIZER; -- (void)tick:(NSTimeInterval)timestamp; +- (void)onTick:(NSTimeInterval)timestamp; @end diff --git a/React/Base/RCTFPSGraph.m b/React/Base/RCTFPSGraph.m index 5e9b0d855e..1aa5efd7dd 100644 --- a/React/Base/RCTFPSGraph.m +++ b/React/Base/RCTFPSGraph.m @@ -93,7 +93,7 @@ RCT_NOT_IMPLEMENTED(-initWithCoder:(NSCoder *)aDecoder) return label; } -- (void)tick:(NSTimeInterval)timestamp +- (void)onTick:(NSTimeInterval)timestamp { _frameCount++; if (_prevTime == -1) {