Reduce FabricUIManager soft errors further
Summary: Reduce soft error volume; see comments. Changelog: [Internal] Reviewed By: ShikaSD Differential Revision: D28551214 fbshipit-source-id: 7e6aa1ee7cad812650bd6219d0cbe568c3cdd3de
This commit is contained in:
Родитель
b2ec89fdfc
Коммит
d670381fac
|
@ -42,7 +42,6 @@ import com.facebook.react.bridge.ReactApplicationContext;
|
||||||
import com.facebook.react.bridge.ReactContext;
|
import com.facebook.react.bridge.ReactContext;
|
||||||
import com.facebook.react.bridge.ReactMarker;
|
import com.facebook.react.bridge.ReactMarker;
|
||||||
import com.facebook.react.bridge.ReactMarkerConstants;
|
import com.facebook.react.bridge.ReactMarkerConstants;
|
||||||
import com.facebook.react.bridge.ReactNoCrashSoftException;
|
|
||||||
import com.facebook.react.bridge.ReactSoftException;
|
import com.facebook.react.bridge.ReactSoftException;
|
||||||
import com.facebook.react.bridge.ReadableArray;
|
import com.facebook.react.bridge.ReadableArray;
|
||||||
import com.facebook.react.bridge.ReadableMap;
|
import com.facebook.react.bridge.ReadableMap;
|
||||||
|
@ -574,11 +573,12 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
|
||||||
try {
|
try {
|
||||||
mountingManager.updateProps(reactTag, props);
|
mountingManager.updateProps(reactTag, props);
|
||||||
} catch (Exception ex) {
|
} catch (Exception ex) {
|
||||||
// TODO T42943890: Fix animations in Fabric and remove this try/catch
|
// TODO T42943890: Fix animations in Fabric and remove this try/catch?
|
||||||
ReactSoftException.logSoftException(
|
// There might always be race conditions between surface teardown and
|
||||||
TAG,
|
// animations/other operations, so it may not be feasible to remove this.
|
||||||
new ReactNoCrashSoftException(
|
// Practically 100% of reported errors from this point are because the
|
||||||
"Caught exception in synchronouslyUpdateViewOnUIThread", ex));
|
// surface has stopped by this point, but the MountItem was queued before
|
||||||
|
// the surface was stopped. It's likely not feasible to prevent all such races.
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче