From ea4724b37c9f78bd33daab547d6cc4f8b7f7dd81 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 6 Jun 2023 05:40:20 -0700 Subject: [PATCH] Remove CircularDepsValidator.cmake as is not needed Summary: We haven't really used this macro, so it's safe to remove as of now. Changelog: [Internal] [Changed] - Remove CircularDepsValidator.cmake as is not needed Reviewed By: javache Differential Revision: D46443083 fbshipit-source-id: 2a48749d7af31c393828668006d53c7a6755ac5d --- .../ReactAndroid/src/main/jni/CMakeLists.txt | 3 -- .../src/main/jni/CircularDepsValidator.cmake | 32 ------------------- 2 files changed, 35 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/jni/CircularDepsValidator.cmake diff --git a/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt b/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt index 78f2b949d9..f97a1a2ee2 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt +++ b/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt @@ -19,9 +19,6 @@ endif(CCACHE_FOUND) add_link_options(-Wl,--build-id) add_compile_options(-Wall -Werror -std=c++17) -# This exposes the check_for_circular_dependencies macro to all the submodules -include(CircularDepsValidator.cmake) - function(add_react_android_subdir relative_path) add_subdirectory(${REACT_ANDROID_DIR}/${relative_path} ReactAndroid/${relative_path}) endfunction() diff --git a/packages/react-native/ReactAndroid/src/main/jni/CircularDepsValidator.cmake b/packages/react-native/ReactAndroid/src/main/jni/CircularDepsValidator.cmake deleted file mode 100644 index 44f8fb9365..0000000000 --- a/packages/react-native/ReactAndroid/src/main/jni/CircularDepsValidator.cmake +++ /dev/null @@ -1,32 +0,0 @@ -# Copyright (c) Meta Platforms, Inc. and affiliates. -# -# This source code is licensed under the MIT license found in the -# LICENSE file in the root directory of this source tree. - -cmake_minimum_required(VERSION 3.13) -set(CMAKE_VERBOSE_MAKEFILE on) - -# Util function that help us verify that you're not including a header file -# which has an invalid import path. Most of the time this is causing a C++ circular dependency. -function(check_for_circular_dependencies allowed_imports_paths) - file(GLOB headers CONFIGURE_DEPENDS *.h) - foreach(file ${headers}) - file(STRINGS ${file} header_file) - while(header_file) - list(POP_FRONT header_file line) - if (line MATCHES "^#include