From ece1dd4ed9b6b3cbf367f9b3d0380db6349e588e Mon Sep 17 00:00:00 2001 From: Xavier Deguillard Date: Tue, 8 Mar 2022 12:35:48 -0800 Subject: [PATCH] BUCK: define GLOG_NO_ABBREVIATED_SEVERITIES everywhere Summary: This is only defined on Windows, and thus code that compiles on all platforms may successfully build on Linux/macOS, but not on Windows, making it potentially harder to detect and debug. Let's unify all platforms to solve this. Changelog: [Internal] Reviewed By: chadaustin Differential Revision: D34648154 fbshipit-source-id: b2549bb3eb120e6207cab8baaafced8b1b18e6a7 --- ReactCommon/react/debug/react_native_assert.h | 2 +- ReactCommon/react/renderer/mounting/StubViewTree.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactCommon/react/debug/react_native_assert.h b/ReactCommon/react/debug/react_native_assert.h index 014329c5a9..b152858b80 100644 --- a/ReactCommon/react/debug/react_native_assert.h +++ b/ReactCommon/react/debug/react_native_assert.h @@ -55,7 +55,7 @@ void react_native_assert_fail( #define react_native_assert(cond) \ if (!(cond)) { \ LOG(ERROR) << "react_native_assert failure: " << #cond; \ - google::FlushLogFiles(google::INFO); \ + google::FlushLogFiles(google::GLOG_INFO); \ assert(cond); \ } diff --git a/ReactCommon/react/renderer/mounting/StubViewTree.cpp b/ReactCommon/react/renderer/mounting/StubViewTree.cpp index e47e1bf929..62d77a08a8 100644 --- a/ReactCommon/react/renderer/mounting/StubViewTree.cpp +++ b/ReactCommon/react/renderer/mounting/StubViewTree.cpp @@ -250,7 +250,7 @@ void StubViewTree::mutate(ShadowViewMutationList const &mutations) { // For iOS especially: flush logs because some might be lost on iOS if an // assert is hit right after this. - google::FlushLogFiles(google::INFO); + google::FlushLogFiles(google::GLOG_INFO); } bool operator==(StubViewTree const &lhs, StubViewTree const &rhs) {