Back out "Add option to disable sending scroll events to Paper"
Summary: Changelog: [internal] Original commit changeset: fa4d8944ad6b Not sending onScroll events events to Paper has no effect. Reviewed By: mdvacca Differential Revision: D29229662 fbshipit-source-id: b84a2614bfd42c64ca67ca6a1cd9d0a815c11ad0
This commit is contained in:
Родитель
e83feffeba
Коммит
fa3697bd9e
|
@ -17,12 +17,6 @@ RCT_EXTERN NSString *const RCTUserInterfaceStyleDidChangeNotificationTraitCollec
|
|||
RCT_EXTERN BOOL RCTExperimentGetOnDemandViewMounting(void);
|
||||
RCT_EXTERN void RCTExperimentSetOnDemandViewMounting(BOOL value);
|
||||
|
||||
/*
|
||||
* Allows sending scroll events to Paper.
|
||||
*/
|
||||
RCT_EXTERN BOOL RCTExperimentGetSendScrollEventToPaper(void);
|
||||
RCT_EXTERN void RCTExperimentSetSendScrollEventToPaper(BOOL value);
|
||||
|
||||
/*
|
||||
* Enables a fix for data race between state and scroll event.
|
||||
*/
|
||||
|
|
|
@ -25,21 +25,6 @@ void RCTExperimentSetOnDemandViewMounting(BOOL value)
|
|||
RCTExperimentOnDemandViewMounting = value;
|
||||
}
|
||||
|
||||
/*
|
||||
* Send scroll events to Paper.
|
||||
*/
|
||||
static BOOL RCTExperimentSendScrollEventToPaper = YES;
|
||||
|
||||
BOOL RCTExperimentGetSendScrollEventToPaper()
|
||||
{
|
||||
return RCTExperimentSendScrollEventToPaper;
|
||||
}
|
||||
|
||||
void RCTExperimentSetSendScrollEventToPaper(BOOL value)
|
||||
{
|
||||
RCTExperimentSendScrollEventToPaper = value;
|
||||
}
|
||||
|
||||
/*
|
||||
* Enable fix for data race between state and scroll event.
|
||||
*/
|
||||
|
|
|
@ -87,7 +87,6 @@ static void RCTSendPaperScrollEvent_DEPRECATED(UIScrollView *scrollView, NSInteg
|
|||
BOOL _isUserTriggeredScrolling;
|
||||
|
||||
BOOL _isOnDemandViewMountingEnabled;
|
||||
BOOL _sendScrollEventToPaper;
|
||||
BOOL _enableScrollViewEventRaceFix;
|
||||
CGPoint _contentOffsetWhenClipped;
|
||||
NSMutableArray<UIView<RCTComponentViewProtocol> *> *_childComponentViews;
|
||||
|
@ -108,7 +107,6 @@ static void RCTSendPaperScrollEvent_DEPRECATED(UIScrollView *scrollView, NSInteg
|
|||
_props = defaultProps;
|
||||
|
||||
_isOnDemandViewMountingEnabled = RCTExperimentGetOnDemandViewMounting();
|
||||
_sendScrollEventToPaper = RCTExperimentGetSendScrollEventToPaper();
|
||||
_enableScrollViewEventRaceFix = RCTExperimentGetScrollViewEventRaceFix();
|
||||
_childComponentViews = [[NSMutableArray alloc] init];
|
||||
|
||||
|
@ -426,9 +424,7 @@ static void RCTSendPaperScrollEvent_DEPRECATED(UIScrollView *scrollView, NSInteg
|
|||
}
|
||||
// Once Fabric implements proper NativeAnimationDriver, this should be removed.
|
||||
// This is just a workaround to allow animations based on onScroll event.
|
||||
if (_sendScrollEventToPaper) {
|
||||
RCTSendPaperScrollEvent_DEPRECATED(scrollView, self.tag);
|
||||
}
|
||||
RCTSendPaperScrollEvent_DEPRECATED(scrollView, self.tag);
|
||||
}
|
||||
|
||||
[self _remountChildrenIfNeeded];
|
||||
|
|
|
@ -256,10 +256,6 @@ static BackgroundExecutor RCTGetBackgroundExecutor()
|
|||
RCTExperimentSetOnDemandViewMounting(YES);
|
||||
}
|
||||
|
||||
if (reactNativeConfig && reactNativeConfig->getBool("react_fabric:disable_sending_scroll_events_to_paper")) {
|
||||
RCTExperimentSetSendScrollEventToPaper(NO);
|
||||
}
|
||||
|
||||
if (reactNativeConfig && reactNativeConfig->getBool("react_fabric:enable_state_scroll_data_race_ios")) {
|
||||
RCTExperimentSetScrollViewEventRaceFix(YES);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче