Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/32585
D31631766 (b60e229d7f) unified compiler flags for all RN targets, which also enabled `-Werror` for this target. This causes issues on Windows where some warnings are extremely noisy and unhelpful and causes our Hermes+JSInspector build to fail
Reviewed By: rshest
Differential Revision: D32244577
fbshipit-source-id: 7cda346c46d21ff03490bae705759c502f6cf29f
Summary:
Nearly all of these are identical and these compiler_flags are now centralized in rn_defs.bzl. This should have NO CHANGE on build configuration, the flags have just moved for now.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D31631766
fbshipit-source-id: be40ebeb70ae52b7ded07ca08c4a29f10a0ed925
Summary:
The fbcode version of Skylight needs this and it is already compiling fine
Changelog: [Internal]
Reviewed By: dulinriley
Differential Revision: D27765879
fbshipit-source-id: 18aca2756f39326fb90397a10a67583db84076fd
Summary:
The reason for this change is that it is the primary root that we want people to be using and the naming should reflect that.
#nocancel
build-break
overriding_review_checks_triggers_an_audit_and_retroactive_review
Changelog: [Internal]
Oncall Short Name: fbobjc_sheriff
Differential Revision: D19431128
fbshipit-source-id: c7208e20ed0f5f5eb6c2849428c09a6d4af9b6f3
Summary:
`xplat` targets add different deps based on what platform the target is being built for.
for anything using `fb_xplat`, we can put all ios supermodules in `fbobjc_labels` and all android sms in `fbandroid_labels`
There's some weirdness with python targets like `thrift_gen` in `/xplat/mobileconfig/tools/generator/gen-py/BUCK` that don't have platform-specific labels because the except_for list for `fbandroid` doesn't need the `fbsource//` prefix (see changes in `/ios/isolation/infra.mobileconfig.sm`)
Changelog: [Internal]
Reviewed By: shergin, joshleibsly
Differential Revision: D17884952
fbshipit-source-id: e245364cf515b75682990094d24f789d53b1f3f5
Pieter De Baets
Joshua Gross
Pedro Veras
Kevin Gozali
Janette Cheng
Josh Leibsly
Adam Ernst
Jonathan Kim
Taras Tsugrii
Ben Nham