63a6bb7637
Remove remaining references to local-cli
...
Summary: This removes the remaining references to `local-cli`. We already have a `cli.js` file on the root that was just forwarding to the local-cli folder, so I removed that. It also seems that `setupBabel.js` is no longer necessary in RN.
Reviewed By: TheSavior
Differential Revision: D13396218
fbshipit-source-id: a945cb91dae39c4b58c5cabcca6b0f0328fc4717
2018-12-10 19:08:10 -08:00
eb413bc9e0
Remove "babel-core" and other babel 6 modules.
...
Summary: We are using babel 7 and should not be using babel 6 any longer, this removes some references to babel 6 modules.
Reviewed By: yungsters
Differential Revision: D13137326
fbshipit-source-id: 4a2db84522e5613f72a8005f0b1e9943e815f9ec
2018-12-10 18:12:05 -08:00
fb16af7944
Detox debug build ( #22572 )
...
Summary:
Adds a Detox configuration and instructions for running the app in development mode in Detox. This speeds up developing tests, because changes to production code don't require a full rebuild.
Pull Request resolved: https://github.com/facebook/react-native/pull/22572
Differential Revision: D13396883
Pulled By: cpojer
fbshipit-source-id: 186cc8d75eccae411b602cb0f68f0e11856e0743
2018-12-10 02:33:31 -08:00
896bb8a21e
Move react-native template
...
Summary: This diff moves the React Native template from `local-cli/templates/HelloWorld` to `template`. Keeping it in the react-native repo will allow us to make changes to the template and version it together with react-native, instead of moving it out into a separate repo and trying to keep the template in sync with RN.
Reviewed By: TheSavior
Differential Revision: D13372949
fbshipit-source-id: e68e267b4dcf6384535d7b48fc11e297a12e9676
2018-12-07 07:49:19 -08:00
9d3f598c2c
Remove references to `local-cli`
...
Summary: This cleans up various configurations after the removal of this folder.
Reviewed By: hramos
Differential Revision: D13338515
fbshipit-source-id: 9d6877921e15a183e46861626af831231333f42a
2018-12-07 07:49:18 -08:00
96ce6f9538
Bump ws package to 1.1.5 due to vulnerability issues ( #21769 )
...
Summary:
Update `ws` package from 1.1.0 to 1.1.5 due to vulnerability issues.
Here is `npm audit` report:
```
=== npm audit security report ===
┌──────────────────────────────────────────────────────────────────────────────┐
│ Manual Review │
│ Some vulnerabilities require your attention to resolve │
│ │
│ Visit https://go.npm.me/audit-guide for additional guidance │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ ws │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >= 1.1.5 <2.0.0 || >=3.3.1 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ c635d8a886cde7688a0123f573cc5b1f0430780052ba848c8fa1dc8a4c3… │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ c635d8a886cde7688a0123f573cc5b1f0430780052ba848c8fa1dc8a4c3… │
│ │ > react-devtools-core > ws │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://nodesecurity.io/advisories/550 │
└───────────────┴──────────────────────────────────────────────────────────────┘
```
Pull Request resolved: https://github.com/facebook/react-native/pull/21769
Reviewed By: hramos
Differential Revision: D10379892
Pulled By: cpojer
fbshipit-source-id: 9d03f8231a90c5f55eb95ccac029aedd45a49a2d
2018-12-03 22:21:56 -08:00
073ad6a036
React sync for revisions 3ff2c7c...6bf5e85
...
Summary:
@public
This sync includes the following changes:
- **[6bf5e8598](https://github.com/facebook/react/commit/6bf5e8598 )**: Fix scheduler setTimeout() re-entrancy check (#14384 ) //<Brian Vaughn>//
- **[7a48c900b](https://github.com/facebook/react/commit/7a48c900b )**: Prevent a v8 deopt when profiling (#14383 ) //<Brian Vaughn>//
- **[f00c2755b](https://github.com/facebook/react/commit/f00c2755b )**: Removed unnecessary externals from Jest bundles (#14372 ) //<Brian Vaughn>//
- **[52bea95cf](https://github.com/facebook/react/commit/52bea95cf )**: Fixed scheduler setTimeout fallback (#14358 ) //<Brian Vaughn>//
- **[1d25aa578](https://github.com/facebook/react/commit/1d25aa578 )**: [Fizz] New Server Rendering Infra (#14144 ) //<Sebastian Markbåge>//
- **[f1bf28160](https://github.com/facebook/react/commit/f1bf28160 )**: Fix bug in cloneHook (#14364 ) //<Imre Osswald>//
- **[16e120438](https://github.com/facebook/react/commit/16e120438 )**: [Fire] Add initial build infrastructure (#14359 ) //<Dan Abramov>//
- **[d14ba87b1](https://github.com/facebook/react/commit/d14ba87b1 )**: Validate propTypes for lazy() and memo() and warn about invalid patterns (#14298 ) //<Dan Abramov>//
- **[4f964f09c](https://github.com/facebook/react/commit/4f964f09c )**: Adding isMemo check to react-is package (#14313 ) //<Jinto Jose>//
- **[c2a2d8a53](https://github.com/facebook/react/commit/c2a2d8a53 )**: Remove useMutationEffect (#14336 ) //<Sophie Alpert>//
- **[48f1e5b3c](https://github.com/facebook/react/commit/48f1e5b3c )**: Add a null type test for memo (#14325 ) //<chun shang>//
- **[f93f3402f](https://github.com/facebook/react/commit/f93f3402f )**: Make useEffect(async) warning more verbose (#14327 ) //<Dan Abramov>//
- **[ee3ef3a07](https://github.com/facebook/react/commit/ee3ef3a07 )**: Fix regression: Errors not emitted in streams (#14314 ) //<Pelle Wessman>//
- **[33f6f5e53](https://github.com/facebook/react/commit/33f6f5e53 )**: Remove usage of `fbjs/lib/invariant` in ReactNativeViewConfigRegistry. (#14330 ) //<Christoph Nakazawa>//
- **[686f1060a](https://github.com/facebook/react/commit/686f1060a )**: Publish a local release (canary or stable) to NPM (#14260 ) //<Brian Vaughn>//
- **[7475120ce](https://github.com/facebook/react/commit/7475120ce )**: Prevent deopts from modifying exports object in stable builds (#14309 ) //<Dan Abramov>//
- **[0c7189d92](https://github.com/facebook/react/commit/0c7189d92 )**: Fix resolution of outer props with React.memo() (#14312 ) //<Dan Abramov>//
- **[14be29b2b](https://github.com/facebook/react/commit/14be29b2b )**: Add more test coverage for nested memo() (#14311 ) //<Dan Abramov>//
- **[dc0dd4bbf](https://github.com/facebook/react/commit/dc0dd4bbf )**: Use |0 to coerce to number (#14297 ) //<Dan Abramov>//
- **[dd8205cef](https://github.com/facebook/react/commit/dd8205cef )**: List ignored types instead of included types in the stack (#14308 ) //<Dan Abramov>//
- **[a9fdf8a32](https://github.com/facebook/react/commit/a9fdf8a32 )**: Warn about reassigning this.props (#14277 ) //<Dan Abramov>//
- **[327cf0ee3](https://github.com/facebook/react/commit/327cf0ee3 )**: Fix support for mixing react-dom/server@16.6 and react@<16.6 (#14291 ) //<Dan Abramov>//
- **[c954efa70](https://github.com/facebook/react/commit/c954efa70 )**: Remove `import * as` pattern from the codebase (#14282 ) //<Sebastian Markbåge>//
- **[ccb14e270](https://github.com/facebook/react/commit/ccb14e270 )**: Fix SSR useCallback in render phase (#14279 ) //<Dan Abramov>//
- **[0e9cb3f5d](https://github.com/facebook/react/commit/0e9cb3f5d )**: Clear fields on unmount of fiber to avoid memory leak (#14276 ) //<Dominic Gannaway>//
- **[592676503](https://github.com/facebook/react/commit/592676503 )**: Revert "Clear memoizedState on unmount of fiber to avoid memory leak (#14218 )" (#14275 ) //<Dominic Gannaway>//
- **[9b2fb24f9](https://github.com/facebook/react/commit/9b2fb24f9 )**: Clear memoizedState on unmount of fiber to avoid memory leak (#14218 ) //<Dominic Gannaway>//
- **[a22fabc2a](https://github.com/facebook/react/commit/a22fabc2a )**: Reduce scheduler serialization overhead (#14249 ) //<Jason Miller>//
- **[21d5f7d32](https://github.com/facebook/react/commit/21d5f7d32 )**: Wrap shorthand CSS property collision warning in feature flag (#14245 ) //<Andrew Clark>//
- **[8feeed10d](https://github.com/facebook/react/commit/8feeed10d )**: [scheduler] Remove window.postMessage fallback //<Andrew Clark>//
- **[5bce0ef10](https://github.com/facebook/react/commit/5bce0ef10 )**: [scheduler] Post to MessageChannel instead of window (#14234 ) //<Andrew Clark>//
- **[f55795c8e](https://github.com/facebook/react/commit/f55795c8e )**: Add regression test for #14188 (#14197 ) //<Dan Abramov>//
- **[b98adb648](https://github.com/facebook/react/commit/b98adb648 )**: Simplify CSS shorthand property warning (#14183 ) //<Sophie Alpert>//
- **[f8bfd5868](https://github.com/facebook/react/commit/f8bfd5868 )**: fix typo //<Sebastian Markbage>//
- **[961eb65b4](https://github.com/facebook/react/commit/961eb65b4 )**: Use unique thread ID for each partial render to access Context (#14182 ) //<Sebastian Markbåge>//
- **[1a6ab1e9b](https://github.com/facebook/react/commit/1a6ab1e9b )**: SimpleMemoComponent should warn if a ref is given (#14178 ) //<Sophie Alpert>//
- **[8ae867e6b](https://github.com/facebook/react/commit/8ae867e6b )**: Warn about conflicting style values during updates (#14181 ) //<Sophie Alpert>//
- **[d5e1bf07d](https://github.com/facebook/react/commit/d5e1bf07d )**: Renamed outdated schedule/tracing referecnes (#14177 ) //<Brian Vaughn>//
- **[2dd4ba11e](https://github.com/facebook/react/commit/2dd4ba11e )**: ESlint -> ESLint //<Andrew Clark>//
- **[9cc631a53](https://github.com/facebook/react/commit/9cc631a53 )**: Don't run danger on bad build (#14143 ) //<Sophie Alpert>//
- **[1034e26fe](https://github.com/facebook/react/commit/1034e26fe )**: Fix typos (#14124 ) //<Heaven>//
- **[5618da49d](https://github.com/facebook/react/commit/5618da49d )**: Fix comment typo (#14156 ) //<Bartosz Gordon>//
- **[9fb919945](https://github.com/facebook/react/commit/9fb919945 )**: Add global to ESLint plugin bundle config //<Andrew Clark>//
- **[c174f8592](https://github.com/facebook/react/commit/c174f8592 )**: Add fb build of ESLint plugin (#14165 ) //<Andrew Clark>//
- **[02e4848e3](https://github.com/facebook/react/commit/02e4848e3 )**: Improved suspense support in ReactDOMServer (#14161 ) //<Alex Taylor>//
- **[4b163fee1](https://github.com/facebook/react/commit/4b163fee1 )**: Remove errant return assignment (#14164 ) //<Andrew Clark>//
- **[e58ecda9a](https://github.com/facebook/react/commit/e58ecda9a )**: Suspense fuzz tester (#14147 ) //<Andrew Clark>//
- **[7fd1661f8](https://github.com/facebook/react/commit/7fd1661f8 )**: Don't warn if an unmounted component is pinged (#14158 ) //<Andrew Clark>//
- **[f9e9913f0](https://github.com/facebook/react/commit/f9e9913f0 )**: [Synchronous Suspense] Don't delete children of suspended component (#14157 ) //<Andrew Clark>//
- **[7c560131b](https://github.com/facebook/react/commit/7c560131b )**: Adding logger pri (#14155 ) //<Nathan Schloss>//
- **[3d8bda70e](https://github.com/facebook/react/commit/3d8bda70e )**: Refactor ESLint configuration to enable better IDE integration (#13914 ) //<Minh Nguyen>//
- **[051272f20](https://github.com/facebook/react/commit/051272f20 )**: Use Entry in `yarn build ...` Instead of Label (#14148 ) //<Sebastian Markbåge>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions 3ff2c7c...6bf5e85
Reviewed By: bvaughn
Differential Revision: D13288288
fbshipit-source-id: 89a4837a9198c53fc79306933f589ef25d8bb4b6
2018-12-03 16:29:53 -08:00
4148976a83
Use `invariant` instead of `fbjs/lib/invariant`
...
Summary: This is one more step to remove `fbjs` from `react-native-github`. This changes both the internal and external code to use `invariant` from zertosh instead of the copy in fbjs.
Reviewed By: yungsters
Differential Revision: D13195941
fbshipit-source-id: 73564ca1715110e7da9c7ef56dc57374d61377e0
2018-12-03 00:07:02 -08:00
cb6eb03776
Extract out CLI ( #22337 )
...
Summary:
Continuation of https://github.com/facebook/react-native/pull/22174 with an exception that `local-cli` folder is left in React Native repository to keep Facebook internal and React Native calls still working.
Separate strategy should be developed to remove all uses of `local-cli` in favor of dedicated utilities.
Pull Request resolved: https://github.com/facebook/react-native/pull/22337
Reviewed By: TheSavior
Differential Revision: D13172898
Pulled By: cpojer
fbshipit-source-id: 0217867f9944648307475ebe629eb729da7bfaaf
2018-12-02 22:21:43 -08:00
69e9c9d371
Add Coveralls to package.json [1/2] ( #21017 )
...
Summary:
Adds a new step to the test suite. Test coverage is now collected and sent to Coveralls.
Initial configuration is limited to the Libraries/ and local-cli/ directories. Please let me know if additional directories should be considered.
I have enabled this repo on the coveralls service. The coveralls token has been added to React Native's Circle CI environment variables.
- Track coverage on PRs, and fail PRs that lower the coverage %
- Increase coverage :)
[INTERNAL] [ENHANCEMENT] [.circleci/config.yml] - Start tracking code coverage (JS)
Pull Request resolved: https://github.com/facebook/react-native/pull/21017
Differential Revision: D9724396
Pulled By: hramos
fbshipit-source-id: 61da4478877805f9a9a3c9670b54ddc4e40e958b
2018-11-30 19:49:00 -08:00
3749da1312
Make RNTester build and pass again ( #22468 )
...
Summary:
Detox was failing because of build errors due to the new xcode10 build system. These errors were fixed by RSNara in b7349f9857https://github.com/facebook/react-native/pull/22468
Reviewed By: RSNara
Differential Revision: D13287386
Pulled By: TheSavior
fbshipit-source-id: 8a2df9801c69d851eabe7074ffc12b29c03a636a
2018-11-30 18:30:39 -08:00
8d68a3e9f1
Upgrade metro in RN
...
Summary: Upgrade metro, yay! :)
Reviewed By: hramos
Differential Revision: D13267399
fbshipit-source-id: 37ec0daa2a282f56a70db0dfdfbf40e361813a15
2018-11-30 02:58:24 -08:00
ef2084c6bd
0.87.0 in xplat/js
...
Summary: allow-large-files
Reviewed By: samwgoldman
Differential Revision: D13230018
fbshipit-source-id: f07e2371a3b7382de0592cc7c7b20e7f4faa6889
2018-11-28 17:32:50 -08:00
4355b2df1b
JS: Upgrade to `chalk@^2.4.1`
...
Summary: Upgrades to `chalk@^2.4.1`. Verified no dependencies to the breaking changes in `chalk@2.0.0`.
Reviewed By: cpojer
Differential Revision: D13192150
fbshipit-source-id: 27a1a53d50a3c7628528a4f21e7166d452b2f205
2018-11-27 23:33:56 -08:00
922e196ed1
jest: make regex for tests stricter
...
Summary:
Updated the configuration for all projects on xplat/js to only consider tests that end with `-test.js`.
All tests were migrated in the previous diff of the stack.
Reviewed By: mjesun
Differential Revision: D13185676
fbshipit-source-id: baaba94fabc403acb30b0b5a0462788813d7a870
2018-11-26 10:30:12 -08:00
3355c52467
Bump metro version in React Native
...
Summary: This is the tweak on the release process of metro: after publishing D13075199 and releasing a new version of Metro, this diff upgrades it in RN along with its yarn.lock file. This should allow us to publish new versions of metro without breaking the RN sanity scripts (or disable them).
Reviewed By: hramos
Differential Revision: D13084224
fbshipit-source-id: 19781ae142db11d7dd8b6ca4303366f7ccb32dcc
2018-11-22 12:27:10 -08:00
8fb228f313
Flow v0.86.0 in xplat/js
...
Summary:
allow-large-files
bypass-lint
ignore-conflict-markers
ignore-signed-source
ignore-nocommit
drop-conflicts
Reviewed By: yungsters
Differential Revision: D13081129
fbshipit-source-id: fbb0ccaf3c0a2f224a56f6f6ac6c26811ebba583
2018-11-16 10:43:16 -08:00
a00940693e
New TextInput-test that would have prevented S168585
...
Summary: Adds a basic test that would have prevented S168585. We should expand coverage of this and other components as well.
Reviewed By: TheSavior
Differential Revision: D13038064
fbshipit-source-id: 14cf4742efd53d7bca2a3f8d1c5c34ebc6227674
2018-11-15 20:51:52 -08:00
aacb06c594
Fix React Native AsyncMode and DevTools
...
Summary:
Fixes two problems I uncovered with React Native:
1. `FBCore/Prelude` points to `React.unstable_AsyncMode` which is not defined. (This type was renamed to `React.unstable_ConcurrentMode` in React v16.6.0. **As a result** people in the "react_native:async_rendering" GK will no longer get runtime errors on app start.
2. Updates `react-devtools` and (more importantly) `react-devtools-core` to 3.4.2 to handle the React-internal tag/type refactoring that happened prior to the release of 16.6.0. **As a result** DevTools will no longer cause a runtime error when connected to React Native.
For the second change, I ran `js1 upgrade react-devtools -v ^3.4.2`
Reviewed By: sebmarkbage
Differential Revision: D13030590
fbshipit-source-id: 603f7f6259f282839039820bcdba4310064a7965
2018-11-15 09:26:01 -08:00
984eef8f9e
Revert D12994045: Flow v0.86.0 in xplat/js [3/n]
...
Differential Revision:
D12994045
Original commit changeset: 04552bf081ba
fbshipit-source-id: 062b367b88a966a6efc895c99e9911f0ec0fe8ff
2018-11-14 23:04:04 -08:00
43ad3a64e6
Flow v0.86.0 in xplat/js [3/n]
...
Summary:
allow-large-files
bypass-lint
ignore-conflict-markers
ignore-signed-source
ignore-nocommit
drop-conflicts
Reviewed By: avikchaudhuri
Differential Revision: D12994045
fbshipit-source-id: 04552bf081ba742de58e80fba08f8280cb86b1c3
2018-11-14 22:13:27 -08:00
06c13b3e06
Upgrade jest to v24.0.0-alpha.6
...
Summary: yayyay
Reviewed By: mjesun
Differential Revision: D13027838
fbshipit-source-id: ce51a82fa4c6dfa62e202e52c2733d161ae52883
2018-11-14 15:26:55 -08:00
de60e8643a
Bump metro@0.49.1
...
Summary: galavant-fistbump
Reviewed By: jeanlauliac
Differential Revision: D13027247
fbshipit-source-id: 3635527b6c745111b26d9f61666c30e696b04526
2018-11-12 11:31:28 -08:00
0cb59b5c23
React sync for revisions 4773fdf...3ff2c7c
...
Summary:
@public
This sync includes the following changes:
- **[3ff2c7ccd](https://github.com/facebook/react/commit/3ff2c7ccd )**: Invalid actualDuration+treeBaseDuration for hidden+suspended trees (#14065 ) //<Brian Vaughn>//
- **[5afa1c4ed](https://github.com/facebook/react/commit/5afa1c4ed )**: Tag MemoComponent with PerformedWork effectTag for DevTools Profiler (#14141 ) //<Brian Vaughn>//
- **[e27720d7f](https://github.com/facebook/react/commit/e27720d7f )**: [Synchronous Suspense] Reuse deletions from primary tree (#14133 ) //<Andrew Clark>//
- **[aa1ffe4e7](https://github.com/facebook/react/commit/aa1ffe4e7 )**: Show deprecated context object warnings usage in ReactDOM server (#14033 ) //<Dominic Gannaway>//
- **[e3a7b9645](https://github.com/facebook/react/commit/e3a7b9645 )**: Make react-debug-tools a private package //<Andrew Clark>//
- **[ba1984423](https://github.com/facebook/react/commit/ba1984423 )**: Update bundle sizes for 16.6.1 release //<Andrew Clark>//
- **[b50e63ef5](https://github.com/facebook/react/commit/b50e63ef5 )**: Updating package versions for release 16.6.1 //<Andrew Clark>//
- **[8f2c89e96](https://github.com/facebook/react/commit/8f2c89e96 )**: Make react-debug-tools a private package //<Andrew Clark>//
- **[2aecbcd6f](https://github.com/facebook/react/commit/2aecbcd6f )**: "functional component" -> "function component" (#14123 ) //<locknono>//
- **[b4608dd24](https://github.com/facebook/react/commit/b4608dd24 )**: Remove unused simulated flag parameter (#14127 ) //<Nadav Kaner>//
- **[3c69a1881](https://github.com/facebook/react/commit/3c69a1881 )**: Recover from errors with a boundary in completion phase (#14104 ) //<Dan Abramov>//
- **[b020fb114](https://github.com/facebook/react/commit/b020fb114 )**: Check correct commit phase props in fuzz tester (#14129 ) //<Andrew Clark>//
- **[b67c1a2ee](https://github.com/facebook/react/commit/b67c1a2ee )**: Add DEV-only checks for assumption about instance properties (#14128 ) //<Dan Abramov>//
- **[f777d196e](https://github.com/facebook/react/commit/f777d196e )**: Fix lazy() with defaultProps (#14112 ) //<Dan Abramov>//
- **[e4512991c](https://github.com/facebook/react/commit/e4512991c )**: Fix unhiding in IE11 (#14126 ) //<Sophie Alpert>//
- **[affb2b50c](https://github.com/facebook/react/commit/affb2b50c )**: Enable hooks in www test renderer, too //<Andrew Clark>//
- **[0a0f503d5](https://github.com/facebook/react/commit/0a0f503d5 )**: Enable hooks in www build (#14116 ) //<Andrew Clark>//
- **[600651e68](https://github.com/facebook/react/commit/600651e68 )**: Restore the Hooks dispatcher after using SSR (#14105 ) //<Dan Abramov>//
- **[e9a2ec915](https://github.com/facebook/react/commit/e9a2ec915 )**: [suspense] Avoid double commit by re-rendering immediately and reusing primary children (#14083 ) //<Andrew Clark>//
- **[9d47143e8](https://github.com/facebook/react/commit/9d47143e8 )**: Implement {,un}hideInstance on RN renderer (#14115 ) //<Sophie Alpert>//
- **[ebdb47d2c](https://github.com/facebook/react/commit/ebdb47d2c )**: DCE hooks code when flag is off (#14111 ) //<Sophie Alpert>//
- **[8b87ebf5b](https://github.com/facebook/react/commit/8b87ebf5b )**: Rename .internal tests that aren't using internals (#14109 ) //<Sophie Alpert>//
- **[da04058a9](https://github.com/facebook/react/commit/da04058a9 )**: Use Function.prototype.apply in warningWithoutStack (#14107 ) //<Sophie Alpert>//
- **[fd1256a56](https://github.com/facebook/react/commit/fd1256a56 )**: Add Debug Tools Package for Introspection of Hooks (#14085 ) //<Sebastian Markbåge>//
- **[b305c4e03](https://github.com/facebook/react/commit/b305c4e03 )**: fix(react-dom): Fix crash during server render (#14103 ) //<Tiago Nunes>//
- **[d34d1c3ba](https://github.com/facebook/react/commit/d34d1c3ba )**: react-reconciler: Update README.md (#13953 ) //<Marcelo Jorge Vieira>//
- **[6c404d82a](https://github.com/facebook/react/commit/6c404d82a )**: Bugfix: Add back early return in setOffsets which was removed between 16.4.2 and 16.5.0. Fails in Edge in some scenarios. (#14095 ) //<einarq>//
- **[8eca0eff8](https://github.com/facebook/react/commit/8eca0eff8 )**: chore(tests): don't rely on jest fake timers scheduling real timers (#14003 ) //<Simen Bekkhus>//
- **[293fed899](https://github.com/facebook/react/commit/293fed899 )**: Warn for bad useEffect return value (#14069 ) //<Sophie Alpert>//
- **[ae196e84b](https://github.com/facebook/react/commit/ae196e84b )**: Rename inputsAreEqual to areHookInputsEqual & move it to shared (#14036 ) //<Mateusz Burzyński>//
- **[c898020e0](https://github.com/facebook/react/commit/c898020e0 )**: Warn for forwardRef(memo(...)) (#14070 ) //<Sophie Alpert>//
- **[bf9fadfcf](https://github.com/facebook/react/commit/bf9fadfcf )**: [Hooks] Remove dispatch callbacks (#14037 ) //<Andrew Clark>//
- **[8c67bbf18](https://github.com/facebook/react/commit/8c67bbf18 )**: [scheduler] Deadline object -> shouldYield (#14025 ) //<Andrew Clark>//
- **[e02086bfc](https://github.com/facebook/react/commit/e02086bfc )**: Warn about variable number of dependencies //<Andrew Clark>//
- **[b92cdef64](https://github.com/facebook/react/commit/b92cdef64 )**: Rename ReactHooks test suite //<Andrew Clark>//
- **[6efbbe068](https://github.com/facebook/react/commit/6efbbe068 )**: Prettier //<Sophie Alpert>//
- **[504576306](https://github.com/facebook/react/commit/504576306 )**: Swap order of function member in hook union types //<Andrew Clark>//
- **[ddbfe2ed5](https://github.com/facebook/react/commit/ddbfe2ed5 )**: Add ESLint rule for React Hooks //<Caleb Meredith>//
- **[acb489963](https://github.com/facebook/react/commit/acb489963 )**: Clear effect tags from a fiber that suspends in non-concurrent mode //<Andrew Clark>//
- **[933b64710](https://github.com/facebook/react/commit/933b64710 )**: Disable hook update callback (2nd arg to setState/dispatch) //<Andrew Clark>//
- **[5fc84efac](https://github.com/facebook/react/commit/5fc84efac )**: Skip updating effect tag when skipping effect //<Sophie Alpert>//
- **[9f34eb79a](https://github.com/facebook/react/commit/9f34eb79a )**: Add readContext to ReactPartialRendererHooks //<Alex Taylor>//
- **[f7cb9d2b2](https://github.com/facebook/react/commit/f7cb9d2b2 )**: Warn about useContext(Consumer|Provider) //<Dan Abramov>//
- **[63cc7d2b3](https://github.com/facebook/react/commit/63cc7d2b3 )**: Test useContext in pure, forwardRef, and PureComponent //<Dan Abramov>//
- **[3a7c6da8d](https://github.com/facebook/react/commit/3a7c6da8d )**: Make effects actually work with memo //<Sophie Alpert>//
- **[75a1c2e72](https://github.com/facebook/react/commit/75a1c2e72 )**: The Lost Effect, chapter 3 //<Sophie Alpert>//
- **[55a4b1f37](https://github.com/facebook/react/commit/55a4b1f37 )**: memo supports Hooks //<Sophie Alpert>//
- **[30aa4ad55](https://github.com/facebook/react/commit/30aa4ad55 )**: The Lost Effect, chapter 2 //<Sophie Alpert>//
- **[b772e0e26](https://github.com/facebook/react/commit/b772e0e26 )**: "functional component" -> "function component" in hooks error messages //<Sebastian Markbåge>//
- **[9e9e3970e](https://github.com/facebook/react/commit/9e9e3970e )**: Warn for Hook set-state on unmounted component //<Sophie Alpert>//
- **[6514697f0](https://github.com/facebook/react/commit/6514697f0 )**: Make sure deletions don't stop passive effects //<Sophie Alpert>//
- **[dd019d34d](https://github.com/facebook/react/commit/dd019d34d )**: Add support for hooks to ReactDOMServer //<Alex Taylor>//
- **[11d0781ee](https://github.com/facebook/react/commit/11d0781ee )**: Defer useEffect until after paint //<Andrew Clark>//
- **[105f2de54](https://github.com/facebook/react/commit/105f2de54 )**: Put hooks behind feature flag //<Andrew Clark>//
- **[7bee9fbdd](https://github.com/facebook/react/commit/7bee9fbdd )**: Initial hooks implementation //<Andrew Clark>//
- **[37c7fe0a5](https://github.com/facebook/react/commit/37c7fe0a5 )**: Update createRoot warning message based on `enableStableConcurrentModeAPIs` (#14017 ) //<Rauno Freiberg>//
- **[95f98a187](https://github.com/facebook/react/commit/95f98a187 )**: fix typo (#13955 ) //<Joseph>//
- **[e217f2f1a](https://github.com/facebook/react/commit/e217f2f1a )**: Updated comment for getEventModifierState (#13918 ) //<Patrick>//
- **[275e76e83](https://github.com/facebook/react/commit/275e76e83 )**: Enable stable concurrent APIs flag for 16.7 alpha (#13928 ) //<Brian Vaughn>//
- **[8b97a9c36](https://github.com/facebook/react/commit/8b97a9c36 )**: Update bundle sizes for 16.6.0 release //<Dan Abramov>//
- **[6c29eabf7](https://github.com/facebook/react/commit/6c29eabf7 )**: Updating package versions for release 16.6.0 //<Dan Abramov>//
- **[d520b358d](https://github.com/facebook/react/commit/d520b358d )**: Revert all package versions to 16.5.2 state //<Dan Abramov>//
- **[8f1ec7649](https://github.com/facebook/react/commit/8f1ec7649 )**: Bump versions to beta.0 //<Dan Abramov>//
- **[5055a83fa](https://github.com/facebook/react/commit/5055a83fa )**: Revert "Revert "Updating dependencies for react-noop-renderer"" //<Dan Abramov>//
- **[3e8b4a5b8](https://github.com/facebook/react/commit/3e8b4a5b8 )**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>//
- **[d8e03de4a](https://github.com/facebook/react/commit/d8e03de4a )**: [react-cache] Remove `cache` as argument to `read` (#13865 ) //<Andrew Clark>//
- **[fefa1269e](https://github.com/facebook/react/commit/fefa1269e )**: Revert accidentally committed existence check (#13931 ) //<Andrew Clark>//
- **[80a0c05ce](https://github.com/facebook/react/commit/80a0c05ce )**: Removed react-cache from the bundle list for now (#13930 ) //<BrianVaughn>//
- **[915e4eab5](https://github.com/facebook/react/commit/915e4eab5 )**: Add "unstable_" prefix to react-cache and jest-react (#13929 ) //<Brian Vaughn>//
- **[cbbc2b6c4](https://github.com/facebook/react/commit/cbbc2b6c4 )**: [Synchronous Suspense] Suspending a class outside concurrent mode (#13926 ) //<Andrew Clark>//
- **[4947fcd76](https://github.com/facebook/react/commit/4947fcd76 )**: Fix lint (#13923 ) //<Sebastian Markbåge>//
- **[d75c69e0c](https://github.com/facebook/react/commit/d75c69e0c )**: Remove unstable_ prefix from Suspense (#13922 ) //<Sebastian Markbåge>//
- **[c8ef2feda](https://github.com/facebook/react/commit/c8ef2feda )**: Remove redundant word "the" (#13919 ) //<John Lin>//
- **[55444a6f4](https://github.com/facebook/react/commit/55444a6f4 )**: Try rendering again if a timed out tree receives an update (#13921 ) //<Andrew Clark>//
- **[04c4f2fce](https://github.com/facebook/react/commit/04c4f2fce )**: [reconciler] ReactFiberNewContext import maxSigned31BitInt twice (#13857 ) //<yongningfu>//
- **[409e472fc](https://github.com/facebook/react/commit/409e472fc )**: Add flow types in ReactControlledComponent (#13669 ) //<Abdul Rauf>//
- **[663835a43](https://github.com/facebook/react/commit/663835a43 )**: Add flow types in getEventModifierState (#13909 ) //<Abdul Rauf>//
- **[82710097f](https://github.com/facebook/react/commit/82710097f )**: Add flow types in getNodeForCharacterOffset (#13908 ) //<Abdul Rauf>//
- **[b753f76a7](https://github.com/facebook/react/commit/b753f76a7 )**: Fix failing async tests in Node 10 //<Andrew Clark>//
- **[b5c0852fd](https://github.com/facebook/react/commit/b5c0852fd )**: Bump version to 16.6.0-beta.0 (#13906 ) //<Dan Abramov>//
- **[769b1f270](https://github.com/facebook/react/commit/769b1f270 )**: pure -> memo (#13905 ) //<Dan Abramov>//
- **[8ecd4bd4f](https://github.com/facebook/react/commit/8ecd4bd4f )**: Add support for React.pure in ReactDOMServer (#13855 ) //<Alex Taylor>//
- **[15b11d23f](https://github.com/facebook/react/commit/15b11d23f )**: Allow arbitrary types to be wrapped in pure (#13903 ) //<Sebastian Markbåge>//
- **[e770af7a3](https://github.com/facebook/react/commit/e770af7a3 )**: Add back accidentally deleted `break` to prevent fallthrough //<Andrew Clark>//
- **[95a313ec0](https://github.com/facebook/react/commit/95a313ec0 )**: Unfork Lazy Component Branches (#13902 ) //<Sebastian Markbåge>//
- **[e16cdd5b1](https://github.com/facebook/react/commit/e16cdd5b1 )**: Always bail out timed out children even if they receive an update (#13901 ) //<Andrew Clark>//
- **[7268d97d2](https://github.com/facebook/react/commit/7268d97d2 )**: Centralize props memoization (#13900 ) //<Sebastian Markbåge>//
- **[0fc044679](https://github.com/facebook/react/commit/0fc044679 )**: Class component can suspend without losing state outside concurrent mode (#13899 ) //<Andrew Clark>//
- **[36db53822](https://github.com/facebook/react/commit/36db53822 )**: Bugfix for #13886 (#13896 ) //<Andrew Clark>//
- **[6938dcaac](https://github.com/facebook/react/commit/6938dcaac )**: SSR support for class contextType (#13889 ) //<Sebastian Markbåge>//
- **[fa65c58e1](https://github.com/facebook/react/commit/fa65c58e1 )**: Add readContext to SSR (#13888 ) //<Sebastian Markbåge>//
- **[d9a3cc070](https://github.com/facebook/react/commit/d9a3cc070 )**: React.lazy constructor must return result of a dynamic import (#13886 ) //<Andrew Clark>//
- **[d9659e499](https://github.com/facebook/react/commit/d9659e499 )**: Lazy components must use React.lazy (#13885 ) //<Andrew Clark>//
- **[0648ca618](https://github.com/facebook/react/commit/0648ca618 )**: Revert "React.pure automatically forwards ref" (#13887 ) //<Sophie Alpert>//
- **[4dd772ac1](https://github.com/facebook/react/commit/4dd772ac1 )**: Prettier :( //<Andrew Clark>//
- **[98bab66c3](https://github.com/facebook/react/commit/98bab66c3 )**: Fix lint //<Andrew Clark>//
- **[8ced545e3](https://github.com/facebook/react/commit/8ced545e3 )**: Suspense component does not capture if `fallback` is not defined (#13879 ) //<Andrew Clark>//
- **[b738ced47](https://github.com/facebook/react/commit/b738ced47 )**: Remove render prop option from Suspense (#13880 ) //<Andrew Clark>//
- **[55b827942](https://github.com/facebook/react/commit/55b827942 )**: Strict mode and default mode should have same Suspense semantics (#13882 ) //<Andrew Clark>//
- **[dac9202a9](https://github.com/facebook/react/commit/dac9202a9 )**: Hide timed-out children instead of deleting them so their state ispreserved (#13823 ) //<Andrew Clark>//
- **[4f0bd4590](https://github.com/facebook/react/commit/4f0bd4590 )**: Replacement of old links, by the new ones of the documentation. (#13871 ) //<Pablo Javier D. A>//
- **[7685b55d2](https://github.com/facebook/react/commit/7685b55d2 )**: Remove unstable_read() in favor of direct dispatcher call (#13861 )//<Dan Abramov>//
- **[21a79a1d9](https://github.com/facebook/react/commit/21a79a1d9 )**: [schedule] Call ensureHostCallbackIsScheduled without args (#13852 ) //<Trivikram Kamat>//
- **[9ea4bc6ed](https://github.com/facebook/react/commit/9ea4bc6ed )**: Fix false positive context warning when using an old React (#13850 ) //<Dan Abramov>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions 4773fdf...3ff2c7c
Reviewed By: sebmarkbage
Differential Revision: D12955345
fbshipit-source-id: db12076758fe85a519074ca4fe3aa5ede6f4fd49
2018-11-07 19:36:04 -08:00
6448f4e2f1
RN: Revert React 16.6 Sync
...
Summary:
There are some critical bugs that require further investigation in the most recent upgrade to React 16.6 (and ReactNativeRenderer changes).
This revision reverts the sync until these issues have been resolved.
Reviewed By: mdvacca
Differential Revision: D12918541
fbshipit-source-id: 5c1ada185851ba599f3c86387158a2b41f3dcf3e
2018-11-04 01:08:40 -07:00
8b275a8b8d
React sync for revisions 4773fdf...bf9fadf
...
Summary:
@public
This sync includes the following changes:
- **[bf9fadfcf](https://github.com/facebook/react/commit/bf9fadfcf )**: [Hooks] Remove dispatch callbacks (#14037 ) //<Andrew Clark>//
- **[8c67bbf18](https://github.com/facebook/react/commit/8c67bbf18 )**: [scheduler] Deadline object -> shouldYield (#14025 ) //<Andrew Clark>//
- **[e02086bfc](https://github.com/facebook/react/commit/e02086bfc )**: Warn about variable number of dependencies //<Andrew Clark>//
- **[b92cdef64](https://github.com/facebook/react/commit/b92cdef64 )**: Rename ReactHooks test suite //<Andrew Clark>//
- **[6efbbe068](https://github.com/facebook/react/commit/6efbbe068 )**: Prettier //<Sophie Alpert>//
- **[504576306](https://github.com/facebook/react/commit/504576306 )**: Swap order of function member in hook union types //<Andrew Clark>//
- **[ddbfe2ed5](https://github.com/facebook/react/commit/ddbfe2ed5 )**: Add ESLint rule for React Hooks //<Caleb Meredith>//
- **[acb489963](https://github.com/facebook/react/commit/acb489963 )**: Clear effect tags from a fiber that suspends in non-concurrent mode //<Andrew Clark>//
- **[933b64710](https://github.com/facebook/react/commit/933b64710 )**: Disable hook update callback (2nd arg to setState/dispatch) //<Andrew Clark>//
- **[5fc84efac](https://github.com/facebook/react/commit/5fc84efac )**: Skip updating effect tag when skipping effect //<Sophie Alpert>//
- **[9f34eb79a](https://github.com/facebook/react/commit/9f34eb79a )**: Add readContext to ReactPartialRendererHooks //<Alex Taylor>//
- **[f7cb9d2b2](https://github.com/facebook/react/commit/f7cb9d2b2 )**: Warn about useContext(Consumer|Provider) //<Dan Abramov>//
- **[63cc7d2b3](https://github.com/facebook/react/commit/63cc7d2b3 )**: Test useContext in pure, forwardRef, and PureComponent //<Dan Abramov>//
- **[3a7c6da8d](https://github.com/facebook/react/commit/3a7c6da8d )**: Make effects actually work with memo //<Sophie Alpert>//
- **[75a1c2e72](https://github.com/facebook/react/commit/75a1c2e72 )**: The Lost Effect, chapter 3 //<Sophie Alpert>//
- **[55a4b1f37](https://github.com/facebook/react/commit/55a4b1f37 )**: memo supports Hooks //<Sophie Alpert>//
- **[30aa4ad55](https://github.com/facebook/react/commit/30aa4ad55 )**: The Lost Effect, chapter 2 //<Sophie Alpert>//
- **[b772e0e26](https://github.com/facebook/react/commit/b772e0e26 )**: "functional component" -> "function component" in hooks error messages //<Sebastian Markbåge>//
- **[9e9e3970e](https://github.com/facebook/react/commit/9e9e3970e )**: Warn for Hook set-state on unmounted component //<Sophie Alpert>//
- **[6514697f0](https://github.com/facebook/react/commit/6514697f0 )**: Make sure deletions don't stop passive effects //<Sophie Alpert>//
- **[dd019d34d](https://github.com/facebook/react/commit/dd019d34d )**: Add support for hooks to ReactDOMServer //<Alex Taylor>//
- **[11d0781ee](https://github.com/facebook/react/commit/11d0781ee )**: Defer useEffect until after paint //<Andrew Clark>//
- **[105f2de54](https://github.com/facebook/react/commit/105f2de54 )**: Put hooks behind feature flag //<Andrew Clark>//
- **[7bee9fbdd](https://github.com/facebook/react/commit/7bee9fbdd )**: Initial hooks implementation //<Andrew Clark>//
- **[37c7fe0a5](https://github.com/facebook/react/commit/37c7fe0a5 )**: Update createRoot warning message based on `enableStableConcurrentModeAPIs` (#14017 ) //<Rauno Freiberg>//
- **[95f98a187](https://github.com/facebook/react/commit/95f98a187 )**: fix typo (#13955 ) //<Joseph>//
- **[e217f2f1a](https://github.com/facebook/react/commit/e217f2f1a )**: Updated comment for getEventModifierState (#13918 ) //<Patrick>//
- **[275e76e83](https://github.com/facebook/react/commit/275e76e83 )**: Enable stable concurrent APIs flag for 16.7 alpha (#13928 ) //<Brian Vaughn>//
- **[8b97a9c36](https://github.com/facebook/react/commit/8b97a9c36 )**: Update bundle sizes for 16.6.0 release //<Dan Abramov>//
- **[6c29eabf7](https://github.com/facebook/react/commit/6c29eabf7 )**: Updating package versions for release 16.6.0 //<Dan Abramov>//
- **[d520b358d](https://github.com/facebook/react/commit/d520b358d )**: Revert all package versions to 16.5.2 state //<Dan Abramov>//
- **[8f1ec7649](https://github.com/facebook/react/commit/8f1ec7649 )**: Bump versions to beta.0 //<Dan Abramov>//
- **[5055a83fa](https://github.com/facebook/react/commit/5055a83fa )**: Revert "Revert "Updating dependencies for react-noop-renderer"" //<Dan Abramov>//
- **[3e8b4a5b8](https://github.com/facebook/react/commit/3e8b4a5b8 )**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>//
- **[d8e03de4a](https://github.com/facebook/react/commit/d8e03de4a )**: [react-cache] Remove `cache` as argument to `read` (#13865 ) //<Andrew Clark>//
- **[fefa1269e](https://github.com/facebook/react/commit/fefa1269e )**: Revert accidentally committed existence check (#13931 ) //<Andrew Clark>//
- **[80a0c05ce](https://github.com/facebook/react/commit/80a0c05ce )**: Removed react-cache from the bundle list for now (#13930 ) //<BrianVaughn>//
- **[915e4eab5](https://github.com/facebook/react/commit/915e4eab5 )**: Add "unstable_" prefix to react-cache and jest-react (#13929 ) //<Brian Vaughn>//
- **[cbbc2b6c4](https://github.com/facebook/react/commit/cbbc2b6c4 )**: [Synchronous Suspense] Suspending a class outside concurrent mode (#13926 ) //<Andrew Clark>//
- **[4947fcd76](https://github.com/facebook/react/commit/4947fcd76 )**: Fix lint (#13923 ) //<Sebastian Markbåge>//
- **[d75c69e0c](https://github.com/facebook/react/commit/d75c69e0c )**: Remove unstable_ prefix from Suspense (#13922 ) //<Sebastian Markbåge>//
- **[c8ef2feda](https://github.com/facebook/react/commit/c8ef2feda )**: Remove redundant word "the" (#13919 ) //<John Lin>//
- **[55444a6f4](https://github.com/facebook/react/commit/55444a6f4 )**: Try rendering again if a timed out tree receives an update (#13921 ) //<Andrew Clark>//
- **[04c4f2fce](https://github.com/facebook/react/commit/04c4f2fce )**: [reconciler] ReactFiberNewContext import maxSigned31BitInt twice (#13857 ) //<yongningfu>//
- **[409e472fc](https://github.com/facebook/react/commit/409e472fc )**: Add flow types in ReactControlledComponent (#13669 ) //<Abdul Rauf>//
- **[663835a43](https://github.com/facebook/react/commit/663835a43 )**: Add flow types in getEventModifierState (#13909 ) //<Abdul Rauf>//
- **[82710097f](https://github.com/facebook/react/commit/82710097f )**: Add flow types in getNodeForCharacterOffset (#13908 ) //<Abdul Rauf>//
- **[b753f76a7](https://github.com/facebook/react/commit/b753f76a7 )**: Fix failing async tests in Node 10 //<Andrew Clark>//
- **[b5c0852fd](https://github.com/facebook/react/commit/b5c0852fd )**: Bump version to 16.6.0-beta.0 (#13906 ) //<Dan Abramov>//
- **[769b1f270](https://github.com/facebook/react/commit/769b1f270 )**: pure -> memo (#13905 ) //<Dan Abramov>//
- **[8ecd4bd4f](https://github.com/facebook/react/commit/8ecd4bd4f )**: Add support for React.pure in ReactDOMServer (#13855 ) //<Alex Taylor>//
- **[15b11d23f](https://github.com/facebook/react/commit/15b11d23f )**: Allow arbitrary types to be wrapped in pure (#13903 ) //<Sebastian Markbåge>//
- **[e770af7a3](https://github.com/facebook/react/commit/e770af7a3 )**: Add back accidentally deleted `break` to prevent fallthrough //<Andrew Clark>//
- **[95a313ec0](https://github.com/facebook/react/commit/95a313ec0 )**: Unfork Lazy Component Branches (#13902 ) //<Sebastian Markbåge>//
- **[e16cdd5b1](https://github.com/facebook/react/commit/e16cdd5b1 )**: Always bail out timed out children even if they receive an update (#13901 ) //<Andrew Clark>//
- **[7268d97d2](https://github.com/facebook/react/commit/7268d97d2 )**: Centralize props memoization (#13900 ) //<Sebastian Markbåge>//
- **[0fc044679](https://github.com/facebook/react/commit/0fc044679 )**: Class component can suspend without losing state outside concurrent mode (#13899 ) //<Andrew Clark>//
- **[36db53822](https://github.com/facebook/react/commit/36db53822 )**: Bugfix for #13886 (#13896 ) //<Andrew Clark>//
- **[6938dcaac](https://github.com/facebook/react/commit/6938dcaac )**: SSR support for class contextType (#13889 ) //<Sebastian Markbåge>//
- **[fa65c58e1](https://github.com/facebook/react/commit/fa65c58e1 )**: Add readContext to SSR (#13888 ) //<Sebastian Markbåge>//
- **[d9a3cc070](https://github.com/facebook/react/commit/d9a3cc070 )**: React.lazy constructor must return result of a dynamic import (#13886 ) //<Andrew Clark>//
- **[d9659e499](https://github.com/facebook/react/commit/d9659e499 )**: Lazy components must use React.lazy (#13885 ) //<Andrew Clark>//
- **[0648ca618](https://github.com/facebook/react/commit/0648ca618 )**: Revert "React.pure automatically forwards ref" (#13887 ) //<Sophie Alpert>//
- **[4dd772ac1](https://github.com/facebook/react/commit/4dd772ac1 )**: Prettier :( //<Andrew Clark>//
- **[98bab66c3](https://github.com/facebook/react/commit/98bab66c3 )**: Fix lint //<Andrew Clark>//
- **[8ced545e3](https://github.com/facebook/react/commit/8ced545e3 )**: Suspense component does not capture if `fallback` is not defined (#13879 ) //<Andrew Clark>//
- **[b738ced47](https://github.com/facebook/react/commit/b738ced47 )**: Remove render prop option from Suspense (#13880 ) //<Andrew Clark>//
- **[55b827942](https://github.com/facebook/react/commit/55b827942 )**: Strict mode and default mode should have same Suspense semantics (#13882 ) //<Andrew Clark>//
- **[dac9202a9](https://github.com/facebook/react/commit/dac9202a9 )**: Hide timed-out children instead of deleting them so their state ispreserved (#13823 ) //<Andrew Clark>//
- **[4f0bd4590](https://github.com/facebook/react/commit/4f0bd4590 )**: Replacement of old links, by the new ones of the documentation. (#13871 ) //<Pablo Javier D. A>//
- **[7685b55d2](https://github.com/facebook/react/commit/7685b55d2 )**: Remove unstable_read() in favor of direct dispatcher call (#13861 )//<Dan Abramov>//
- **[21a79a1d9](https://github.com/facebook/react/commit/21a79a1d9 )**: [schedule] Call ensureHostCallbackIsScheduled without args (#13852 ) //<Trivikram Kamat>//
- **[9ea4bc6ed](https://github.com/facebook/react/commit/9ea4bc6ed )**: Fix false positive context warning when using an old React (#13850 ) //<Dan Abramov>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions 4773fdf...bf9fadf
Reviewed By: arcanis
Differential Revision: D12850275
fbshipit-source-id: b6d5c61a044c970c04c2ff3370fa77222afd1eb1
2018-11-02 18:35:04 -07:00
adc8a33fcf
Deploy Flow v0.85 to xplat/js
...
Reviewed By: fishythefish
Differential Revision: D12898653
fbshipit-source-id: 2ed11ce569600fe4c12528939a350dd827c9a29a
2018-11-02 00:28:28 -07:00
66aba09251
jest: upgrade to 24.0.0-alpha.4
...
Summary: Upgrade Jest to 24.0.0-alpha.4
Reviewed By: mjesun
Differential Revision: D12822581
fbshipit-source-id: 6e547ffbd2c3c4f93b8aa540d22dd666582d3f1e
2018-10-31 22:31:32 -07:00
cdbf719307
Bump fbjs-scripts to ^1.0.0 ( #21880 )
...
Summary:
This PR bumps also fbjs-scripts to latest version. Benefit is smaller node_modules and less deps to download as newer version doesn't depend on babel6 anymore.
Pull Request resolved: https://github.com/facebook/react-native/pull/21880
Differential Revision: D12832002
Pulled By: hramos
fbshipit-source-id: fa801aeb70a2f22be6f9c05cd6d981d0af0a0da9
2018-10-30 13:36:59 -07:00
31bb551e75
Bump metro@0.49.0
...
Summary:
trex_ship_with_fireworks
This releases contains the Delta client!
Reviewed By: rafeca
Differential Revision: D12824813
fbshipit-source-id: a34a32e6de309f00d0699443ce463152be247b42
2018-10-29 14:02:46 -07:00
88882951e1
Bump metro@0.48.3
...
Summary: shipit-splash
Reviewed By: mjesun
Differential Revision: D12813972
fbshipit-source-id: 89a804206dee178055e1f299023fc299d611fc98
2018-10-28 17:20:47 -07:00
f867db366a
Bump metro@0.48.2
...
Summary: corgi_shipit_gif
Reviewed By: mjesun
Differential Revision: D10854719
fbshipit-source-id: bf81e2e09e2b315f3bea3cffce1731d0c8662765
2018-10-26 16:28:38 -07:00
1b4fd64325
Upgrade jest to v24.0.0-alpha.2
...
Summary:
This diff updates all `xplat/js` to use the latest version of `jest`.
This version provides performance improvements and fixes to make some tests less flaky
Reviewed By: mjesun
Differential Revision: D10466639
fbshipit-source-id: faa769dac1475c61e00bcd76ed30760b176a2898
2018-10-26 06:26:13 -07:00
11552a7a7a
@allow-large-files flow 0.84 xplat deploy
...
Reviewed By: samwgoldman
Differential Revision: D10851695
fbshipit-source-id: 951c628844bbbc7331d4e75f62485db88e5ba7c4
2018-10-25 18:16:30 -07:00
ec6829087e
Upgrade eslint-plugin-react-native to handle false positives with no-inline-styles
...
Summary: https://github.com/Intellicode/eslint-plugin-react-native/pull/188 was merged which fixes some false positives with no-inline-styles.
Reviewed By: alex288ms
Differential Revision: D10500330
fbshipit-source-id: 9f3331416e99293770c3e2823e1e46ce556f4608
2018-10-22 17:36:51 -07:00
0bf520a821
Remove react-timer-mixin
...
Summary:
This mixin is no longer used!
closes https://github.com/facebook/react-native/issues/21485
Reviewed By: RSNara
Differential Revision: D10451307
fbshipit-source-id: 2315244b2f292cfff71241f95a3afcd9788d74be
2018-10-19 17:59:50 -07:00
b9514995a2
Bump xcode@1.0.0 ( #21766 )
...
Summary:
(cordova-node-)xcode 1.0.0 includes a fix for #13160 plus a few more
fixes. This should increase robustness in Xcode project handling
overall.
Fixes #13160 .
-------------------------
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_
Pull Request resolved: https://github.com/facebook/react-native/pull/21766
Reviewed By: codytwinton
Differential Revision: D10384245
Pulled By: hramos
fbshipit-source-id: 488156be67cfc2d99ca81d7cb82747bab35984a7
2018-10-17 12:13:32 -07:00
7b150690b6
@allow-large-files [flow] update to v0.83
...
Reviewed By: fishythefish
Differential Revision: D10362346
fbshipit-source-id: 0f4cc9977cfaa947e3b23112dd1cf482642e2319
2018-10-13 01:32:48 -07:00
8258b6a280
React: Bump Canary Version
...
Reviewed By: gaearon
Differential Revision: D10302487
fbshipit-source-id: 28a00f7076a53dc243ac55ff6c14dc2927318de2
2018-10-10 17:47:08 -07:00
bf47589b8b
Bump metro@0.48.1
...
Summary: iffitsships
Reviewed By: pvdz
Differential Revision: D10255800
fbshipit-source-id: 6cf514dc210e2fcc706e9c6bd555a2b8c9326f21
2018-10-10 13:02:12 -07:00
e7b0590f18
Remove sinon dependency
...
Summary:
This diff removes the `sinon` dependency from `metro` and `react-native-github`. It was only used in a handful of tests and having to learn and remember another mocking API just for these cases was not worth it IMO.
While doing the migration, most of the things that `sinon` provides can be done with `jest` in a very similar (and user friendly) way.
I've found, though, two small things that are more user friendly with `sinon`. I'm documenting them here because it may be worth adding them to jest:
With `sinon`:
```
stub.throws(new Error('foo'));
```
With `jest`:
```
mock.mockImplementation(() => {
throw new Error('foo');
});
```
Taking into account that `jest` has a `mockRejectedValue` method for mocks (to return a rejected promise) I don't see any reason why it does not have a `mockThrowError` method.
With `sinon`:
```
expect(mock1.calledBefore(mock2)).toBeTruthy();
```
With `jest`:
```
expect(mock1.mock.invocationCallOrder[0]).toBeLessThan(
mock2.mock.invocationCallOrder[0],
);
```
There's a community matcher that adds this matcher in `jest-extended`: https://github.com/jest-community/jest-extended#tohavebeencalledbefore , but we're not using `jest-extended` in `xplat/js`.
Reviewed By: jeanlauliac
Differential Revision: D10238331
fbshipit-source-id: 5441125b69596ad85bf8f56d203cfd20759bc358
2018-10-10 13:02:12 -07:00
15c05988e9
Update to Detox 9 ( #21570 )
...
Summary:
Updating to Detox 9 - this should help with better Xcode 10 support, and should fix https://github.com/facebook/react-native/issues/21539 .
I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx ) for the android native dependencies.
Release Notes:
[INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4
Pull Request resolved: https://github.com/facebook/react-native/pull/21570
Reviewed By: TheSavior
Differential Revision: D10242373
Pulled By: RSNara
fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c
2018-10-10 10:01:21 -07:00
7142e9b1c5
React sync for revisions ade5e69...d836010
...
Summary:
This sync includes the following changes:
- **[d83601080](https://github.com/facebook/react/commit/d83601080 )**: Wrap retrySuspendedRoot using SchedulerTracing (#13776 ) //<Sophie Alpert>//
- **[40a521aa7](https://github.com/facebook/react/commit/40a521aa7 )**: Terminology: Functional -> Function Component (#13775 ) //<Dan Abramov>//
- **[605ab10a4](https://github.com/facebook/react/commit/605ab10a4 )**: Add envify transform to scheduler package (#13766 ) //<Michael Ridgway>//
- **[acc7f404c](https://github.com/facebook/react/commit/acc7f404c )**: Restart from root if promise pings before end of render phase (#13774 ) //<Andrew Clark>//
- **[cbc224028](https://github.com/facebook/react/commit/cbc224028 )**: fix - small misspelling (#13768 ) //<Spencer Davies>//
- **[4eabeef11](https://github.com/facebook/react/commit/4eabeef11 )**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>//
- **[95a3e1c2e](https://github.com/facebook/react/commit/95a3e1c2e )**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>//
- **[96bcae9d5](https://github.com/facebook/react/commit/96bcae9d5 )**: Jest + test renderer helpers for concurrent mode (#13751 ) //<Andrew Clark>//
- **[5c783ee75](https://github.com/facebook/react/commit/5c783ee75 )**: Remove unreachable code (#13762 ) //<Heaven>//
- **[36c5d69ca](https://github.com/facebook/react/commit/36c5d69ca )**: Always warn about legacy context within StrictMode tree (#13760 ) //<Brian Vaughn>//
- **[3e9a5de88](https://github.com/facebook/react/commit/3e9a5de88 )**: UMD react-cache build (#13761 ) //<Maksim Markelov>//
- **[8315a30b9](https://github.com/facebook/react/commit/8315a30b9 )**: --save is no longer needed (#13756 ) //<Joe Cortopassi>//
- **[ce96e2df4](https://github.com/facebook/react/commit/ce96e2df4 )**: Rename simple-cache-provider to react-cache (#13755 ) //<Andrew Clark>//
- **[c5212646f](https://github.com/facebook/react/commit/c5212646f )**: Removed extra typeof checks for contextType.unstable_read (#13736 ) //<Brian Vaughn>//
- **[806eebdae](https://github.com/facebook/react/commit/806eebdae )**: Enable getDerivedStateFromError (#13746 ) //<Brian Vaughn>//
- **[a0733fe13](https://github.com/facebook/react/commit/a0733fe13 )**: pure (#13748 ) //<Andrew Clark>//
- **[4d17c3f05](https://github.com/facebook/react/commit/4d17c3f05 )**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>//
- **[469005d87](https://github.com/facebook/react/commit/469005d87 )**: Revise `AttributeType` React Native Flow Type (#13737 ) //<Timothy Yung>//
- **[0dc0ddc1e](https://github.com/facebook/react/commit/0dc0ddc1e )**: Rename AsyncMode -> ConcurrentMode (#13732 ) //<Dominic Gannaway>//
- **[7601c3765](https://github.com/facebook/react/commit/7601c3765 )**: Ensure "addEventListener" exists on "window" for "scheduler" package (#13731 ) //<Dominic Gannaway>//
- **[d0c0ec98e](https://github.com/facebook/react/commit/d0c0ec98e )**: Added a PureComponent contextType test (#13729 ) //<Brian Vaughn>//
- **[4b68a6498](https://github.com/facebook/react/commit/4b68a6498 )**: Support class component static contextType attribute (#13728 ) //<Brian Vaughn>//
- **[f305d2a48](https://github.com/facebook/react/commit/f305d2a48 )**: [scheduler] Priority levels, continuations, and wrapped callbacks (#13720 ) //<Andrew Clark>//
- **[970a34bae](https://github.com/facebook/react/commit/970a34bae )**: Bump babel-eslint and remove flow supressions (#13727 ) //<Brian Ng>//
- **[13965b4d3](https://github.com/facebook/react/commit/13965b4d3 )**: Interaction tracking ref-counting bug fixes (WIP) (#13590 ) //<Brian Vaughn>//
- **[17e703cb9](https://github.com/facebook/react/commit/17e703cb9 )**: Restore global window.event after event dispatching (#13688 ) (#13697 ) //<Sergei Startsev>//
- **[a775a767a](https://github.com/facebook/react/commit/a775a767a )**: Remove redundant logic (#13502 ) //<Heaven>//
- **[e1a067dea](https://github.com/facebook/react/commit/e1a067dea )**: Fix circular dependency in TracingSubscriptions (#13689 ) //<Maksim Markelov>//
- **[518812eeb](https://github.com/facebook/react/commit/518812eeb )**: Clarify comment (#13684 ) //<Heaven>//
- **[eeb817785](https://github.com/facebook/react/commit/eeb817785 )**: Remove some old files from stats //<Dan>//
- **[7ea3ca1d1](https://github.com/facebook/react/commit/7ea3ca1d1 )**: Rename schedule to scheduler (#13683 ) //<Dan Abramov>//
- **[bec2ddaf1](https://github.com/facebook/react/commit/bec2ddaf1 )**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>//
- **[4269fafb0](https://github.com/facebook/react/commit/4269fafb0 )**: Updating package versions for release 16.5.2 //<Brian Vaughn>//
- **[4380f9ba1](https://github.com/facebook/react/commit/4380f9ba1 )**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>//
- **[72fad84e7](https://github.com/facebook/react/commit/72fad84e7 )**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>//
- **[c3fad5acf](https://github.com/facebook/react/commit/c3fad5acf )**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>//
- **[dd9120561](https://github.com/facebook/react/commit/dd9120561 )**: Kepp calling peformWork consistent (#13596 ) //<Heaven>//
- **[42d12317a](https://github.com/facebook/react/commit/42d12317a )**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>//
- **[489614c4f](https://github.com/facebook/react/commit/489614c4f )**: Updating dependencies for react-noop-renderer //<Brian Vaughn>//
- **[351c9015c](https://github.com/facebook/react/commit/351c9015c )**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>//
- **[a210b5b44](https://github.com/facebook/react/commit/a210b5b44 )**: Revert "Do not bind topLevelType to dispatch" (#13674 ) //<Dan Abramov>//
- **[1d8a75fef](https://github.com/facebook/react/commit/1d8a75fef )**: remove flow typings from Schedule.js (#13662 ) //<Alexey Raspopov>//
- **[d92114b98](https://github.com/facebook/react/commit/d92114b98 )**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (#13643 ) //<Nathan Hunzaker>//
- **[0c9c591bf](https://github.com/facebook/react/commit/0c9c591bf )**: Do not bind topLevelType to dispatch (#13618 ) //<Nathan Hunzaker>//
- **[9f819a5ea](https://github.com/facebook/react/commit/9f819a5ea )**: [schedule] Refactor Schedule, remove React-isms (#13582 ) //<Andrew Clark>//
- **[9c961c0a2](https://github.com/facebook/react/commit/9c961c0a2 )**: Fix some iframe edge cases (#13650 ) //<Jérôme Steunou>//
- **[8bc0bcabe](https://github.com/facebook/react/commit/8bc0bcabe )**: Add UMD production+profiling entry points (#13642 ) //<Brian Vaughn>//
- **[b488a5d9c](https://github.com/facebook/react/commit/b488a5d9c )**: Fix test comment typo (#13568 ) //<Heaven>//
- **[4bcee5621](https://github.com/facebook/react/commit/4bcee5621 )**: Rename "tracking" API to "tracing" (#13641 ) //<Brian Vaughn>//
- **[72217d081](https://github.com/facebook/react/commit/72217d081 )**: Update bundle sizes for 16.5.1 release //<Dan Abramov>//
- **[8b93a60c5](https://github.com/facebook/react/commit/8b93a60c5 )**: Updating package versions for release 16.5.1 //<Dan Abramov>//
- **[ecbf7af40](https://github.com/facebook/react/commit/ecbf7af40 )**: Enhance dev warnings for forwardRef render function (#13627 ) (#13636 ) //<Andres Rojas>//
- **[228240085](https://github.com/facebook/react/commit/228240085 )**: Delete TapEventPlugin (#13630 ) //<Dan Abramov>//
- **[a079011f9](https://github.com/facebook/react/commit/a079011f9 )**: ð Stop syncing the value attribute on inputs (behind a feature flag) (#13526 ) //<Nathan Hunzaker>//
- **[a7bd7c3c0](https://github.com/facebook/react/commit/a7bd7c3c0 )**: Allow reading default feature flags from bundle tests (#13629 ) //<Dan Abramov>//
- **[d3bbfe09c](https://github.com/facebook/react/commit/d3bbfe09c )**: Fix IE version in comment //<Dan Abramov>//
- **[1b2646a40](https://github.com/facebook/react/commit/1b2646a40 )**: Fix warning without stack for ie9 (#13620 ) //<Aliaksandr Manzhula>//
- **[e49f3ca08](https://github.com/facebook/react/commit/e49f3ca08 )**: honor displayName set on ForwardRef if available (#13615 ) //<Evan Jacobs>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010
Reviewed By: bvaughn
Differential Revision: D10118547
fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071
2018-10-05 18:19:54 -07:00
bd8b942ab9
Bump metro@0.48.0
...
Summary: llamadance
Reviewed By: jeanlauliac
Differential Revision: D10216618
fbshipit-source-id: 62284ab76651d3423b80f63b5d7bb355adbfaf06
2018-10-05 11:33:39 -07:00
12ab08a5aa
Bump metro@0.47.1
...
Summary: We need a new version of Metro with D10119384 to make the new Embeds work well
Reviewed By: davidaurelio
Differential Revision: D10119385
fbshipit-source-id: db7fc71c75c450720af41add466fc88ac38f3066
2018-10-04 04:03:13 -07:00
8a4975051e
Upgrade xplat/js to Flow v0.82
...
Reviewed By: yungsters
Differential Revision: D10139929
fbshipit-source-id: ae44a8af7cab28c4acfd7c97e636467e44adcf37
2018-10-01 22:23:18 -07:00
ee034596fe
FBJS: Upgrade to ^1.0.0
...
Summary: Upgrades all dependents of `fbjs` to the latest version.
Reviewed By: mjesun
Differential Revision: D10100661
fbshipit-source-id: 2e2af616cb2b5eab560872b6c6c60ed264e986b2
2018-09-29 03:17:27 -07:00
57041ee44f
Add tests for out-of-tree platform support ( #20932 )
...
Summary:
This PR is a WIP for adding tests for out-of-tree platform support. [I originally had issues](https://github.com/facebook/react-native/pull/20825#issuecomment-416433611 ) with this, so I want to give it a try in a separate pull request. None of these issues appear on my machine while running these tests as of this rebase - if everything seems okay on CircleCI after this rebase against `master`, I will ditch the [WIP] tag. Otherwise, I will see if I can find a way to make this work.
The bunch of JS files that will give this a "Large PR" tag are in `RNTester/js/OutOfTreeTestPlatform` - they are only used by the bundler and not executed at any point in time. So if another file needs to be added when React Native's module structure changes, you do not need to have a functional JS file in there as a stub. `module.exports` could be `null` if you wanted. I just had copied over stubs from `Libraries` because I wanted a non-trivial haste module map to be in the test.
Pull Request resolved: https://github.com/facebook/react-native/pull/20932
Reviewed By: axe-fb
Differential Revision: D9818112
Pulled By: hramos
fbshipit-source-id: 0b53359b84430fdefb972587c95d19f85773c5fa
2018-09-27 13:19:32 -07:00
4750f52b34
Bump metro@0.47.0
...
Summary: New version on the horizon :)
Reviewed By: mjesun
Differential Revision: D10051460
fbshipit-source-id: 982604bd7a38d1d3ec642f6cd6fea1a40ab0d34f
2018-09-27 07:35:52 -07:00
99cacf4830
package.json: Add flow check commands for iOS and Android ( #21326 )
...
Summary:
This PR adds these two scripts to `package.json`:
* `flow-check-ios` - for running `flow check` on `.ios.js` files
* `flow-check-android` - for running `flow check` on `.android.js` files
The Android command makes use of the new `--flowconfig-name` option added to Flow in `0.80.0`
Pull Request resolved: https://github.com/facebook/react-native/pull/21326
Differential Revision: D10055702
Pulled By: hramos
fbshipit-source-id: e647f8d2995da0a9bd6af242218819fd5745df63
2018-09-26 17:03:07 -07:00
Christoph Nakazawa
Josh Justice
Ivan Filenko
Tim Yung
Mike Grabowski
Héctor Ramos
Eli White
Rafael Oleza
Panagiotis Vekris
Rubén Norte
Spencer Ahrens
Brian Vaughn
Stephy Ma
Sam Goldman
Juuso Heikkinen
Alexandre Kirszenberg
Avik Chaudhuri
Ratchanan Srirattanamet
Marshall Roch
Lorenzo Sciandra
empyrical