6ca6b4988a
Propagate Load Errors through JSExecutor API
...
Reviewed By: mhorowitz
Differential Revision: D4315204
fbshipit-source-id: ae282e0a0398a602dd790de3a2b1adb5fdc1f50c
2016-12-17 04:58:31 -08:00
fa082796a5
Make file backed strings dup the provided file descriptor.
...
Reviewed By: mhorowitz
Differential Revision: D4326645
fbshipit-source-id: 2741f1fead4f42ae76787f8a70c1e787445b827d
2016-12-16 06:13:40 -08:00
45fdcdc93a
YGNodeChildCount -> YGNodeGetChildCount for consistency
...
Reviewed By: gkassabli
Differential Revision: D4333480
fbshipit-source-id: 17058f18fa9e26b3e02f7a1651f7295cae59acad
2016-12-16 04:44:18 -08:00
23e2610f4f
Add YGNodeGetParent api
...
Reviewed By: gkassabli
Differential Revision: D4333456
fbshipit-source-id: 388afd0a01c19a6db73c175bf24c566278832cb9
2016-12-15 09:29:16 -08:00
fb5678e33a
Generalising JSCompiledSourceError to JSLoadSourceError
...
Reviewed By: javache
Differential Revision: D4312888
fbshipit-source-id: de38066247f52eeb64efa48807882b96e3737d0e
2016-12-12 08:43:43 -08:00
f3dbf3ea89
Removing default parameters to functions in `JSBase.h`
...
Differential Revision: D4309440
fbshipit-source-id: f4f795d5736c6d6e5297e2773538df66139e9b84
2016-12-10 05:58:31 -08:00
46919095aa
Simplify bundle loading a little bit.
...
Reviewed By: amnn
Differential Revision: D4306559
fbshipit-source-id: 9733c508aa5a905251e96855794a59ef79d61cfa
2016-12-09 17:58:32 -08:00
f99f10c7ab
Move gmock to shared xplat
...
Reviewed By: capickett
Differential Revision: D4017736
fbshipit-source-id: 46d9b936fe210040835e4b7222053c1520cb7318
2016-12-09 11:13:33 -08:00
30213757d9
Making CompiledSourceError a C enum, to keep `JSBase.h` as a C header
...
Reviewed By: javache
Differential Revision: D4299281
fbshipit-source-id: 14cdc6d4502a70300919dc6a98a5f274076134c7
2016-12-08 16:28:27 -08:00
624104fd0c
Listen to Compiled Source Errors in JSCExecutor fallback code.
...
Reviewed By: javache
Differential Revision: D4284537
fbshipit-source-id: 247717ef55fb6bc0a34a01626c790bd23fd18598
2016-12-08 05:13:40 -08:00
7f8c2985a8
Rename directories
...
Reviewed By: gkassabli
Differential Revision: D4284681
fbshipit-source-id: f0c6855c2c6e4389b7867f48f72cbb697830fc5a
2016-12-07 05:14:12 -08:00
a47678b3e9
Remove init from api
...
Reviewed By: gkassabli
Differential Revision: D4276177
fbshipit-source-id: c4404d0534f381dfacee0625b2847d38de58e038
2016-12-06 14:43:36 -08:00
1ed114e549
Fix an error initializing needsCrossTrailingPos
...
Reviewed By: gkassabli
Differential Revision: D4271422
fbshipit-source-id: e8d72af742d96829684958780eb56e2c375df20c
2016-12-05 09:43:32 -08:00
f4cde4f65c
Add #pragma once and extern C to YGEnums.h
...
Reviewed By: gkassabli
Differential Revision: D4274156
fbshipit-source-id: 9fa0ae146bb9e5bd40d93fa3c56f83424ebd2bf9
2016-12-05 05:13:30 -08:00
f9f32eb426
Load Indexed RAM format on android
...
Reviewed By: javache
Differential Revision: D4268243
fbshipit-source-id: fc969cfc69810d0477c926ffc79c23584fcbd7eb
2016-12-04 16:13:30 -08:00
fd2fb6cd65
Update yoga library name
...
Reviewed By: bestander
Differential Revision: D4273387
fbshipit-source-id: 91373c6ef1e94b330fa249235ba97fec480e17c7
2016-12-04 05:28:29 -08:00
85ac5fc354
Rename C api
...
Differential Revision: D4259190
fbshipit-source-id: 26c8b356ca464d4304f5f9dc4192bff10cea2dc9
2016-12-03 04:44:10 -08:00
b1a23914fa
JSIndexedRAMBundle: Don't read null bytes for scripts
...
Summary:
`JSIndexedRAMBundle` used to read scripts including the terminating null bytes. That worked on iOS, but not on Android, where we have an ascii-only optimization.
This changes that behavior to only read the actual script data excluding the terminal null.
Reviewed By: javache
Differential Revision: D4265374
fbshipit-source-id: 7e6f943666aee610d79939cef09b103305803c69
2016-12-03 02:28:37 -08:00
779508c0ba
Rename enums
...
Differential Revision: D4244360
fbshipit-source-id: c9fcbdd231098c9ff230a6055676bbc7cbd11001
2016-12-02 05:58:45 -08:00
8117a029cb
Fix error from refactor of setMeasuredDimensionsIfEmptyOrFixedSize
...
Reviewed By: gkassabli
Differential Revision: D4258254
fbshipit-source-id: e22e36e67260114081e483527fc7ce378f7f0df9
2016-12-01 07:28:30 -08:00
0e6895f270
Fix typo
...
Reviewed By: amnn
Differential Revision: D4258150
fbshipit-source-id: d41c5426b801d32db6099cf8b29596689f369ba6
2016-12-01 06:58:31 -08:00
65fe3eaa03
Get inspector compiling
...
Reviewed By: lexs
Differential Revision: D4189469
fbshipit-source-id: 2b4278105fe6d632a79c030fcb789ec50918a278
2016-11-28 17:13:31 -08:00
118e981174
Improve configuration of custom JSC
...
Reviewed By: amnn
Differential Revision: D4237462
fbshipit-source-id: ef16b7f81d3158c63a12e32e2e35204635a57543
2016-11-28 12:43:34 -08:00
bd524bd6e8
BREAKING: Change the toValue in JSCExecutor to ValueEncoder<T>::toValue
...
Summary:
The C++ standard requires that when a function is used in a template it's prototype needs to be defined not only before the template specialization, but also before the template itself.
Because of that one needs to (in certain compilers) be aware of the proper order of includes so that the function prototype is defined before the JSCExecutor.h is included.
As a workaround the toValue might be written as a template (ValueEncoder<T>::toValue) defined in JSCExecutor.h instead of being an non-existing symbol.
Thanks to that the JSCExecutor.h does not have to be included before the specialization of the ValueEncoder template.
Reviewed By: mhorowitz
Differential Revision: D4182724
fbshipit-source-id: 9bdf239ae66ef7a7d2c82daf7db5926472687bde
2016-11-24 09:28:29 -08:00
8f03969011
Export some RN functs
...
Reviewed By: majak
Differential Revision: D4230417
fbshipit-source-id: 06845ff8aa0d05d9a4b997ced35cc017650d9d2e
2016-11-24 05:43:38 -08:00
23c9cf1db6
Ensure jscWrapper is always non-null
...
Reviewed By: bnham
Differential Revision: D4231224
fbshipit-source-id: 3400a0c57f1014baa8a59210f33f262625854da8
2016-11-24 04:13:27 -08:00
f2a46b17d4
Replace RCTJSCWrapper with JSCWrapper from ReactCommon
...
Reviewed By: mhorowitz
Differential Revision: D4204516
fbshipit-source-id: 6bcb122daf2848035dfae404ee7a2e9aca0f8087
2016-11-23 11:43:48 -08:00
e1577df1fd
Move all header imports to "<React/..>"
...
Summary:
To make React Native play nicely with our internal build infrastructure we need to properly namespace all of our header includes.
Where previously you could do `#import "RCTBridge.h"`, you must now write this as `#import <React/RCTBridge.h>`. If your xcode project still has a custom header include path, both variants will likely continue to work, but for new projects, we're defaulting the header include path to `$(BUILT_PRODUCTS_DIR)/usr/local/include`, where the React and CSSLayout targets will copy a subset of headers too. To make Xcode copy headers phase work properly, you may need to add React as an explicit dependency to your app's scheme and disable "parallelize build".
Reviewed By: mmmulani
Differential Revision: D4213120
fbshipit-source-id: 84a32a4b250c27699e6795f43584f13d594a9a82
2016-11-23 07:58:39 -08:00
5db7484e8d
Move `ScriptTag` and `RCTJSModulesUnbundle` to `cxxreact`
...
Reviewed By: javache
Differential Revision: D4213662
fbshipit-source-id: fc2ec9717c24fe77bb022a48777049f88173ebeb
2016-11-23 06:43:50 -08:00
dad520476e
Fixup recent fix to flex basis and put it behind an experimental flag
...
Reviewed By: gkassabli
Differential Revision: D4222910
fbshipit-source-id: d693482441fcc4d37a288e2e3529057a04f60541
2016-11-23 05:28:48 -08:00
cb3e575deb
Allow bridge delegate to specify whether to use custom JSC wrapper
...
Reviewed By: mhorowitz
Differential Revision: D4197657
fbshipit-source-id: 09e050f802b41c9a7016456c25381018b2123553
2016-11-23 03:58:41 -08:00
55a615bf98
Poison all system JSC identifiers on iOS to prevent accidental usage
...
Reviewed By: mhorowitz
Differential Revision: D4197375
fbshipit-source-id: 216cd5cfc52fa4d242c8822faf08eb98a35fa43f
2016-11-23 03:58:41 -08:00
333cf3bc99
Fix global constructor warning
...
Reviewed By: davidaurelio
Differential Revision: D4220267
fbshipit-source-id: 37a6ff51609aaa129683d57f853f59758ff55012
2016-11-22 09:43:27 -08:00
3f50a887d9
Move JSC API usage in ReactCommon to our wrapper methods
...
Reviewed By: bnham
Differential Revision: D4197374
fbshipit-source-id: 107a129cff35dddfe06104b607441ad412f83d90
2016-11-22 06:13:33 -08:00
e541d9b108
Define wrapper versions of all JSC methods
...
Reviewed By: bnham
Differential Revision: D4197369
fbshipit-source-id: 53869fe1b56010c8a5330025d06ef557369e4957
2016-11-22 06:13:33 -08:00
1c69b61c26
Added feature to use rounded values
...
Summary:
Added an experimental feature to allow to use only rounded values. See #184 . It's not a perfect solution and definitely can be further improved. I'm looking forward to your ideas.
Closes https://github.com/facebook/css-layout/pull/256
Reviewed By: splhack
Differential Revision: D4214168
Pulled By: emilsjolander
fbshipit-source-id: 6293352d479b7b4dad258eb3f9e0afaa11cf7236
2016-11-22 05:43:26 -08:00
2ca507bf9e
Remove supported platforms from JSC and all the things that depends on it
...
Reviewed By: bnham
Differential Revision: D4213580
fbshipit-source-id: 3830c15b0097030a4e4611aac814b12e1d6ae696
2016-11-21 16:43:31 -08:00
6526548b50
Move measure code for known dimensions out of main layout function
...
Reviewed By: gkassabli
Differential Revision: D4213339
fbshipit-source-id: 5ca35ca307594f3419fd0dee81321d3c2e06710f
2016-11-21 11:13:40 -08:00
85d0dab9bf
Move measure code for empty containers out of main layout function
...
Reviewed By: gkassabli
Differential Revision: D4213313
fbshipit-source-id: 2061a809202f7f948bff1b3ee8dc4c230692a223
2016-11-21 11:13:40 -08:00
cf796248ec
Move custom measure code out of main layout function
...
Reviewed By: gkassabli
Differential Revision: D4213302
fbshipit-source-id: df4bc43848325e99ad338a2fa6d5c9404315b0e6
2016-11-21 11:13:39 -08:00
e1df3c8782
Add aspectRatio style property
...
Reviewed By: gkassabli
Differential Revision: D4211458
fbshipit-source-id: f8d0d318369c7b529ee29e61a52b17d0cf3b396d
2016-11-21 10:13:34 -08:00
d63ba47b59
BREAKING [react_native] Move to new C-based implementation of css-layout in RN Android
...
Summary:
Moves from CSSNodeDEPRECATED to CSSNode. This has shown to be a huge performance win for layout time within FB.
This is BREAKING because CSSNode contains bug fixes that were not migrated to CSSNodeDEPRECATED which may change the way your layout appears. The most common of these by far involves `flex: 1`.
Previously, developers had to put `flex: 1` in many places it didn't belong in order to work around a bug in css-layout. Now `flex: 1` is treated properly and, unfortunately, this means that your layout may no longer look correct. Specifically, you may see that your layout looks collapsed, or children don't render. The fix is to simply remove `flex: 1` from those containers.
Reviewed By: emilsjolander
Differential Revision: D3992787
fbshipit-source-id: 7a3a2a34a8941c0524e6ba3c5379e434d3e03247
2016-11-21 06:28:30 -08:00
0c03b788d7
Create JSCWrapper in C++ bridge
...
Reviewed By: bnham
Differential Revision: D4082204
fbshipit-source-id: 03bff2ac53e6df931063fcd6ba6ad28dc5ae9562
2016-11-21 04:43:42 -08:00
15f848e8d8
Only skip updating computed flex basis within the same generation
...
Reviewed By: dshahidehpour
Differential Revision: D4207106
fbshipit-source-id: fc1063ca79ecf75f6101aadded53bca96cb0585d
2016-11-20 05:13:28 -08:00
2a04569926
Fix usage of old String constructor
...
Reviewed By: amnn
Differential Revision: D4204575
fbshipit-source-id: ea0309ec9bf2c8a4c480188efb00408fcc399e2e
2016-11-18 07:28:24 -08:00
20514e3482
Add JSContextRef param to String constructor
...
Reviewed By: bnham
Differential Revision: D4197300
fbshipit-source-id: 306ffc85e3ced24047b68499f7cdf5e2d31fc052
2016-11-18 06:28:48 -08:00
b1c91606ff
Implement Value.is* using getType
...
Reviewed By: mhorowitz
Differential Revision: D4197286
fbshipit-source-id: 893077a661bbf39b46ef9b10aa9ee552788882a6
2016-11-18 06:28:48 -08:00
674d86cdcb
Add some more helper methods to Value
...
Reviewed By: mhorowitz
Differential Revision: D4197278
fbshipit-source-id: 9a538ff2747d32a54d42627a9f78e4a348dce639
2016-11-18 06:28:48 -08:00
9e00a42fd7
Experimental App Bundle API
...
Reviewed By: michalgr
Differential Revision: D4198629
fbshipit-source-id: b96a4b3ad3e5ab6b4cb8892442c6077edf7058a3
2016-11-18 05:13:31 -08:00
687ae48cc7
use fmaxf to prevent casting from and to double
...
Summary:
Use ```fmaxf``` to prevent double casting.
Closes https://github.com/facebook/css-layout/pull/251
Reviewed By: emilsjolander
Differential Revision: D4199342
Pulled By: splhack
fbshipit-source-id: c04bc68a3c9c97b92e910e885457cf2fe00da28b
2016-11-17 20:43:44 -08:00
Ashok Menon
Emil Sjolander
Michał Gregorczyk
Michael Lee
David Aurelio
Pieter De Baets
Max Sherman
Lukas Piatkowski
Lukas Woehrl
Andy Street