1fb4b6caa0
Summary: Reland https://github.com/facebook/react-native/issues/15611 and added the gcc warning that was different from fb internal config. The original PR missed the static keyword for the `RCTNormalizeAnimatedEventName` function which triggered the gcc warning internally but not with the OSS xcode config. When calling a prop of type `RCTDirectEventBlock` or `RCTBubblingEventBlock` it uses a completely different code path than events using `[RCTEventDispatcher sendEvent:]` and those were not dispatched to the `RCTEventDispatcherListener`s. We also do some event name normalization which caused issues between the JS and native event names. To fix that I simply remove the parts we normalize from the event key. ## Changelog: [iOS] [Fixed] - Support events using RCT{Direct|Bubbling}EventBlock Pull Request resolved: https://github.com/facebook/react-native/pull/25317 Test Plan: Added a Slider (it uses RCTBubblingEventBlock for its onValueChange event) that can control a native animated value in RNTester to reproduce the bug and made sure this diff fixes it. Differential Revision: D15938856 Pulled By: cpojer fbshipit-source-id: 7e7a3459e2a2e8b1254a2f1ec8153a159ea73eed |
||
|---|---|---|
| .. | ||
| Drivers | ||
| Nodes | ||
| RCTAnimation.xcodeproj | ||
| RCTAnimationUtils.h | ||
| RCTAnimationUtils.m | ||
| RCTNativeAnimatedModule.h | ||
| RCTNativeAnimatedModule.m | ||
| RCTNativeAnimatedNodesManager.h | ||
| RCTNativeAnimatedNodesManager.m | ||
| React-RCTAnimation.podspec | ||