react-native-macos/React/Fabric/Surface
Samuel Susla b705eafd22 Fix retain cycle in RCTFabricSurface
Summary:
Changelog: [internal]

Fix retain cycle caused by chain: `RCTSurfaceTouchHandler` -> `RCTSurfaceTouchHandler._rootComponentView` -> `RCTSurfaceTouchHandler`

`RCTSurfaceTouchHandler._rootComponentView` calls `addGestureRecognizer` with `RCTSurfaceTouchHandler` as a parameter which, according to documentation, strongly holds onto gesture recogniser.

https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/js/react-native-github/React/Fabric/RCTSurfaceTouchHandler.mm?lines=189

For details about `addGestureRecognizer`, refer to https://developer.apple.com/documentation/appkit/nsview/1483749-addgesturerecognizer?language=objc#

Reviewed By: shergin

Differential Revision: D23704441

fbshipit-source-id: b1ab0feff552eaf10c1c71a931690c5258ce87cf
2020-09-15 17:34:35 -07:00
..
RCTFabricSurface.h Take viewport offset into account in UIManager.measureInWindow 2020-08-10 12:52:23 -07:00
RCTFabricSurface.mm Fix retain cycle in RCTFabricSurface 2020-09-15 17:34:35 -07:00
RCTFabricSurfaceHostingProxyRootView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTFabricSurfaceHostingProxyRootView.mm Make RCTSurface and RCTFabricSurface conform to common protocol 2020-08-10 12:52:23 -07:00
RCTFabricSurfaceHostingView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTFabricSurfaceHostingView.mm Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00