react-native-macos/React
fortmarek 709a459b1e Fix using Swift in a native module with Fabric enabled (#33743)
Summary:
Using Fabric with a Swift native module is currently broken. There are currently two issues.

If you try to integrate a native module with Swift code, you will get the following error when running `pod install` with Fabric enabled:
```
[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `MyNativeView` depends upon `React-RCTFabric`, `React-Codegen`, `RCTTypeSafety`, and `ReactCommon`, which do not define modules.
To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries),
you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.
```

To resolve this, I have applied the suggestion from the error (set `:modular_headers => true` for the appropriate modules inside `react_native_pods.rb`.

Afterwards, `pod install` succeeds but I still got `Redefinition of module 'React'` during the build due to the conflict inside the generated modulesmaps  `React-Core.modulemap` and `React-RCTFabric.modulemap`. This makes sense since `React-RCTFabric.podspec` has `s.header_dir = "React"` (see [here](https://github.com/facebook/react-native/blob/main/React/React-RCTFabric.podspec#L37)) and the module inherits that. However, we can explicitly specify `module_name` for the podspec which is what I have done. I have named the module `Fabric`, let me know if you think there's a better name.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[iOS] [Fixed] - Fix using Swift in a native module with Fabric enabled

Pull Request resolved: https://github.com/facebook/react-native/pull/33743

Test Plan:
1. Clone [this](https://github.com/fortmarek/react-native) repo
2. From `main`, apply changes from [this](26958fccf4) commit (adding Swift file to the `MyNativeView` native module in the RN tester app)
3. Try to run `USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 USE_CODEGEN_DISCOVERY=1 USE_HERMES=0 bundle exec pod install` inside the `packages/rn-tester`
4. Observe errors
5. Apply [the commit](9772c6209d) from this PR
6. Both pod install and the subsequent build should succeed.

I can also make changes to the current `MyNativeView` module to include Swift as well if it's something that the React Native Core team would be interested in - in case you want the Swift native modules to be always buildable on `main`

Reviewed By: dmitryrykun

Differential Revision: D36097852

Pulled By: cipolleschi

fbshipit-source-id: 2faebcffd1115339f89a406e265a6a040218dc9c
2022-05-04 04:31:23 -07:00
..
AccessibilityResources/en.lproj VoiceOver reads Tab elements as "Tab Description" (#30689) 2021-01-15 11:09:01 -08:00
AppSetup Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
Base Add MC to check whether canSendEvents_DEPRECATED is needed 2022-05-01 13:36:09 -07:00
CoreModules Fix AppState by removing guard for bridge, since it doesn't use bridge 2022-05-01 13:36:09 -07:00
CxxBridge Add MC to test disabling React Native invalidation under memory pressure 2022-04-20 10:59:57 -07:00
CxxLogUtils Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
CxxModule Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
CxxUtils Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
DevSupport Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
FBReactNativeSpec bump iOS and tvOS from 11.0 to 12.4 in cocoapods 2022-03-16 21:08:01 -07:00
Fabric ScrollView fails when contentInsetAdjustmentBehavior is automatic 2022-04-27 06:50:03 -07:00
Inspector Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
Modules Add MC to check whether canSendEvents_DEPRECATED is needed 2022-05-01 13:36:09 -07:00
Profiler Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
Tests Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
UIUtils Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
Views Adopt UIGraphicsImageRenderer API 2022-04-22 17:02:51 -07:00
React-RCTFabric.podspec Fix using Swift in a native module with Fabric enabled (#33743) 2022-05-04 04:31:23 -07:00
third-party.xcconfig Bump boost for Android to 1.76 to align with iOS + fix (#33565) 2022-04-07 04:50:30 -07:00