b2f871a6fa
Summary: Changelog: [General][Fixed] - Remove illegal private property access in VirtualizedSectionList.scrollToLocation `VirtualizedSectionList.scrollToLocation` internally uses `VirtualizedList`'s `_getFrameMetricsApprox` method. This method is private by convention (since it's `_`-prefixed), but under certain build setups this is also enforced at runtime, so using `scrollToLocation` can throw an error. Here, we rename this internal method to `__getFrameMetricsApprox` (adding another leading underscore) which opts it out of being treated as private, while still communicating that it's not part of the public API. We also delete the Flow error suppression that masked this issue. For reference: This convention for private methods (including the double-underscore opt out) has its roots in Facebook's pre-Babel [JSTransform](https://github.com/facebookarchive/jstransform/blob/master/visitors/es6-class-visitors.js) compiler and is implemented in Flow as [`munge_underscores=true`](https://flow.org/en/docs/config/options/#toc-munge-underscores-boolean). Reviewed By: yungsters Differential Revision: D33982339 fbshipit-source-id: 498563c59d42549c94fe90d363677d6d3ea35d2d |
||
|---|---|---|
| .. | ||
| __flowtests__ | ||
| __tests__ | ||
| CellRenderMask.js | ||
| FillRateHelper.js | ||
| FlatList.js | ||
| SectionList.js | ||
| SectionListModern.js | ||
| ViewabilityHelper.js | ||
| VirtualizeUtils.js | ||
| VirtualizedList.js | ||
| VirtualizedListContext.js | ||
| VirtualizedSectionList.js | ||