microsoft
/
react-native-macos
зеркало из https://github.com/microsoft/react-native-macos.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
react-native-macos/Libraries/Utilities
История
Ramanpreet Nara b42371da5a Fix NativeJSDevSupport.onSuccess 
Summary:
`JSDevSupport.onSuccess` is called in `JSDevSupportModule.getJSHierarchy`:

```
const JSDevSupportModule = {
  getJSHierarchy: function(tag: number) {
    try {
      const {
        computeComponentStackForErrorReporting,
      } = ReactNative.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
      const componentStack = computeComponentStackForErrorReporting(tag);
      if (!componentStack) {
        JSDevSupport.onFailure(
          JSDevSupport.ERROR_CODE_VIEW_NOT_FOUND,
          "Component stack doesn't exist for tag " + tag,
        );
      } else {
        JSDevSupport.onSuccess(componentStack);
      }
    } catch (e) {
      JSDevSupport.onFailure(JSDevSupport.ERROR_CODE_EXCEPTION, e.message);
    }
  },
};
```

If you look at the implementation of `computeComponentStackForErrorReporting`, it returns a `string`. The Java NativeModule also accepts a `String` for the argument to `JSDevSupport.onSuccess`. So, I've changed the `NativeJSDevSupport.onSuccess` method signature to match the native implementation (i.e: accept a string).

Changelog:
[General] [Fixed] - Correct argument types of NativeJSDevSupport.onSuccess

Reviewed By: fkgozali

Differential Revision: D18908306

fbshipit-source-id: 1c9a5c6fe5b3a81b25baed520e586ebf7e2514f8
 		2019-12-10 12:35:17 -08:00
..
__mocks__ Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) 2019-05-08 08:48:59 -07:00
__tests__ Add support for native pseudo-OS to Platform.select (#26966) 2019-11-05 05:39:20 -08:00
differ Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
Appearance.js Appearance: stop caching colorScheme in JS 2019-10-24 11:09:10 -07:00
BackHandler.android.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
BackHandler.ios.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
DevSettings.js Add fastRefresh to NativeDevSettings 2019-09-30 07:03:51 -07:00
DeviceInfo.js Add spec for DeviceInfo module 2019-05-29 16:37:15 -07:00
Dimensions.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
GlobalPerformanceLogger.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
HMRClient.js Dismiss all logs on fast refresh 2019-11-20 08:50:49 -08:00
HMRClientProdShim.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
JSDevSupportModule.js add spec for JSDevSupport (#24905) 2019-05-22 03:27:54 -07:00
LoadingView.android.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
LoadingView.ios.js Add a loading bar when loading split bundles 2019-07-18 03:06:49 -07:00
LoadingView.js Add a loading bar when loading split bundles 2019-07-18 03:06:49 -07:00
MatrixMath.js Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
NativeAppearance.js TM JS: Revert to import from TurboModuleRegistry.js 2019-11-08 11:44:16 -08:00
NativeDevLoadingView.js Revert D16969764: Make RCTDevLoadingView TurboModule-compatible 2019-11-21 08:43:12 -08:00
NativeDeviceInfo.js TM JS: Revert to import from TurboModuleRegistry.js 2019-11-08 11:44:16 -08:00
NativeJSDevSupport.js Fix NativeJSDevSupport.onSuccess 2019-12-10 12:35:17 -08:00
NativePlatformConstantsAndroid.js TM JS: Revert to import from TurboModuleRegistry.js 2019-11-08 11:44:16 -08:00
NativePlatformConstantsIOS.js TM JS: Revert to import from TurboModuleRegistry.js 2019-11-08 11:44:16 -08:00
PerformanceLoggerContext.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
PixelRatio.js Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) 2019-05-08 08:48:59 -07:00
Platform.android.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
Platform.ios.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
PolyfillFunctions.js Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) 2019-05-08 08:48:59 -07:00
RCTLog.js Use `invariant` instead of `fbjs/lib/invariant` 2018-12-03 00:07:02 -08:00
ReactNativeTestTools.js RN: New `TouchableWithoutFeedback` 2019-11-27 07:48:38 -08:00
SceneTracker.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
binaryToBase64.js xplat/js/react-native-github 2019-08-09 10:11:15 -07:00
buildStyleInterpolator.js Remove var in Libraries/Utilities/buildStyleInterpolator.js (#22112) 2018-11-04 11:03:09 -08:00
clamp.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
codegenNativeCommands.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
codegenNativeComponent.js Core files should depend on internals directly 2019-12-05 13:33:58 -08:00
createPerformanceLogger.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
deepFreezeAndThrowOnMutationInDev.js Remove var in Libraries/Utilities/deepFreezeAndThrowOnMutationInDev.js (#22126) 2018-11-05 16:15:54 -08:00
defineLazyObjectProperty.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
deprecatedPropType.js Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) 2019-05-08 08:48:59 -07:00
dismissKeyboard.js Move non-license comments out of license header 2019-10-15 20:12:12 -07:00
groupByEveryN.js Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
infoLog.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
logError.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
mapWithSeparator.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
mergeIntoFast.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
registerGeneratedViewConfig.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
setAndForwardRef.js Manual fixes for xplat/js/react-native-github 2019-08-09 10:11:15 -07:00
stringifySafe.js add support for stringifying error object messages to stringifySafe (#25723) 2019-07-23 02:46:19 -07:00
truncate.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
useColorScheme.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
useWindowDimensions.js Fix useWindowDimensions firing continuously after dims change (#26008) 2019-08-23 13:50:56 -07:00
verifyComponentAttributeEquivalence.js Enable codegen ViewConfig in production 2019-10-31 12:09:04 -07:00
warnOnce.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00