react-native-macos/React/Base
Nick Gerleman 063c2b4668 Enable -Wpedantic for targets inside ReactCommon
Summary:
React Native is compiled downstream with MSVC, meaning the introduction of code depending on language extensions specific to gcc/clang may cause breakage.

We can enable `-Wpedantic` to flag any behavior not officially supported by the specified C++ standard. This will includes rules beyond what MSVC has trouble with, but seems to not have too many "noisy warnings".

This change enables -Wpedantic in BUCK targets within ReactCommon.

This makes the OSS C++ build for Android/iOS slightly more permissive than the internal build, A followup is to add the changes to OSS build logic as well, to avoid contributors seeing more errors upon internal submission. (checking with cortinico on how to do this for Android).

react-native-windows uses a higher warning level than `-Wall`, which is an additional cause of compilation failures, but is not addressed as part of this change.

Changelog:
[Internal][Changed] - Enable -Wpedantic for targets inside ReactCommon

Reviewed By: rshest

Differential Revision: D38457812

fbshipit-source-id: 014da1ac0b7ad8f78154e6e447ed58def6bd0d47
2022-08-11 04:37:35 -07:00
..
Surface Minor: Rename RCTNotAllowedInAppWideFabric to RCTNotAllowedInFabricWithoutLegacy 2022-07-08 15:07:55 -07:00
RCTAssert.h Enable -Wpedantic for targets inside ReactCommon 2022-08-11 04:37:35 -07:00
RCTAssert.m Minor: Rename RCTNotAllowedInAppWideFabric to RCTNotAllowedInFabricWithoutLegacy 2022-07-08 15:07:55 -07:00
RCTBridge+Private.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTBridge.h Remove {eventName}: true from ViewConfig validAttributes 2022-01-06 19:09:53 -08:00
RCTBridge.m (Easy) Remove RCTNotAllowedInBridgeless validation for RCTRegisterModule 2022-03-29 17:27:05 -07:00
RCTBridgeDelegate.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTBridgeMethod.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTBridgeModule.h 2/3 Make interop WebView component Bridgeless compatible, and make `uiManager addUIBlock` migration easier 2022-03-02 14:09:56 -08:00
RCTBridgeModuleDecorator.h 1/5 Refactor CxxBridge: Introduce RCTBridgeModuleDecorator to attach @synthesize ivars to RCTTurboModules, in Bridge mode 2022-02-25 08:50:34 -08:00
RCTBridgeModuleDecorator.m 1/5 Refactor CxxBridge: Introduce RCTBridgeModuleDecorator to attach @synthesize ivars to RCTTurboModules, in Bridge mode 2022-02-25 08:50:34 -08:00
RCTBundleManager.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTBundleURLProvider.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTBundleURLProvider.mm Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTCallableJSModules.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTComponentEvent.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTComponentEvent.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTConstants.h Add MC to check whether canSendEvents_DEPRECATED is needed 2022-05-01 13:36:09 -07:00
RCTConstants.m Add MC to check whether canSendEvents_DEPRECATED is needed 2022-05-01 13:36:09 -07:00
RCTConvert.h Added border curve style prop ("Squircle" effect - iOS only) (#33783) 2022-07-21 04:11:30 -07:00
RCTConvert.m Added border curve style prop ("Squircle" effect - iOS only) (#33783) 2022-07-21 04:11:30 -07:00
RCTCxxConvert.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTCxxConvert.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTDefines.h Enable absolute bridgeless with REACT_NATIVE_FORCE_NEW_ARCHITECTURE flag on Wilde 2022-06-21 18:55:29 -07:00
RCTDisplayLink.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTDisplayLink.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTErrorCustomizer.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTErrorInfo.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTErrorInfo.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTEventDispatcher.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTEventDispatcherProtocol.h Make ScrollView sticky headers work w/o dispatching RCTEventEmitter.receiveEvent 2022-06-21 07:36:01 -07:00
RCTFrameUpdate.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTFrameUpdate.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTImageSource.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTImageSource.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTInitializing.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTInvalidating.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJSScriptLoaderModule.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJSStackFrame.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJSStackFrame.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJSThread.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJSThread.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJavaScriptExecutor.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTJavaScriptLoader.h Fix parseTypeFromHeader for Hermes bytecode 2022-03-15 05:58:52 -07:00
RCTJavaScriptLoader.mm Fix parseTypeFromHeader for Hermes bytecode 2022-03-15 05:58:52 -07:00
RCTKeyCommands.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTKeyCommands.m Back out "fixed SDK issue while uploading app in debug scheme" 2022-06-21 10:48:14 -07:00
RCTLog.h Fix RCTLogError and RCTLogWarn to display RedBox or LogBox in Bridgeless 2022-02-14 19:42:07 -08:00
RCTLog.mm Fix RCTLogError and RCTLogWarn to display RedBox or LogBox in Bridgeless 2022-02-14 19:42:07 -08:00
RCTManagedPointer.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTManagedPointer.mm Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTMockDef.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTModuleData.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTModuleData.mm (Easy) 2/5 Refactor RCTModuleData to use RCTBridgeModuleDecorator, to attach @synthesize ivars to non-TurboModule RCTBridgeModules in Bridge mode 2022-02-25 08:50:34 -08:00
RCTModuleMethod.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTModuleMethod.mm Fix Make Unused Not Compiler Specific (#34357) 2022-08-08 03:50:58 -07:00
RCTModuleRegistry.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTMultipartDataTask.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTMultipartDataTask.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTMultipartStreamReader.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTMultipartStreamReader.m fixing more imports 2022-06-14 13:37:04 -07:00
RCTNullability.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTPLTag.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTParserUtils.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTParserUtils.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTPerformanceLogger.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTPerformanceLogger.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTPerformanceLoggerLabels.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTPerformanceLoggerLabels.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRedBoxSetEnabled.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRedBoxSetEnabled.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTReloadCommand.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTReloadCommand.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootContentView.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootContentView.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootView.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootView.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootViewDelegate.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTRootViewInternal.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTTouchEvent.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTTouchEvent.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTTouchHandler.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTTouchHandler.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTURLRequestDelegate.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTURLRequestHandler.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTUtils.h prevent from publishing dimensions change event when app changes state (#34014) 2022-06-28 08:56:25 -07:00
RCTUtils.m prevent from publishing dimensions change event when app changes state (#34014) 2022-06-28 08:56:25 -07:00
RCTUtilsUIOverride.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTUtilsUIOverride.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTVersion.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTVersion.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTViewRegistry.m 2/3 Make interop WebView component Bridgeless compatible, and make `uiManager addUIBlock` migration easier 2022-03-02 14:09:56 -08:00
RCTWeakProxy.h Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00
RCTWeakProxy.m Update copyright headers from Facebook to Meta 2021-12-30 15:11:21 -08:00