react-native-macos/React/Base
Nick Lockwood 634cdfb76a Removed duplicate key registration bug
Summary:
@public

I was using UIKeyCommand as a key in a dictionary, but it seems iOS wasn't treating identical commands as equal, so it was possible to register the same key command twice, resulting in the command triggering the action multiple times.

I've now created a container object for the key commands, and not relying on undocumented hashing behavior of UIKeyCommand for deduplication any more.

Test Plan: Reload bridge multiple times, then check that the number of registered keys in the command set inside RCTKeyCommands doesn't keep increasing.
2015-06-19 08:13:29 -08:00
..
RCTAssert.h Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTAssert.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTBridge.h [ReactNative] Remove RCT_IMPORT_METHOD macro and generate lookup table dynamically 2015-06-15 13:05:52 -08:00
RCTBridge.m Changed methodQueue to a property 2015-06-19 04:20:39 -08:00
RCTBridgeModule.h Changed methodQueue to a property 2015-06-19 04:20:39 -08:00
RCTCache.h Updates from Thu 26 Mar 2015-03-26 06:32:01 -07:00
RCTCache.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTConvert.h Removed deprecated RCT_EXPORT + code paths 2015-06-05 09:58:25 -08:00
RCTConvert.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTDefines.h Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTDevMenu.h [ReactNative] Refactor DevMenu items construction 2015-06-03 16:42:23 -08:00
RCTDevMenu.m [ReactNative] Fix retain cycle on DevMenu 2015-06-19 07:44:23 -08:00
RCTEventDispatcher.h [ReactNative] Implement proper event coalescing 2015-05-27 20:41:20 -08:00
RCTEventDispatcher.m [ReactNative] Remove RCT_IMPORT_METHOD macro and generate lookup table dynamically 2015-06-15 13:05:52 -08:00
RCTFPSGraph.h [ReactNative] Add fps monitor 2015-05-20 18:26:36 -08:00
RCTFPSGraph.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTFrameUpdate.h [ReactNative] Use a single DisplayLink held by the bridge 2015-04-15 07:07:48 -08:00
RCTInvalidating.h [React Kit] Remove embarrassing TODOs 2015-03-26 10:33:05 -08:00
RCTJSMethodRegistrar.h Added non-class-scanning-based approach fror registering js methods 2015-04-08 05:45:20 -08:00
RCTJavaScriptExecutor.h Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTJavaScriptLoader.h [ReactNative] Create private underlying bridge to prevent retain cycles 2015-05-04 10:36:20 -08:00
RCTJavaScriptLoader.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTKeyCommands.h Updates from Thu 26 Mar 2015-03-26 06:32:01 -07:00
RCTKeyCommands.m Removed duplicate key registration bug 2015-06-19 08:13:29 -08:00
RCTLog.h Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTLog.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTPerfStats.h [ReactNative] Add fps monitor 2015-05-20 18:26:36 -08:00
RCTPerfStats.m [ReactNative] Add more markers and fix FPS graph 2015-06-17 14:10:52 -08:00
RCTProfile.h [ReactNative] Fix extern on RCTProfile.h 2015-06-17 05:57:10 -08:00
RCTProfile.m [ReactNative] Add ReactPerf info to profiler timeline 2015-06-15 13:04:25 -08:00
RCTRedBox.h [ReactNative] orange box 2015-06-09 14:53:29 -08:00
RCTRedBox.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTRootView.h [WIP] Added loadingView property to RCTRootView 2015-05-28 13:20:46 -08:00
RCTRootView.m [ReactNative] Remove RCT_IMPORT_METHOD macro and generate lookup table dynamically 2015-06-15 13:05:52 -08:00
RCTSparseArray.h Updates from Thu 26 Mar 2015-03-26 06:32:01 -07:00
RCTSparseArray.m Updates from Thu 26 Mar 2015-03-26 06:32:01 -07:00
RCTTouchHandler.h [ReactNative] Send batched calls from objc to js every frame + add bridge profiling 2015-04-17 04:01:02 -08:00
RCTTouchHandler.m [ReactNative] Remove RCT_IMPORT_METHOD macro and generate lookup table dynamically 2015-06-15 13:05:52 -08:00
RCTURLRequestDelegate.h [ReactNative] Refactor RCTDataManager to support pluggable data source modules (RCTURLRequestHandlers) 2015-06-09 12:27:06 -08:00
RCTURLRequestHandler.h [ReactNative] Refactor RCTDataManager to support pluggable data source modules (RCTURLRequestHandlers) 2015-06-09 12:27:06 -08:00
RCTUtils.h Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00
RCTUtils.m Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues 2015-06-15 07:52:50 -08:00