react-native-macos/Libraries/NativeAnimation/Drivers
Ryan Gomba c858420b2d Fix NativeAnimation invalidation & races on iOS
Summary:
This diff attempts to fix a number of iOS native animation bugs related to improper node invalidation and a race with view creation. The major issues were presented in #9120 as problems 3 and 3b, but I'll recap here:

The invalidation model we use is overly complicated and incomplete. The proper combination of `_needsUpdate` and `_hasUpdated` will result in nodes values being recomputed. However, we do not invalidate nodes in all the places we should, e.g. if we create a new view and attach it to an existing value node (see example in #9120). This diff chooses to remove the `_hasUpdated` flag, and simply relies on the `_needsUpdate` flag to mark a node as dirty.

We mark nodes as dirty when they are:
- created
- updated
- attached to new parents
- detached from old parents
- attached to a view

Calling `updateNodeIfNecessary` will, if necessary, compute all invalidated parent values before recomputing the node value. It will then apply the update, and mark the no
Closes https://github.com/facebook/react-native/pull/10663

Differential Revision: D4120301

Pulled By: mkonicek

fbshipit-source-id: e247afcb5d8c15999b8328c664b9f7e764d76a75
2016-11-28 11:13:31 -08:00
..
RCTAnimationDriver.h Fix NativeAnimation invalidation & races on iOS 2016-11-28 11:13:31 -08:00
RCTEventAnimation.h Move all header imports to "<React/..>" 2016-11-23 07:58:39 -08:00
RCTEventAnimation.m Add support for native animated events on iOS 2016-11-01 03:58:53 -07:00
RCTFrameAnimation.h Add support for springs for NativeAnimated on iOS 2016-10-21 04:29:03 -07:00
RCTFrameAnimation.m Fix NativeAnimation invalidation & races on iOS 2016-11-28 11:13:31 -08:00
RCTSpringAnimation.h Add support for springs for NativeAnimated on iOS 2016-10-21 04:29:03 -07:00
RCTSpringAnimation.m Fix NativeAnimation invalidation & races on iOS 2016-11-28 11:13:31 -08:00