react-native-macos/React
David Vacca 6aa297a7f3 Fabric: Fixed crash when LayoutMetrics contained NaN values
Summary:
CALayer will crash if we pass NaN or Inf values.

It's unclear how to detect this case on cross-platform manner holistically, so we have to do it on the mounting layer as well.
NaN/Inf is a kinda valid result of some math operations. Even if we can (and should) detect (and report early) incorrect (NaN and Inf) values which come from JavaScript side, we sometimes cannot backtrace the sources of a calculation that produced an incorrect/useless result.

Besides that, I will investigate why the crash is actually happening, so we might need to fix something in layout engine. But, it general, we cannot capture all errors like that, so we need to have it here anyway.

Reviewed By: JoshuaGross, mmmulani

Differential Revision: D14126058

fbshipit-source-id: 807e5a223bdef48af9a3b7210803863431e8c507
2019-02-19 13:03:15 -08:00
..
Base Don't attempt to load RCTDevLoadingView lazily 2019-02-15 13:31:51 -08:00
CxxBridge Don't attempt to load RCTDevLoadingView lazily 2019-02-15 13:31:51 -08:00
CxxModule Start using getConstants 2019-02-04 17:46:56 -08:00
CxxUtils Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
DevSupport Small changes to get Profile build working 2019-01-28 14:36:30 -08:00
Fabric Fabric: Fixed crash when LayoutMetrics contained NaN values 2019-02-19 13:03:15 -08:00
Inspector RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
Modules Remove android initialAppState fallback check (#23487) 2019-02-17 15:32:13 -08:00
Profiler Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
React.xcodeproj Make logging private 2019-02-19 09:58:26 -08:00
UIUtils Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Views Apply latest shadow view workflow description (#23485) 2019-02-17 15:08:16 -08:00
third-party.xcconfig Upgrade folly to v2018.10.22.00 for iOS (#21976) 2018-10-29 12:13:11 -07:00