microsoft
/
react-native-macos
зеркало из https://github.com/microsoft/react-native-macos.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
react-native-macos/React
История
Michał Pierzchała 49d26eb0c4 cleanup RedBox message and stack output (#24662) 
Summary:
Cleanup RedBox messages and stack traces. This PR consists of 2 changes (I'm good with splitting them up if you'd like):

- [general] filter out some of the internal callsites from the symbolicated stack (I thought about using monospace font for title with code frame, but it looks weird)
- [ios][android] strip ANSI characters (coming from colored Babel code frame) from the error message

I think it's ok to strip it inside native handlers so we can still have a colorful code frame in the terminal output.

**JS Code frame:**

|before|after|
|--|--|
|<img width="400" alt="Screenshot 2019-04-30 at 12 32 05" src="https://user-images.githubusercontent.com/5106466/56956590-ef678d80-6b44-11e9-9019-6801f050ab0d.png">|<img width="400" alt="Screenshot 2019-04-30 at 12 52 43" src="https://user-images.githubusercontent.com/5106466/56957302-f42d4100-6b46-11e9-869b-ea9c7ce5b90f.png">|

|before|after|
|--|--|
|![image](https://user-images.githubusercontent.com/5106466/56959472-c8618980-6b4d-11e9-84be-6261d8375f4a.png)|![image](https://user-images.githubusercontent.com/5106466/56959463-bc75c780-6b4d-11e9-9d8b-25ffe46c87cf.png)|

**Filtered stack traces:**

|before|after|
|--|--|
|<img width="50%" alt="Screenshot 2019-04-30 at 12 27 21" src="https://user-images.githubusercontent.com/5106466/56956641-0908d500-6b45-11e9-8cdc-8c2a34a071e5.png"><img width="50%" alt="Screenshot 2019-04-30 at 12 27 28" src="https://user-images.githubusercontent.com/5106466/56956642-0908d500-6b45-11e9-921c-fabfb8515cc0.png">|<img width="100%" alt="Screenshot 2019-04-30 at 12 26 55" src="https://user-images.githubusercontent.com/5106466/56956650-0efeb600-6b45-11e9-9f5f-f10dd69580d1.png">|

There's still a lot of places that are hard to read, but I think this is a good start towards more readable errors.

cc cpojer

[General][Changed] - Cleanup RedBox message and stack output
Pull Request resolved: https://github.com/facebook/react-native/pull/24662

Differential Revision: D15147571

Pulled By: cpojer

fbshipit-source-id: 1de4e521af988fa7fc709b6accd0ddd984388e72
 		2019-04-30 07:35:14 -07:00
..
Base Call designated initializer for SurfaceHostingProxyRootView (#24368) 2019-04-29 21:41:55 -07:00
CxxBridge Fabric iOS: ask the bridge to queue async callback for the RuntimeExecutor 2019-04-10 11:04:23 -07:00
CxxModule Silence Xcode warning (#23880) 2019-03-12 22:08:21 -07:00
CxxUtils Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
DevSupport Change default Inspector Proxy port to 8081 2019-04-03 08:39:08 -07:00
Fabric Fabric: Moving RNWrapManagedObject to `react/utils` module 2019-04-29 21:21:11 -07:00
Inspector Don't reconnect inspector if connection refused (#22625) 2019-02-21 12:52:39 -08:00
Modules cleanup RedBox message and stack output (#24662) 2019-04-30 07:35:14 -07:00
Profiler Fix PerfMonitor appearance when reloading JS (#24073) 2019-03-21 03:21:15 -07:00
React.xcodeproj RNTester: Support RCTCxxBridgeDelegate 2019-04-15 12:25:47 -07:00
UIUtils Calculate Correct Window Dimensions for iOS (#19932) 2019-04-10 14:25:14 -07:00
Views Fixes SafeAreaView when set emulateUnlessSupported on safeArea supported devices (#24615) 2019-04-29 10:02:58 -07:00
React-Core.podspec Move iOS WebView files to FB internal 2019-04-04 15:46:00 -07:00
React-DevSupport.podspec Split React.podspec into separate podspecs for each Xcode project (#23559) 2019-02-21 18:35:44 -08:00
React-RCTFabric.podspec Fabric: working podspecs & works in RNTester (#23803) 2019-03-15 23:59:22 -07:00
third-party.xcconfig Upgrade folly to v2018.10.22.00 for iOS (#21976) 2018-10-29 12:13:11 -07:00