microsoft
/
react-native-macos
зеркало из https://github.com/microsoft/react-native-macos.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
react-native-macos/React/CoreModules
История
Lulu Wu c901c43d11 Remove shared responsibility between LogBox and ExceptionsManager native module 
Summary:
## Context
Right now we are using both LogBox and ExceptionsManager native module to report JS errors in ExceptionsManager.js, from below code we can tell they have some overlapping - when ```__DEV__ === true``` both could report the error.

https://www.internalfb.com/code/fbsource/[5fb44bc926de87e62e6e538082496f22017698eb]/xplat/js/react-native-github/Libraries/Core/ExceptionsManager.js?lines=109-141

## Changes
In this diff overlapping is removed: in ```ExceptionsManager.js``` LogBox will be responsible for showing the error with dialog when ```__DEV__ === true```, when it's prod we'll use ExceptionsManager native module to report the error. As a result LogBox and ExceptionsManager native module don't share responsibilities any more.

Changelog:
[General][Changed] - Remove shared responsibility between LogBox and ExceptionsManager native module

Reviewed By: philIip

Differential Revision: D30942433

fbshipit-source-id: 8fceaaa431e5a460c0ccd151fe9831dcccbcf237
 		2021-10-08 11:08:43 -07:00
..
BUCK Move RCT* Buck targets to GitHub 2021-08-04 13:03:21 -07:00
CoreModulesPlugins.h Make RCTEventDispatcher TurboModule-compatible 2020-10-14 02:40:10 -07:00
CoreModulesPlugins.mm Fix crash in RCTCoreModulesClassProvider during quit 2021-04-28 13:29:06 -07:00
RCTAccessibilityManager+Internal.h Daily `arc lint --take CLANGFORMAT` 2021-10-02 08:33:02 -07:00
RCTAccessibilityManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTAccessibilityManager.mm provide public hook to programatically turn on voiceover 2021-10-01 21:17:07 -07:00
RCTActionSheetManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTActionSheetManager.mm feat: add cancelButtonTintColor props in ActionSheetIOS for change cancel button tint color (#31972) 2021-09-22 10:44:17 -07:00
RCTAlertController.h Fix retain cycle in RCTAlertController 2020-12-04 18:12:23 -08:00
RCTAlertController.m Fix retain cycle in RCTAlertController 2020-12-04 18:12:23 -08:00
RCTAlertManager.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTAlertManager.mm Fix retain cycle in RCTAlertController 2020-12-04 18:12:23 -08:00
RCTAppState.h Call stopObserving on correct queue 2020-09-21 17:30:34 -07:00
RCTAppState.mm Make RCTEventDispatcher TurboModule-compatible 2020-10-14 02:40:10 -07:00
RCTAppearance.h Add dark mode to loading progress 2020-05-12 20:56:06 -07:00
RCTAppearance.mm Addressing various issues with the Appearance API (#28823) (#29106) 2021-10-05 20:23:48 -07:00
RCTAsyncLocalStorage.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTAsyncLocalStorage.mm iOS: Log error when invalid NSNull data is passed to RCTAsyncLocalStorage 2021-08-03 16:41:32 -07:00
RCTClipboard.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTClipboard.mm Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams 2020-04-16 17:29:55 -07:00
RCTDevLoadingView.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTDevLoadingView.mm Daily `arc lint --take CLANGFORMAT` 2021-09-23 07:54:31 -07:00
RCTDevMenu.h Delete concept of live reloading 2021-03-11 16:12:17 -08:00
RCTDevMenu.mm Specify whether DevMenu is bridgeless or bridge 2021-06-29 14:41:49 -07:00
RCTDevSettings.h Migrate RCTDevSettings to initialize 2021-05-21 14:49:51 -07:00
RCTDevSettings.mm Setup a new macro to gate the core packager functionality 2021-09-13 12:09:12 -07:00
RCTDevSplitBundleLoader.h Fix loading from Metro in Bridgeless mode (#29453) 2020-07-23 17:11:32 -07:00
RCTDevSplitBundleLoader.mm Setup a new macro to gate the core packager functionality 2021-09-13 12:09:12 -07:00
RCTDeviceInfo.h Remove unneeded NSNotification center removeObserver 2019-11-04 10:19:30 -08:00
RCTDeviceInfo.mm Move NativeModule initialization logic outside of setModuleRegistry 2021-09-08 12:46:35 -07:00
RCTEventDispatcher.h Migrate NativeModules to initialize 2021-05-21 14:49:51 -07:00
RCTEventDispatcher.mm Remove RCTRootView.bridge usage from RCTBaseViewController 2021-09-02 16:50:08 -07:00
RCTExceptionsManager.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTExceptionsManager.mm Remove shared responsibility between LogBox and ExceptionsManager native module 2021-10-08 11:08:43 -07:00
RCTFPSGraph.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTFPSGraph.m Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTI18nManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTI18nManager.mm Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams 2020-04-16 17:29:55 -07:00
RCTKeyboardObserver.h Make RCTKeyboardObserver TurboModule-compatible 2019-11-01 12:06:20 -07:00
RCTKeyboardObserver.mm Bridgeless Mode: Migrate modules away from invokeJS 2021-05-14 09:22:58 -07:00
RCTLogBox.h Fix Logbox Fullscreen View 2020-08-18 12:29:45 -07:00
RCTLogBox.mm iOS: Don't display LogBox in Dev if Bridge was invalided 2021-08-20 18:45:11 -07:00
RCTLogBoxView.h Fix Logbox Fullscreen View 2020-08-18 12:29:45 -07:00
RCTLogBoxView.mm Fix Logbox Fullscreen View 2020-08-18 12:29:45 -07:00
RCTPerfMonitor.mm Move NativeModule initialization logic outside of setModuleRegistry 2021-09-08 12:46:35 -07:00
RCTPlatform.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTPlatform.mm Run getConstants method statements on main queue 2020-06-02 23:01:35 -07:00
RCTRedBox.h Clang format for all React Native files 2020-03-08 23:01:17 -07:00
RCTRedBox.mm Remove iOS 11 version check (#32151) 2021-09-22 10:37:09 -07:00
RCTSourceCode.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTSourceCode.mm Migrate RCTSourceCode to RCTBundleManager 2021-05-04 18:33:23 -07:00
RCTStatusBarManager.h remove most of tvOS remnants from the code (#29407) 2020-09-28 21:26:41 -07:00
RCTStatusBarManager.mm Make RCTEventDispatcher TurboModule-compatible 2020-10-14 02:40:10 -07:00
RCTTiming.h Migrate NativeModules to initialize 2021-05-21 14:49:51 -07:00
RCTTiming.mm Migrate NativeModules to initialize 2021-05-21 14:49:51 -07:00
RCTWebSocketExecutor.h Make RCTWebSocketModule TurboModule-compatible 2019-11-08 14:14:46 -08:00
RCTWebSocketExecutor.mm Codemod: Give legacy cxx and ObjC-only NativeModules a getTurboModule: method 2021-04-08 21:15:52 -07:00
RCTWebSocketModule.h Make RCTWebSocketModule TurboModule-compatible 2019-11-08 14:14:46 -08:00
RCTWebSocketModule.mm fix: crash when insert nil value into a dictionary (#30066) 2020-10-12 01:47:49 -07:00
React-CoreModules.podspec Link RCT-Folly against libc++abi 2021-09-16 22:24:10 -07:00