9820c88877
Summary: Do not run disabled tests, even when the commit / PR is pushed by hramos. See the existing functionality at https://circleci.com/gh/facebook/react-native/73844?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link: ![screen shot 2019-02-20 at 8 21 39 am](https://user-images.githubusercontent.com/165856/53106776-90ecb600-34e8-11e9-9b02-a7f3990407b2.png) There are a handful of tests that are known to be broken in Circle CI. This has been the case since at least Fall 2017, when we migrated to Circle 2.0. These tests haven't been fixed for several reasons, one of them being that once they were removed from the Circle CI config, the pressure to fix them has been lowered. Last year, I added these disabled tests back to Circle CI, but used a script to prevent them from running unless the job was initiated by myself. This would allow us to get good signal from Circle CI without polluting results with known failing tests, while still showing me which tests needed some work before getting re-enabled again. In practice, this functionality is introducing more friction as I work on fixing new CI failures: my own fixup PRs are marked as failing due to these "disabled tests" (see test_android on https://github.com/facebook/react-native/pull/23558). To ensure we don't lose track of these failures, I've created an umbrella issue at https://github.com/facebook/react-native/issues/23561. Pull Request resolved: https://github.com/facebook/react-native/pull/23562 Differential Revision: D14161172 Pulled By: cpojer fbshipit-source-id: 040500dcb433d3127c64a42b31f94af6bbaa6ed1 |
||
---|---|---|
.. | ||
analyze_code.sh | ||
analyze_scripts.sh | ||
apt-get-android-deps.sh | ||
buck_fetch.sh | ||
check_license.sh | ||
code-analysis-bot.js | ||
exec_swallow_error.sh | ||
gradle_download_deps.sh | ||
validate_yarn_lockfile.sh |