react-native-macos/Libraries/Text/TextInput
Valentin Shergin e271fa190d Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes`
Summary:
This diff changes how we apply default text attributes to backed text input.
The original change in https://github.com/facebook/react-native/pull/23585 that introduced the `reactTextAttributes` field in for RCTBackedTextInputViewProtocol was great! Thank you Wu zhongwuzw !
However, there is one detail that needs to be changed.
RCTBackedTextInputViewProtocol is designed to only abstract complexity of iOS text input components (UITextView and UITextField); it intentionally does not have any React-specific fields or types. Adding a field `RCTTextAttributes *reactTextAttributes;` violates this principle and make it hard to reuse this functionality in the new Fabric-powered TextInput.

This diff changes the type of this prop from `RCTTextAttributes` to `NSDictionary<NSAttributedStringKey,id> *`  (exact same type that UITextView and UITextField use).

Reviewed By: cpojer

Differential Revision: D17408501

fbshipit-source-id: 65f2bba119ccc30f22e87c28d0f8ea6f731cd365
2019-09-17 09:20:54 -07:00
..
Multiline Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
Singleline Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
RCTBackedTextInputDelegate.h Fixed onScroll prop in mulitline TextInput (#23668) 2019-02-27 18:26:27 -08:00
RCTBackedTextInputDelegateAdapter.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTBackedTextInputDelegateAdapter.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTBackedTextInputViewProtocol.h Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
RCTBaseTextInputShadowView.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTBaseTextInputShadowView.m Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
RCTBaseTextInputView.h Don't apply empty attributed string for TextInput (#25143) 2019-06-06 09:17:16 -07:00
RCTBaseTextInputView.m Proper type for `RCTBackedTextInputViewProtocol::defaultTextAttributes` 2019-09-17 09:20:54 -07:00
RCTBaseTextInputViewManager.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTBaseTextInputViewManager.m Make RCTAccessibilityManger a TurboModule 2019-08-23 12:01:52 -07:00
RCTInputAccessoryShadowView.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTInputAccessoryShadowView.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTInputAccessoryView.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTInputAccessoryView.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTInputAccessoryViewContent.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTInputAccessoryViewContent.m Add missing available guard to RCTInputAccessoryViewContent (#26332) 2019-09-09 07:04:50 -07:00
RCTInputAccessoryViewManager.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTInputAccessoryViewManager.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00
RCTTextSelection.h Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTTextSelection.m CocoaPods frameworks compatibility: Step 2 (#25619) 2019-07-24 23:27:09 -07:00