react-native-macos/Libraries/Image
Eloy Durán 25571ec452 Make C++ requirement opt-in (#27730)
Summary:
When building as a framework these headers get automatically added to the framework umbrella header for React-Core. Instead of converting all the React sources to ObjC++ files and still forcing external users that build native source (and link against a framework build) to also compile as ObjC++, this makes the attribution related methods that were added in https://github.com/facebook/react-native/commit/fdcdca4 opt-in to ObjC++ builds.

This is also the reason for the current failure of the CI `test_ios_frameworks` run.

## Changelog

I’m unsure if this change really warrants an entry in the CHANGELOG, as it’s more of an amendment of the (afaik) unreleased [change](https://github.com/facebook/react-native/commit/fdcdca4).

[iOS] [Fixed] - Make framework builds work again by making `RCTImageLoader` C++ requirement opt-in
Pull Request resolved: https://github.com/facebook/react-native/pull/27730

Test Plan:
I tested static and dynamic (framework) builds and ran the test suite.

This change should make the `test_ios_frameworks` CI run _build_ again, ~~but it may still fail overall as in my local testing one of the tests leads to a segfault (which I will try to address separately)~~.

Reviewed By: PeteTheHeat

Differential Revision: D19348846

Pulled By: fkgozali

fbshipit-source-id: 8a74e6f7ad3ddce2cf10b080b9a5d7b399bd5fc0
2020-01-28 13:14:35 -08:00
..
__tests__ Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
AssetRegistry.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
AssetSourceResolver.js Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
Image.android.js Handwritten view configs for Image 2020-01-07 14:46:11 -08:00
Image.ios.js Handwritten view configs for Image 2020-01-07 14:46:11 -08:00
ImageBackground.js Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
ImagePickerIOS.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
ImageProps.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
ImageResizeMode.js RN: Replace `ImageResizeMode` w/ Flow Type 2018-09-28 01:07:30 -07:00
ImageSource.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
ImageViewNativeComponent.js Deploy Flow v0.116 to xplat 2020-01-16 14:05:49 -08:00
ImageViewViewConfig.js Deploy Flow v0.116 to xplat 2020-01-16 14:05:49 -08:00
NativeImageLoaderAndroid.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
NativeImageLoaderIOS.js Exact-by-default codemod for react-native-github 2019-11-21 09:42:57 -08:00
NativeImagePickerIOS.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
RCTAnimatedImage.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTAnimatedImage.m Remove unneeded NSNotification center removeObserver 2019-11-04 10:19:30 -08:00
RCTGIFImageDecoder.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTGIFImageDecoder.mm Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible 2019-10-21 17:15:33 -07:00
RCTImageBlurUtils.h Tidy up license headers [3/n] 2019-10-16 10:06:34 -07:00
RCTImageBlurUtils.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageCache.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageCache.m Remove unneeded NSNotification center removeObserver 2019-11-04 10:19:30 -08:00
RCTImageDataDecoder.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageEditingManager.h Move RCTImage NativeModules back to RCTImage 2019-10-21 17:15:32 -07:00
RCTImageEditingManager.mm Retain cropData object in ImageEditingManager.cropImage 2019-10-22 17:16:33 -07:00
RCTImageLoader.h iOS Fabric: added support for image instrumentation [1] 2019-12-16 22:50:44 -08:00
RCTImageLoader.mm Fix error in RCTImageLoader in bridgeless mode 2020-01-13 22:54:16 -08:00
RCTImageLoaderProtocol.h iOS: Introduced RCTImageURLLoaderWithAttribution 2019-11-16 00:13:47 -08:00
RCTImageLoaderWithAttributionProtocol.h Make C++ requirement opt-in (#27730) 2020-01-28 13:14:35 -08:00
RCTImagePlugins.h Run depslint on fb_plugin_apple_library rules 2019-10-26 13:47:15 -07:00
RCTImagePlugins.mm Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible 2019-10-21 17:15:33 -07:00
RCTImageShadowView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageShadowView.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageStoreManager.h Move RCTImage NativeModules back to RCTImage 2019-10-21 17:15:32 -07:00
RCTImageStoreManager.mm CoreFoundation memory management in RCTImageStoreManager 2019-11-04 14:42:43 -08:00
RCTImageURLLoader.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageURLLoaderWithAttribution.h Make C++ requirement opt-in (#27730) 2020-01-28 13:14:35 -08:00
RCTImageURLLoaderWithAttribution.mm iOS Fabric: added support for image instrumentation [2] 2019-12-16 22:50:45 -08:00
RCTImageUtils.h Tidy up license headers [3/n] 2019-10-16 10:06:34 -07:00
RCTImageUtils.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageView.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageView.mm iOS image: introduced RCTImageURLLoaderRequest for instrumentation/tracking purpose 2019-12-16 22:50:44 -08:00
RCTImageViewManager.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTImageViewManager.mm iOS: Introduced RCTImageURLLoaderWithAttribution 2019-11-16 00:13:47 -08:00
RCTLocalAssetImageLoader.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTLocalAssetImageLoader.mm Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible 2019-10-21 17:15:33 -07:00
RCTResizeMode.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTResizeMode.m Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.h Tidy up license headers [2/n] 2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.m Remove unneeded NSNotification center removeObserver 2019-11-04 10:19:30 -08:00
React-RCTImage.podspec Upgrade Folly to v2020.01.13.00 (#27810) 2020-01-21 12:44:00 -08:00
RelativeImageStub.js xplat/js/react-native-github 2019-08-09 10:11:15 -07:00
TextInlineImageNativeComponent.js Introduce flow type to differentiate between HostComponent, NativeMethodsMixin, and NativeComponent 2019-09-25 10:12:38 -07:00
assetPathUtils.js xplat/js/react-native-github 2019-08-09 10:11:15 -07:00
nativeImageSource.js Convert easy files to flow strict-local 2019-12-05 16:06:46 -08:00
resolveAssetSource.js Move non-license comments out of license header 2019-10-15 20:12:12 -07:00